From 32d0277f0374e01bea384a8c445bb1ea9e3432ba Mon Sep 17 00:00:00 2001
From: Krish Dholakia <krrishdholakia@gmail.com>
Date: Fri, 6 Sep 2024 19:21:54 -0700
Subject: [PATCH]  Allow client-side credentials to be sent to proxy (accept
 only if complete credentials are given) (#5575)

* feat: initial commit

* fix(proxy/auth/auth_utils.py): Allow client-side credentials to be given to the proxy (accept only if complete credentials are given)
---
 litellm/proxy/auth/auth_utils.py | 32 +++++++++++++++++++++++++++++++-
 1 file changed, 31 insertions(+), 1 deletion(-)

diff --git a/litellm/proxy/auth/auth_utils.py b/litellm/proxy/auth/auth_utils.py
index cdc397b1ae5..d415b4534b1 100644
--- a/litellm/proxy/auth/auth_utils.py
+++ b/litellm/proxy/auth/auth_utils.py
@@ -47,6 +47,31 @@ def _check_valid_ip(
     return True, client_ip
 
 
+def check_complete_credentials(request_body: dict) -> bool:
+    """
+    if 'api_base' in request body. Check if complete credentials given. Prevent malicious attacks.
+    """
+    given_model: Optional[str] = None
+
+    given_model = request_body.get("model")
+    if given_model is None:
+        return False
+
+    if (
+        "sagemaker" in given_model
+        or "bedrock" in given_model
+        or "vertex_ai" in given_model
+        or "vertex_ai_beta" in given_model
+    ):
+        # complex credentials - easier to make a malicious request
+        return False
+
+    if "api_key" in request_body:
+        return True
+
+    return False
+
+
 def is_request_body_safe(request_body: dict) -> bool:
     """
     Check if the request body is safe.
@@ -57,7 +82,12 @@ def is_request_body_safe(request_body: dict) -> bool:
     banned_params = ["api_base", "base_url"]
 
     for param in banned_params:
-        if param in request_body:
+        if (
+            param in request_body
+            and not check_complete_credentials(  # allow client-credentials to be passed to proxy
+                request_body=request_body
+            )
+        ):
             raise ValueError(f"BadRequest: {param} is not allowed in request body")
 
     return True