From 31fb3af67ab9e1e8cebd31247bcab066e90170f5 Mon Sep 17 00:00:00 2001
From: Krrish Dholakia <krrishdholakia@gmail.com>
Date: Wed, 25 Feb 2026 11:28:23 -0800
Subject: [PATCH] fix: address greptile comments

---
 .../block_code_execution.py                   |  7 +--
 .../test_block_code_execution.py              | 60 +++++++++++++++++++
 2 files changed, 63 insertions(+), 4 deletions(-)

diff --git a/litellm/proxy/guardrails/guardrail_hooks/block_code_execution/block_code_execution.py b/litellm/proxy/guardrails/guardrail_hooks/block_code_execution/block_code_execution.py
index 124f8ee69fa..53997029418 100644
--- a/litellm/proxy/guardrails/guardrail_hooks/block_code_execution/block_code_execution.py
+++ b/litellm/proxy/guardrails/guardrail_hooks/block_code_execution/block_code_execution.py
@@ -47,12 +47,10 @@ def _normalize_escaped_newlines(text: str) -> str:
     """
     Replace literal escaped newlines (backslash + n or backslash + r) with real newlines.
     API/JSON payloads sometimes deliver newlines as the two-character sequence \\n.
-    Only applies when text has no real newline but contains literal \\n or \\r (double-encoded).
+    Applied whenever \\n or \\r appear, including in mixed content with real newlines.
     """
     if not text:
         return text
-    if "\n" in text:
-        return text
     if "\\n" not in text and "\\r" not in text:
         return text
     # Order matters: replace \r\n first so we don't produce extra \n from \r then \n
@@ -353,7 +351,8 @@ class BlockCodeExecutionGuardrail(CustomGuardrail):
                             delta_content += content
                 accumulated += delta_content
                 # Check after every chunk so we block before yielding the chunk that completes a blocked block
-                blocks = self._find_blocks(accumulated)
+                normalized = _normalize_escaped_newlines(accumulated)
+                blocks = self._find_blocks(normalized)
                 for _start, _end, _tag, _body, confidence, action_taken in blocks:
                     if (
                         action_taken == "block"
diff --git a/tests/test_litellm/proxy/guardrails/guardrail_hooks/test_block_code_execution.py b/tests/test_litellm/proxy/guardrails/guardrail_hooks/test_block_code_execution.py
index f00c110f93b..0fcafc5b9ed 100644
--- a/tests/test_litellm/proxy/guardrails/guardrail_hooks/test_block_code_execution.py
+++ b/tests/test_litellm/proxy/guardrails/guardrail_hooks/test_block_code_execution.py
@@ -367,3 +367,63 @@ print(factorial(5))  # Output: 120
         assert "code block" in (exc_info.value.detail or {}).get("error", "")
         # The chunk that completes the block (third chunk) must not have been yielded
         assert len(yielded_chunks) == 2
+
+    @pytest.mark.asyncio
+    async def test_streaming_hook_blocks_when_accumulated_has_literal_backslash_n(
+        self,
+    ):
+        """Streaming hook normalizes escaped newlines before detection; blocks when literal \\n forms a complete code block."""
+        from litellm.types.utils import (Delta, ModelResponseStream,
+                                         StreamingChoices)
+
+        guardrail = BlockCodeExecutionGuardrail(
+            guardrail_name="test",
+            blocked_languages=["python"],
+            action="block",
+            confidence_threshold=0.5,
+        )
+
+        # Chunks that when concatenated form "```python\\nprint(1)\\n```" (literal backslash-n)
+        async def mock_stream():
+            yield ModelResponseStream(
+                choices=[StreamingChoices(delta=Delta(content="```python\\n"))],
+            )
+            yield ModelResponseStream(
+                choices=[StreamingChoices(delta=Delta(content="print(1)\\n"))],
+            )
+            yield ModelResponseStream(
+                choices=[StreamingChoices(delta=Delta(content="```"))],
+            )
+
+        request_data = {"model": "gpt-4", "metadata": {}}
+        yielded_chunks = []
+
+        with pytest.raises(HTTPException) as exc_info:
+            async for chunk in guardrail.async_post_call_streaming_iterator_hook(
+                user_api_key_dict=None,
+                response=mock_stream(),
+                request_data=request_data,
+            ):
+                yielded_chunks.append(chunk)
+
+        assert exc_info.value.status_code == 400
+        assert "code block" in (exc_info.value.detail or {}).get("error", "")
+        # Block is detected after normalization; chunk that completes the block not yielded
+        assert len(yielded_chunks) == 2
+
+    def test_normalize_escaped_newlines_mixed_content_detects_block(self):
+        """Mixed content (real newlines and literal \\n) is normalized so code block is detected."""
+        # Text with real newline then a fence using literal \n after language tag
+        mixed = "line1\n```py\\nprint(1)\\n```"
+        normalized = _normalize_escaped_newlines(mixed)
+        assert "```py\n" in normalized
+        assert "print(1)\n" in normalized
+        guardrail = BlockCodeExecutionGuardrail(
+            guardrail_name="test",
+            blocked_languages=["python", "py"],
+            confidence_threshold=0.5,
+        )
+        blocks = guardrail._find_blocks(normalized)
+        assert len(blocks) == 1
+        assert blocks[0][2] == "py"
+        assert blocks[0][5] == "block"