scriptoriumadmin/litellm
1
0
Fork 0
mirror of https://github.com/BerriAI/litellm.git synced 2026-09-24 00:52:24 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions 91

fix(mcp,tests): assert cold-start helper directly for aggregate /mcp

Browse source 
Threading client_ip into _target_servers_delegate_auth_to_upstream
made get_mcp_server_by_name(name, client_ip=...) also fire from the
delegate-auth check, so the call_args_list assertion on
client_ip-in-kwargs no longer uniquely signals a cold-start lookup.
Patch _is_mcp_passthrough_cold_start and assert it is not invoked,
which is the actual contract the test is pinning.
This commit is contained in:
mateo-berri 2026-05-21 03:38:27 +00:00
parent 7ba78155d7
commit 31f8c56cb7
No known key found for this signature in database
1 changed files with 7 additions and 7 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

14
tests/test_litellm/proxy/_experimental/mcp_server/auth/test_user_api_key_auth_mcp.py
View file

@ -910,6 +910,9 @@ class TestMCPPassthroughColdStartAdmission:
patch(
"litellm.proxy._experimental.mcp_server.mcp_server_manager.global_mcp_server_manager"
) as mock_mgr,
patch(
"litellm.proxy._experimental.mcp_server.auth.user_api_key_auth_mcp._is_mcp_passthrough_cold_start"
) as mock_cold_start,
):
mock_mgr.get_mcp_server_by_name.return_value = (
TestMCPPassthroughColdStartAdmission._make_passthrough_server()
@ -918,13 +921,10 @@ class TestMCPPassthroughColdStartAdmission:
await MCPRequestHandler.process_mcp_request(scope)
assert exc_info.value.status_code == 401
# Cold-start lookup (signaled by the ``client_ip`` kwarg) must not
# fire for the aggregate ``/mcp`` route — only path-targeted
# routes are eligible for OAuth discovery admission.
assert not any(
"client_ip" in c.kwargs
for c in mock_mgr.get_mcp_server_by_name.call_args_list
)
# Cold-start admission must not fire for the aggregate ``/mcp``
# route — only path-targeted routes are eligible for OAuth
# discovery admission.
mock_cold_start.assert_not_called()
async def test_cold_start_rejects_server_specific_authorization_header(self):
from fastapi import HTTPException