scriptoriumadmin/litellm
1
0
Fork 0
mirror of https://github.com/BerriAI/litellm.git synced 2026-09-11 22:51:28 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions 124

address greptile review feedback (greploop iteration 2)

Browse source 
- Wait for strategy select (API data loaded) before clicking Save
- Assert specific payload content in setCallbacksCall
- Move NotificationsManager import to top of file
This commit is contained in:
yuneng-jiang 2026-02-24 15:52:15 -08:00
parent 784af16cb4
commit 26e5482abb
1 changed files with 13 additions and 7 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

20
ui/litellm-dashboard/src/components/router_settings/index.test.tsx
View file

@ -48,6 +48,7 @@ import {
getRouterSettingsCall,
setCallbacksCall,
} from "@/components/networking";
import NotificationsManager from "@/components/molecules/notifications_manager";
const mockCallbacksResponse = {
router_settings: {
@ -141,29 +142,34 @@ describe("RouterSettings", () => {
const user = userEvent.setup();
renderWithProviders(<RouterSettings {...defaultProps} />);
// Wait for the strategy select to appear — it only renders after getRouterSettingsCall resolves
await waitFor(() => {
expect(screen.getByRole("button", { name: /save changes/i })).toBeInTheDocument();
expect(screen.getByTestId("strategy-select")).toBeInTheDocument();
});
await user.click(screen.getByRole("button", { name: /save changes/i }));
expect(setCallbacksCall).toHaveBeenCalledWith(
"test-token",
expect.objectContaining({ router_settings: expect.any(Object) })
expect.objectContaining({
router_settings: expect.objectContaining({
routing_strategy: "simple-shuffle",
}),
})
);
});
it("should show a success notification after saving", async () => {
const NotificationsManager = await import("@/components/molecules/notifications_manager");
const user = userEvent.setup();
renderWithProviders(<RouterSettings {...defaultProps} />);
await waitFor(() =>
expect(screen.getByRole("button", { name: /save changes/i })).toBeInTheDocument()
);
// Wait for data to load before interacting
await waitFor(() => {
expect(screen.getByTestId("strategy-select")).toBeInTheDocument();
});
await user.click(screen.getByRole("button", { name: /save changes/i }));
expect(NotificationsManager.default.success).toHaveBeenCalledWith(
expect(NotificationsManager.success).toHaveBeenCalledWith(
"router settings updated successfully"
);
});