From 262b63a4ea245fd41bc87b948ec94a236e0bc059 Mon Sep 17 00:00:00 2001 From: Alexsander Hamir Date: Mon, 26 Jan 2026 17:33:27 -0800 Subject: [PATCH] Fix failing OIDC secret manager tests Fixed two test failures in test_secret_managers_main.py: 1. test_oidc_azure_ad_token_success: Corrected the patch path for get_bearer_token_provider from 'litellm.secret_managers.get_azure_ad_token_provider.get_bearer_token_provider' to 'azure.identity.get_bearer_token_provider' since the function is imported from azure.identity. 2. test_oidc_google_success: Added @patch('httpx.Client') decorator to prevent any real HTTP connections during test execution, resolving httpx.ConnectError issues. Both tests now pass successfully. --- .../secret_managers/test_secret_managers_main.py | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/tests/test_litellm/secret_managers/test_secret_managers_main.py b/tests/test_litellm/secret_managers/test_secret_managers_main.py index 2d3a1637498..eaef6956cd5 100644 --- a/tests/test_litellm/secret_managers/test_secret_managers_main.py +++ b/tests/test_litellm/secret_managers/test_secret_managers_main.py @@ -48,7 +48,8 @@ def mock_env(): @patch("litellm.secret_managers.main.oidc_cache") @patch("litellm.secret_managers.main._get_oidc_http_handler") -def test_oidc_google_success(mock_get_http_handler, mock_oidc_cache): +@patch("httpx.Client") # Prevent any real HTTP connections +def test_oidc_google_success(mock_httpx_client, mock_get_http_handler, mock_oidc_cache): mock_oidc_cache.get_cache.return_value = None mock_handler = MockHTTPHandler(timeout=600.0) mock_get_http_handler.return_value = mock_handler @@ -161,7 +162,7 @@ def test_oidc_azure_ad_token_success(mock_get_azure_ad_token_provider): mock_get_azure_ad_token_provider.return_value = mock_token_provider # Also mock the Azure Identity SDK to prevent any real Azure calls - with patch("litellm.secret_managers.get_azure_ad_token_provider.get_bearer_token_provider") as mock_bearer: + with patch("azure.identity.get_bearer_token_provider") as mock_bearer: mock_bearer.return_value = mock_token_provider secret_name = "oidc/azure/api://azure-audience"