scriptoriumadmin/litellm
1
0
Fork 0
mirror of https://github.com/BerriAI/litellm.git synced 2026-09-05 08:07:05 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions 137

test(health): tighten happy-path 200 assertions to exact equality

Browse source 
Per review: `assert response.status_code != 503` is satisfied by 404,
500, or any other non-503 code, so a regression that returned the wrong
non-503 status would slip through. Switch to `== 200` so the assertions
verify the actual expected status, not just the absence of one specific
failure.
This commit is contained in:
Ryan Crabbe 2026-05-01 13:59:10 -07:00
parent 3340533cfb
commit 21e19bf3a5
No known key found for this signature in database
1 changed files with 4 additions and 4 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

8
tests/test_litellm/proxy/health_endpoints/test_health_endpoints.py
View file

@ -1331,7 +1331,7 @@ async def test_health_endpoint_returns_200_when_requested_model_has_healthy_endp
model="model-a",
)
assert response.status_code != 503
assert response.status_code == 200
@pytest.mark.asyncio
@ -1395,7 +1395,7 @@ async def test_health_endpoint_no_model_param_returns_200_even_when_zero_healthy
model_id=None,
)
assert response.status_code != 503
assert response.status_code == 200
@pytest.mark.asyncio
@ -1447,7 +1447,7 @@ async def test_health_readiness_returns_200_when_db_connected():
with patch("litellm.proxy.proxy_server.prisma_client", mock_prisma):
result = await health_readiness(response=response)
assert response.status_code != 503
assert response.status_code == 200
assert result["db"] == "connected"
@ -1466,7 +1466,7 @@ async def test_health_readiness_returns_200_when_no_db_configured():
with patch("litellm.proxy.proxy_server.prisma_client", None):
result = await health_readiness(response=response)
assert response.status_code != 503
assert response.status_code == 200
assert result["db"] == "Not connected"