scriptoriumadmin/litellm
1
0
Fork 0
mirror of https://github.com/BerriAI/litellm.git synced 2026-10-08 03:08:45 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions 115

fix(black_forest_labs): satisfy the basedpyright budget

Browse source 
Three fixes for the delta-vs-base gate.

map_openai_params declared its first parameter as dict while
BaseVideoConfig declares VideoCreateOptionalRequestParams, which is an
incompatible override. The OpenAI and RunwayML video providers both use
the TypedDict; this one was the outlier.

The polling host is now read through a small helper. httpx raises rather
than returning None when a Response carries no request, so the previous
truthiness check was both unsound and a private-attribute access.

The _get_httpx_client import carries a pyright suppression with a reason.
It is the shared client factory the other video providers use to download
generated media, so the private name is deliberate here.
This commit is contained in:
Maanav Dalal 2026-08-18 19:38:10 +00:00
parent e42d293a52
commit 2066b025b1
1 changed files with 15 additions and 4 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

19
litellm/llms/black_forest_labs/videos/transformation.py
View file

@ -20,12 +20,12 @@ from litellm.llms.base_llm.videos.transformation import BaseVideoConfig
from litellm.llms.custom_httpx.http_handler import (
AsyncHTTPHandler,
HTTPHandler,
_get_httpx_client,
_get_httpx_client, # pyright: ignore[reportPrivateUsage] # the shared client factory every provider uses to fetch generated media
get_async_httpx_client,
)
from litellm.secret_managers.main import get_secret_str
from litellm.types.router import GenericLiteLLMParams
from litellm.types.videos.main import VideoObject
from litellm.types.videos.main import VideoCreateOptionalRequestParams, VideoObject
from litellm.types.videos.utils import (
encode_video_id_with_provider,
extract_original_video_id,
@ -123,7 +123,7 @@ class BlackForestLabsVideoConfig(BaseVideoConfig):
def map_openai_params(
self,
video_create_optional_params: dict, # mutable-ok: BaseVideoConfig signature
video_create_optional_params: VideoCreateOptionalRequestParams,
model: str,
drop_params: bool,
) -> dict: # mutable-ok: BaseVideoConfig signature
@ -369,13 +369,24 @@ class BlackForestLabsVideoConfig(BaseVideoConfig):
if custom_llm_provider and video_obj.id:
# Re-attach the region: BFL echoes a bare job id, but the caller may
# reuse this id for content retrieval and must land on the same host.
polled_url: Final = str(raw_response.request.url) if raw_response.request else None
polled_url: Final = self._polled_url(raw_response)
video_obj.id = encode_video_id_with_provider(
_pack_region(video_obj.id, polled_url), custom_llm_provider, None
)
return video_obj
def _polled_url(self, raw_response: httpx.Response) -> str | None:
"""The URL this response came from, when httpx recorded one.
``Response.request`` raises rather than returning None when the response
was built without a request, which is the case in unit tests.
"""
try:
return str(raw_response.request.url)
except RuntimeError:
return None
def _map_status(self, bfl_status: str) -> str:
if bfl_status in _TERMINAL_STATUSES:
return _TERMINAL_STATUSES[bfl_status]