From 1f8714c440c0511e5fa412f2c97cfd8286c4a4df Mon Sep 17 00:00:00 2001 From: yucheng Date: Fri, 25 Sep 2026 01:14:30 +0000 Subject: [PATCH] test(integration): assert the distinct read-failure and report warnings separately for the upstream abort cell Co-Authored-By: Devin AI <158243242+devin-ai-integration[bot]@users.noreply.github.com> --- .../test_passthrough_upstream_error_visibility.py | 12 +++++++----- 1 file changed, 7 insertions(+), 5 deletions(-) diff --git a/tests/integration/observability/test_passthrough_upstream_error_visibility.py b/tests/integration/observability/test_passthrough_upstream_error_visibility.py index c67e5b8c298..6b0ddff36ac 100644 --- a/tests/integration/observability/test_passthrough_upstream_error_visibility.py +++ b/tests/integration/observability/test_passthrough_upstream_error_visibility.py @@ -983,13 +983,15 @@ def test_gemini_passthrough_streaming_429_upstream_abort_after_first_frame_still assert bytes(received).startswith(b'data: {"error":"rate limited"}'), bytes(received) eventually( lambda: _upstream_warnings(owned.log), - lambda lines: any("returned 429" in line or "read failed" in line for line in lines), + lambda lines: ( + any("returned 429" in line for line in lines) and any("read failed" in line for line in lines) + ), seconds=30, ) - matching: Final = tuple( - line for line in _upstream_warnings(owned.log) if "returned 429" in line or "read failed" in line - ) - assert len(matching) == 1, matching + returned: Final = tuple(line for line in _upstream_warnings(owned.log) if "returned 429" in line) + read_failures: Final = tuple(line for line in _upstream_warnings(owned.log) if "read failed" in line) + assert len(returned) == 1, returned + assert len(read_failures) == 1, read_failures error_information: Final = _spend_error_information(call_ids[0]) assert error_information["error_code"] == "429", error_information follow_up: Final = candidate.request(