scriptoriumadmin/litellm
1
0
Fork 0
mirror of https://github.com/BerriAI/litellm.git synced 2026-09-17 23:51:30 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions 67

fix(ui): sign placement for negative net savings and unpriced flag for cache-write-only rows

Browse source
This commit is contained in:
Tin Chi Lo 2026-07-17 23:06:41 -07:00
parent aa6d5ee9e3
commit 1eaad862f0
4 changed files with 18 additions and 5 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

10
litellm/proxy/spend_tracking/cost_savings_endpoints.py
View file

@ -159,9 +159,14 @@ def compute_savings_amounts(
)
def _is_unpriced(cache_read_tokens: int, compression_saved_tokens: int, pricing: ModelPricing | None) -> bool:
def _is_unpriced(
cache_read_tokens: int,
cache_creation_tokens: int,
compression_saved_tokens: int,
pricing: ModelPricing | None,
) -> bool:
if pricing is None:
return cache_read_tokens > 0 or compression_saved_tokens > 0
return cache_read_tokens > 0 or cache_creation_tokens > 0 or compression_saved_tokens > 0
return cache_read_tokens > 0 and pricing.cache_read_cost_per_token is None
@ -208,6 +213,7 @@ def build_activity_response(
for row in rows
if _is_unpriced(
row.cache_read_input_tokens,
row.cache_creation_input_tokens,
row.compression_saved_tokens,
pricing_by_key[(row.model, row.custom_llm_provider)],
)

3
tests/test_litellm/proxy/spend_tracking/test_cost_savings_endpoints.py
View file

@ -139,10 +139,11 @@ class TestBuildActivityResponse:
rows = [
_row(model="mystery-model", custom_llm_provider="", cache_read_input_tokens=100),
_row(model="no-cache-price-model", custom_llm_provider="", cache_read_input_tokens=100),
_row(model="mystery-write-only", custom_llm_provider="", cache_creation_input_tokens=100),
_row(model="mystery-idle", custom_llm_provider="", spend=1.0),
]
response = build_activity_response(rows, COST_MAP)
assert response.unpriced_models == ["mystery-model", "no-cache-price-model"]
assert response.unpriced_models == ["mystery-model", "mystery-write-only", "no-cache-price-model"]
assert response.totals.cache_savings == 0.0

5
ui/litellm-dashboard/src/app/(dashboard)/cost-savings/CostSavingsView.test.tsx
View file

@ -93,6 +93,11 @@ describe("formatUsd", () => {
expect(formatUsd(0.002625)).toBe("$0.002625");
expect(formatUsd(1234.5)).toBe("$1,234.50");
});
it("puts the sign before the dollar symbol for negative net savings", () => {
expect(formatUsd(-1.23)).toBe("-$1.23");
expect(formatUsd(-0.002625)).toBe("-$0.002625");
});
});
describe("CostSavingsView", () => {

5
ui/litellm-dashboard/src/app/(dashboard)/cost-savings/CostSavingsView.tsx
View file

@ -29,11 +29,12 @@ const OPTIMIZATION_TAG_COLOR: Record<CostOptimizationType, string> = {
export function formatUsd(value: number): string {
if (value === 0) return "$0";
const sign = value < 0 ? "-" : "";
const abs = Math.abs(value);
if (abs >= 0.01) {
return `$${value.toLocaleString("en-US", { minimumFractionDigits: 2, maximumFractionDigits: 2 })}`;
return `${sign}$${abs.toLocaleString("en-US", { minimumFractionDigits: 2, maximumFractionDigits: 2 })}`;
}
return `$${value.toFixed(6).replace(/0+$/, "").replace(/\.$/, "")}`;
return `${sign}$${abs.toFixed(6).replace(/0+$/, "").replace(/\.$/, "")}`;
}
function defaultDateRange(): DateRangeValue {