diff --git a/litellm/proxy/spend_tracking/spend_tracking_utils.py b/litellm/proxy/spend_tracking/spend_tracking_utils.py index 342dda31076..4a3cddfdc40 100644 --- a/litellm/proxy/spend_tracking/spend_tracking_utils.py +++ b/litellm/proxy/spend_tracking/spend_tracking_utils.py @@ -1421,7 +1421,6 @@ def should_store_prompts_and_responses_in_spend_logs() -> bool: def _should_store_responses_in_spend_logs() -> bool: from litellm.proxy.proxy_server import general_settings - from litellm.secret_managers.main import get_secret_bool store_responses_value: Final = general_settings.get("store_responses_in_spend_logs") if store_responses_value is not None: @@ -1429,9 +1428,6 @@ def _should_store_responses_in_spend_logs() -> bool: return store_responses_value.lower() == "true" return store_responses_value is True - store_responses_env: Final = get_secret_bool("STORE_RESPONSES_IN_SPEND_LOGS") - if store_responses_env is not None: - return store_responses_env return should_store_prompts_and_responses_in_spend_logs() diff --git a/tests/test_litellm/proxy/spend_tracking/test_spend_tracking_utils.py b/tests/test_litellm/proxy/spend_tracking/test_spend_tracking_utils.py index a1b34e3940a..67ffa5647dc 100644 --- a/tests/test_litellm/proxy/spend_tracking/test_spend_tracking_utils.py +++ b/tests/test_litellm/proxy/spend_tracking/test_spend_tracking_utils.py @@ -1710,16 +1710,15 @@ def test_should_store_prompts_and_responses_in_spend_logs_case_insensitive_strin @pytest.mark.parametrize( - ("settings", "environment", "expected"), + ("settings", "expected"), [ - ({"store_prompts_in_spend_logs": True}, {}, True), - ({"store_prompts_in_spend_logs": False}, {}, False), + ({"store_prompts_in_spend_logs": True}, True), + ({"store_prompts_in_spend_logs": False}, False), ( { "store_prompts_in_spend_logs": True, "store_responses_in_spend_logs": False, }, - {}, False, ), ( @@ -1727,29 +1726,21 @@ def test_should_store_prompts_and_responses_in_spend_logs_case_insensitive_strin "store_prompts_in_spend_logs": False, "store_responses_in_spend_logs": True, }, - {}, True, ), - ({"store_prompts_in_spend_logs": True}, {"STORE_RESPONSES_IN_SPEND_LOGS": False}, False), - ({"store_prompts_in_spend_logs": False}, {"STORE_RESPONSES_IN_SPEND_LOGS": True}, True), ( { "store_prompts_in_spend_logs": True, "store_responses_in_spend_logs": "FALSE", }, - {}, False, ), ], ) -@patch("litellm.secret_managers.main.get_secret_bool") def test_should_store_responses_in_spend_logs( - mock_get_secret_bool, settings, - environment, expected, ): - mock_get_secret_bool.side_effect = environment.get with patch("litellm.proxy.proxy_server.general_settings", settings): assert _should_store_responses_in_spend_logs() is expected