(sap) fix after bot review

litellm/llms/sap/chat/transformation.py

@@ -34,7 +34,7 @@ from .models import ResponseFormatJSONSchema, ResponseFormat, OrchestrationReque
 from .handler import GenAIHubOrchestrationError, AsyncSAPStreamIterator, SAPStreamIterator
 
 def validate_dict(data: dict, model) -> dict:
-    return model(**data).model_dump(by_alias=True, exclude_none=True)
+    return model(**data).model_dump(by_alias=True, exclude_unset=True)
 
 
 class GenAIHubOrchestrationConfig(OpenAIGPTConfig):
@@ -240,7 +240,7 @@ class GenAIHubOrchestrationConfig(OpenAIGPTConfig):
             optional_modules = {}
             optional_modules_lst = ["grounding", "masking", "filtering", "translation"]
             for module in optional_modules_lst:
-                if params.get(module, None) is None:
+                if params.get(module, None) is not None:
                     optional_modules[module] = params.pop(module)
 
             return {

litellm/llms/sap/embed/transformation.py

@@ -62,7 +62,7 @@ class EmbeddingsModules(BaseModel):
 
 class EmbeddingInput(BaseModel):
     text: Union[str, List[str]]
-    type: Literal["text", "document", "query"] = "text"
+    type: Optional[Literal["text", "document", "query"]] = None
 
 class EmbeddingConfig(BaseModel):
     modules: EmbeddingsModules
@@ -73,7 +73,7 @@ class EmbeddingRequest(BaseModel):
 
 
 def validate_dict(data: dict, model) -> dict:
-    return model(**data).model_dump(exclude_none=True, by_alias=True)
+    return model(**data).model_dump(exclude_unset=True, by_alias=True)
 
 
 class GenAIHubEmbeddingConfig(BaseEmbeddingConfig):

tests/test_litellm/llms/sap/embed/test_sap_embed_transformation.py

@@ -27,8 +27,7 @@ def test_basic_config_transform(fake_token_creator, fake_deployment_url):
             }
         },
         'input': {
-            'text': 'Hi',
-            'type': 'text'
+            'text': 'Hi'
         }
     }
     with patch(