scriptoriumadmin/litellm
1
0
Fork 0
mirror of https://github.com/BerriAI/litellm.git synced 2026-10-08 03:08:45 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions 115

remove dead-code response=None guard in _pkce_token_exchange

Browse source
This commit is contained in:
Ishaan Jaffer 2026-03-06 16:02:27 -08:00
parent a439c437df
commit 17b5b90526
1 changed files with 4 additions and 17 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

21
litellm/proxy/management_endpoints/ui_sso.py
View file

@ -2794,14 +2794,10 @@ class SSOAuthenticationHandler:
if client_secret:
token_data["client_secret"] = client_secret
# Initialize response to None — guards against an UnboundLocalError in the
# unlikely case where httpx.AsyncClient() construction itself raises before
# the POST is attempted. The try/except is INSIDE the async with so that
# TLS teardown exceptions from __aexit__ propagate as-is and are NOT
# mis-labelled as "Token endpoint request failed". httpx buffers the full
# response body before __aexit__, so status_code / text / json() remain
# valid after the context exits.
response = None
# The try/except is INSIDE the async with so that TLS teardown exceptions
# from __aexit__ propagate as-is and are NOT mis-labelled as "Token endpoint
# request failed". httpx buffers the full response body before __aexit__,
# so status_code / text / json() remain valid after the context exits.
async with httpx.AsyncClient() as http_client:
try:
response = await http_client.post(token_endpoint, **post_kwargs)
@ -2817,15 +2813,6 @@ class SSOAuthenticationHandler:
code=status.HTTP_401_UNAUTHORIZED,
) from exc
if response is None:
# Should never happen in practice — construction failure is unexpected.
raise ProxyException(
message="Token endpoint request did not return a response",
type=ProxyErrorTypes.auth_error,
param="token_exchange",
code=status.HTTP_401_UNAUTHORIZED,
)
# Response processing outside the async with — httpx buffers the full
# response body so status_code / text / json() remain valid after __aexit__.
if response.status_code != 200: