From 15e570e4c70626d59dcdbd4b8513fa60e37432a1 Mon Sep 17 00:00:00 2001
From: Ishaan Jaff <ishaan@berri.ai>
Date: Sat, 3 Oct 2026 17:34:13 -0700
Subject: [PATCH] test(lens): cover list summaries, review polling and review
 access

---
 tests/unit/proxy/lens/test_endpoints.py | 10 ++++++
 tests/unit/proxy/lens/test_state.py     | 48 +++++++++++++++++++++++++
 2 files changed, 58 insertions(+)

diff --git a/tests/unit/proxy/lens/test_endpoints.py b/tests/unit/proxy/lens/test_endpoints.py
index 783730b7c8f..c6f84524e18 100644
--- a/tests/unit/proxy/lens/test_endpoints.py
+++ b/tests/unit/proxy/lens/test_endpoints.py
@@ -10,6 +10,7 @@ from litellm.proxy._types import LitellmUserRoles, UserAPIKeyAuth
 from litellm import Router
 from litellm.proxy.lens.endpoints import (
     list_agents,
+    read_reviews,
     run_settings,
     run_window,
     user_scope,
@@ -170,6 +171,15 @@ async def test_incompatible_worker_is_rejected_before_claiming_work() -> None:
     assert "Upgrade" in error.value.detail
 
 
+@pytest.mark.parametrize("role", (LitellmUserRoles.INTERNAL_USER, LitellmUserRoles.TEAM, None))
+@pytest.mark.asyncio
+async def test_regular_keys_cannot_poll_live_reviews(role: LitellmUserRoles | None) -> None:
+    auth: Final = UserAPIKeyAuth(user_role=role, team_id="team", token="hashed-test-key")
+    with pytest.raises(HTTPException) as error:
+        await read_reviews("lens", "job", auth)
+    assert error.value.status_code == 403
+
+
 @pytest.mark.parametrize("role", (LitellmUserRoles.INTERNAL_USER, LitellmUserRoles.TEAM, None))
 def test_regular_keys_cannot_read_lens_results(role: LitellmUserRoles | None) -> None:
     auth: Final = UserAPIKeyAuth(user_role=role, team_id="team", token="hashed-test-key")
diff --git a/tests/unit/proxy/lens/test_state.py b/tests/unit/proxy/lens/test_state.py
index 45b0234bc6b..2b87b7623c8 100644
--- a/tests/unit/proxy/lens/test_state.py
+++ b/tests/unit/proxy/lens/test_state.py
@@ -10,11 +10,15 @@ from litellm.proxy.lens.models import (
     AgentTestCase,
     Check,
     Evidence,
+    Execution,
     FindingDraft,
     IssueBrief,
+    Job,
     Lens,
     LensSettings,
+    MetadataFilter,
     Review,
+    Sample,
     Scope,
     Step,
     Worker,
@@ -29,6 +33,8 @@ from litellm.proxy.lens.state import (
     next_scan_start,
     queue_job,
     renew_budget,
+    reviews_after,
+    summarized,
 )
 
 NOW: Final = datetime(2026, 1, 15, tzinfo=timezone.utc)
@@ -368,3 +374,45 @@ def test_reviews_keep_the_newest_window_while_counting_every_review() -> None:
 def test_progress_without_a_review_leaves_the_review_history_alone() -> None:
     job: Final = add_review(queue_job(lens(), NOW, "job").jobs[0], review(0))
     assert add_review(job, None) == job
+
+
+def reviewed_job() -> Job:
+    execution: Final = Execution(
+        id="run-0",
+        source="traces",
+        trace_id="t",
+        team_id="alpha",
+        name="task",
+        start_time="2026-01-15 00:00:00",
+        span_count=3,
+        service="support",
+        metadata=(MetadataFilter(key="gen_ai.agent.name", value="support"),),
+    )
+    job: Final = (
+        queue_job(lens(), NOW, "job")
+        .jobs[0]
+        .model_copy(update={"sample": Sample(executions=(execution,), eligible=4, selected=1)})
+    )
+    timed: Final = tuple(review(i).model_copy(update={"at": NOW + timedelta(seconds=i)}) for i in range(3))
+    return reduce(add_review, timed, job)
+
+
+def test_summary_drops_reviews_and_run_attributes_but_keeps_counts_and_run_identity() -> None:
+    job: Final = reviewed_job()
+    listed: Final = summarized(lens().model_copy(update={"jobs": (job,)})).jobs[0]
+    assert listed.reviews == ()
+    assert listed.reviewed == job.reviewed == 3
+    assert listed.sample is not None and job.sample is not None
+    assert listed.sample.executions[0].metadata == ()
+    assert (
+        listed.sample.executions[0].model_copy(update={"metadata": job.sample.executions[0].metadata})
+        == (job.sample.executions[0])
+    )
+    assert listed.model_copy(update={"reviews": job.reviews, "sample": job.sample}) == job
+
+
+def test_review_polling_returns_only_reviews_newer_than_the_cursor() -> None:
+    job: Final = reviewed_job()
+    assert reviews_after(job, None) == job.reviews
+    assert [r.execution_id for r in reviews_after(job, NOW)] == ["run-1", "run-2"]
+    assert reviews_after(job, job.reviews[-1].at) == ()