Revert "Optimize process_dynamic_callbacks with early return and per-callback conditionals"

This reverts commit 6f486aa774d34a2ea760b7897378c651cf009054.
This commit is contained in:
Alexsander Hamir 2026-01-31 15:17:16 -08:00
parent 7a90b94ff9
commit 15be832af8

View file

@ -406,45 +406,30 @@ class Logging(LiteLLMLoggingBaseClass):
If a callback is in litellm._known_custom_logger_compatible_callbacks, it needs to be intialized and added to the respective dynamic_* callback list.
"""
# Early exit if all callbacks are None (common case)
if (
self.dynamic_input_callbacks is None
and self.dynamic_success_callbacks is None
and self.dynamic_async_success_callbacks is None
and self.dynamic_failure_callbacks is None
and self.dynamic_async_failure_callbacks is None
):
return
# Process input callbacks
self.dynamic_input_callbacks = self._process_dynamic_callback_list(
self.dynamic_input_callbacks, dynamic_callbacks_type="input"
)
# Process input callbacks (standalone - no dependencies)
if self.dynamic_input_callbacks is not None:
self.dynamic_input_callbacks = self._process_dynamic_callback_list(
self.dynamic_input_callbacks, dynamic_callbacks_type="input"
)
# Process failure callbacks
self.dynamic_failure_callbacks = self._process_dynamic_callback_list(
self.dynamic_failure_callbacks, dynamic_callbacks_type="failure"
)
# Process success BEFORE async_success (success processing adds to async_success)
if self.dynamic_success_callbacks is not None:
self.dynamic_success_callbacks = self._process_dynamic_callback_list(
self.dynamic_success_callbacks, dynamic_callbacks_type="success"
)
# Process async failure callbacks
self.dynamic_async_failure_callbacks = self._process_dynamic_callback_list(
self.dynamic_async_failure_callbacks, dynamic_callbacks_type="async_failure"
)
# Process async_success AFTER success
if self.dynamic_async_success_callbacks is not None:
self.dynamic_async_success_callbacks = self._process_dynamic_callback_list(
self.dynamic_async_success_callbacks, dynamic_callbacks_type="async_success"
)
# Process success callbacks
self.dynamic_success_callbacks = self._process_dynamic_callback_list(
self.dynamic_success_callbacks, dynamic_callbacks_type="success"
)
# Process failure BEFORE async_failure (failure processing adds to async_failure)
if self.dynamic_failure_callbacks is not None:
self.dynamic_failure_callbacks = self._process_dynamic_callback_list(
self.dynamic_failure_callbacks, dynamic_callbacks_type="failure"
)
# Process async_failure AFTER failure
if self.dynamic_async_failure_callbacks is not None:
self.dynamic_async_failure_callbacks = self._process_dynamic_callback_list(
self.dynamic_async_failure_callbacks, dynamic_callbacks_type="async_failure"
)
# Process async success callbacks
self.dynamic_async_success_callbacks = self._process_dynamic_callback_list(
self.dynamic_async_success_callbacks, dynamic_callbacks_type="async_success"
)
def _process_dynamic_callback_list(
self,