scriptoriumadmin/litellm
1
0
Fork 0
mirror of https://github.com/BerriAI/litellm.git synced 2026-10-09 03:18:44 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions 109

fix: guard double-decode to only unwrap when result is a dict

Browse source 
Addresses Greptile P1: valid JSON string arguments like "123" were
being coerced to integers because json.loads() was applied on the
string result unconditionally. Only unwrap when the second decode
produces a dict, which is the only valid shape for tool call arguments.

Also removes disallowed explanatory comments per litellm AGENTS.md.
This commit is contained in:
Aftabbs 2026-09-28 07:08:40 +05:30
parent b6934dc9c1
commit 154a0a114e
1 changed files with 8 additions and 12 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

20
litellm/litellm_core_utils/prompt_templates/common_utils.py
View file

@ -2384,19 +2384,15 @@ def parse_tool_call_arguments(
try:
parsed = json.loads(arguments)
if isinstance(parsed, str):
# Double-encoded JSON: json.dumps applied twice by the caller (common
# in agent frameworks that serialise tool arguments through a store).
# Anthropic's tool_use.input must be an object, not a string, so
# unwrap one extra layer and warn so callers can fix the root cause.
verbose_logger.warning(
"Tool call arguments for tool '%s' (%s) decoded to a string "
"instead of an object — double-encoded JSON detected. "
"Attempting second decode.",
tool_name or "<unknown>",
context or "unknown context",
)
try:
parsed = json.loads(parsed)
_second_decode = json.loads(parsed)
if isinstance(_second_decode, dict):
verbose_logger.warning(
"Tool call arguments for tool '%s' (%s) were double-encoded",
tool_name or "<unknown>",
context or "unknown context",
)
parsed = _second_decode
except json.JSONDecodeError:
pass
return parsed