fix(chatgpt): keep the trace-id session marker out of provider params

The marker now uses the _litellm_ internal prefix, so bridges that pass litellm_params back into completion() drop it instead of sending it as a provider param
This commit is contained in:
mateo-berri 2026-10-28 09:38:40 -07:00
parent 4004d1f2b2
commit 125926789b
2 changed files with 10 additions and 1 deletions

View file

@ -1666,7 +1666,6 @@ BILLED_RETRY_ATTEMPT_METADATA_KEY: Final = "billed_retry_attempt"
MANAGED_BACKGROUND_RESPONSE_METADATA_KEY: Final = "_managed_background_response"
SESSION_ID_GENERATED_METADATA_KEY: Final = "litellm_session_id_generated"
SESSION_ID_OMITTED_METADATA_KEY: Final = "litellm_session_id_omitted"
SESSION_ID_FROM_TRACE_ID_PARAM_KEY: Final = "litellm_session_id_from_trace_id"
CALLER_SESSION_ID_METADATA_KEY: Final = "litellm_caller_session_id"
LITELLM_TRUNCATED_PAYLOAD_FIELD: Final = "litellm_truncated"
LITELLM_TRUNCATION_DB_SAFEGUARD_NOTE: Final = (
@ -1735,6 +1734,7 @@ PASS_THROUGH_HEADER_PREFIX: Final = "x-pass-"
TYPESAFE_DANGER_ZONE_HEADER_PREFIX: Final = "typesafe-danger-zone-"
INTERNAL_KWARG_PREFIX: Final = "_litellm_"
CONTROL_OPTIONS_KEY: Final = f"{INTERNAL_KWARG_PREFIX}control"
SESSION_ID_FROM_TRACE_ID_PARAM_KEY: Final = f"{INTERNAL_KWARG_PREFIX}session_id_from_trace_id"
AZURE_SPEECH_CUSTOM_LLM_PROVIDER: Final = "azure_speech"
AZURE_SPEECH_PASS_THROUGH_ROUTE_PREFIX: Final = "/azure_speech"

View file

@ -22,6 +22,7 @@ from litellm.litellm_core_utils.get_litellm_params import (
stored_control_options,
)
from litellm.types.litellm_params import ControlOptions
from litellm.utils import get_non_default_completion_params
def _funnel_kwargs_completion_forwards(monkeypatch, wif_kwargs: dict[str, object]) -> dict[str, object]:
@ -411,6 +412,14 @@ class TestMetadataFallsBackToLitellmMetadata:
result["metadata"].pop("trace_id")
assert litellm_metadata == {"trace_id": "trace-1"}
def test_session_id_derived_from_trace_id_adds_no_provider_params(self):
from_trace_id: Final = get_litellm_params(metadata={"trace_id": "trace-1"})
from_session_id: Final = get_litellm_params(metadata={"session_id": "session-1"})
added_by_trace_id: Final = from_trace_id.keys() - from_session_id.keys()
assert added_by_trace_id
assert not added_by_trace_id & get_non_default_completion_params(from_trace_id).keys()
@pytest.mark.parametrize(
"value, expected",