From 0f78462cc44fbd6654ec68b177d667b5b076d61b Mon Sep 17 00:00:00 2001
From: Javier Garcia <112962975+javiergarciapleo@users.noreply.github.com>
Date: Tue, 3 Mar 2026 09:26:00 +0100
Subject: [PATCH] Address PR suggestions

---
 litellm/integrations/braintrust_logging.py | 41 +++++++++++++---------
 1 file changed, 25 insertions(+), 16 deletions(-)

diff --git a/litellm/integrations/braintrust_logging.py b/litellm/integrations/braintrust_logging.py
index e3133467eb5..ccc11d57bff 100644
--- a/litellm/integrations/braintrust_logging.py
+++ b/litellm/integrations/braintrust_logging.py
@@ -50,6 +50,25 @@ class BraintrustLogger(CustomLogger):
         )
         self.global_braintrust_sync_http_handler = HTTPHandler()
 
+    def _build_prompt_metadata(
+        self, dynamic_metadata: dict, project_id: Optional[str]
+    ) -> Optional[dict]:
+        """
+        Build the prompt metadata dict from dynamic_metadata.
+        Returns None if neither prompt_id nor prompt_slug are present.
+        Only includes fields that are not None.
+        """
+        prompt_id = dynamic_metadata.get("prompt_id")
+        prompt_slug = dynamic_metadata.get("prompt_slug")
+        if prompt_id is None and prompt_slug is None:
+            return None
+        prompt_data: dict = {"project_id": project_id}
+        if prompt_id is not None:
+            prompt_data["id"] = prompt_id
+        if prompt_slug is not None:
+            prompt_data["slug"] = prompt_slug
+        return prompt_data
+
     def validate_environment(self, api_key: Optional[str]):
         """
         Expects
@@ -187,14 +206,9 @@ class BraintrustLogger(CustomLogger):
                     ):  # support logging dynamic metadata to braintrust
                         standard_logging_object[key] = value
 
-            prompt_id = dynamic_metadata.get("prompt_id")
-            prompt_slug = dynamic_metadata.get("prompt_slug")
-            if prompt_id is not None or prompt_slug is not None:
-                standard_logging_object["prompt"] = {
-                    "id": prompt_id,
-                    "project_id": project_id,
-                    "slug": prompt_slug,
-                }
+            prompt_metadata = self._build_prompt_metadata(dynamic_metadata, project_id)
+            if prompt_metadata is not None:
+                standard_logging_object["prompt"] = prompt_metadata
 
             cost = kwargs.get("response_cost", None)
 
@@ -330,14 +344,9 @@ class BraintrustLogger(CustomLogger):
                     ):  # support logging dynamic metadata to braintrust
                         standard_logging_object[key] = value
 
-            prompt_id = dynamic_metadata.get("prompt_id")
-            prompt_slug = dynamic_metadata.get("prompt_slug")
-            if prompt_id is not None or prompt_slug is not None:
-                standard_logging_object["prompt"] = {
-                    "id": prompt_id,
-                    "project_id": project_id,
-                    "slug": prompt_slug,
-                }
+            prompt_metadata = self._build_prompt_metadata(dynamic_metadata, project_id)
+            if prompt_metadata is not None:
+                standard_logging_object["prompt"] = prompt_metadata
 
             cost = kwargs.get("response_cost", None)