From 0f068e1e1e1f568f19b5d3aa6a4bfbdb0fa26a8f Mon Sep 17 00:00:00 2001 From: Josh Bonczkowski Date: Fri, 13 Mar 2026 14:58:43 -0400 Subject: [PATCH] Addressing feedback for potential better practice. --- litellm/integrations/newrelic/newrelic.py | 14 +++++++------- 1 file changed, 7 insertions(+), 7 deletions(-) diff --git a/litellm/integrations/newrelic/newrelic.py b/litellm/integrations/newrelic/newrelic.py index 7adf90ea8cc..73eea183acf 100644 --- a/litellm/integrations/newrelic/newrelic.py +++ b/litellm/integrations/newrelic/newrelic.py @@ -243,9 +243,9 @@ class NewRelicLogger(CustomLogger): - span_id: str or None (only present if found in headers) """ try: - litellm_params = kwargs.get("litellm_params", {}) - metadata = litellm_params.get("metadata", {}) - headers = metadata.get("headers", {}) + litellm_params = kwargs.get("litellm_params") or {} + metadata = litellm_params.get("metadata") or {} + headers = metadata.get("headers") or {} traceparent = headers.get("traceparent", None) trace_id = None @@ -326,7 +326,7 @@ class NewRelicLogger(CustomLogger): Returns "unknown" if choices are not present or finish_reason is not found. """ - choices = response_obj.get("choices", []) + choices = response_obj.get("choices") or [] if choices and len(choices) > 0: return choices[0].get("finish_reason", "unknown") return "unknown" @@ -363,7 +363,7 @@ class NewRelicLogger(CustomLogger): Returns dict with available parameters, omitting those not present. """ - optional_params = kwargs.get("optional_params", {}) + optional_params = kwargs.get("optional_params") or {} params = {} temperature = optional_params.get("temperature") @@ -431,7 +431,7 @@ class NewRelicLogger(CustomLogger): end_time = kwargs.get("end_time") # Extract request messages - request_messages = kwargs.get("messages", []) + request_messages = kwargs.get("messages") or [] for msg in request_messages: message_data = { "role": msg.get("role", "user"), @@ -452,7 +452,7 @@ class NewRelicLogger(CustomLogger): sequence += 1 # Extract response messages from choices - choices = response_obj.get("choices", []) + choices = response_obj.get("choices") or [] if choices and len(choices) > 0: for choice in choices: message = choice.get("message", None)