Revert "fix(ui): save routing groups as list (#29889)" (#29928)

This reverts commit 9b1f78ffa7.
This commit is contained in:
Sameer Kankute 2026-06-08 17:49:22 +05:30 committed by GitHub
parent 9b1f78ffa7
commit 0806a3e54f
No known key found for this signature in database
GPG key ID: B5690EEEBB952194
2 changed files with 1 additions and 30 deletions

View file

@ -34,7 +34,6 @@ const mockCallbacksResponse = {
routing_strategy: "simple-shuffle",
num_retries: 3,
timeout: 30,
routing_groups: [],
},
};
@ -135,34 +134,6 @@ describe("RouterSettings", () => {
);
});
it("should send routing_groups as a list when saving load balancing settings", async () => {
const user = userEvent.setup();
renderWithProviders(<RouterSettings {...defaultProps} />);
await waitFor(() => {
expect(screen.getByRole("textbox", { name: /routing_groups/i })).toBeInTheDocument();
});
await user.click(screen.getByRole("button", { name: /save changes/i }));
expect(setCallbacksCall).toHaveBeenCalledWith(
"test-token",
expect.objectContaining({
router_settings: expect.objectContaining({
routing_groups: [],
}),
}),
);
expect(setCallbacksCall).not.toHaveBeenCalledWith(
"test-token",
expect.objectContaining({
router_settings: expect.objectContaining({
routing_groups: "[]",
}),
}),
);
});
it("should show a success notification after saving", async () => {
const user = userEvent.setup();
renderWithProviders(<RouterSettings {...defaultProps} />);

View file

@ -91,7 +91,7 @@ const RouterSettings: React.FC<RouterSettingsProps> = ({ accessToken, userRole,
console.log("router_settings", router_settings);
const numberKeys = new Set(["allowed_fails", "cooldown_time", "num_retries", "timeout", "retry_after"]);
const jsonKeys = new Set(["model_group_alias", "retry_policy", "routing_groups"]);
const jsonKeys = new Set(["model_group_alias", "retry_policy"]);
const parseInputValue = (key: string, raw: string | undefined, fallback: unknown) => {
if (raw === undefined) return fallback;