scriptoriumadmin/litellm
1
0
Fork 0
mirror of https://github.com/BerriAI/litellm.git synced 2026-09-26 01:12:21 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions 99

fix(interactions): address Greptile P1 review on schema coalescing and legacy deltas

Browse source 
Skip response_mime_type merge when response_format is already a list, avoid
in-place list mutation on image_config append, and restore delta.type on
legacy content.delta events.

Co-authored-by: Cursor <cursoragent@cursor.com>
This commit is contained in:
Sameer Kankute 2026-05-20 19:31:26 +05:30
parent a1588e2f88
commit 07d1988319
No known key found for this signature in database
3 changed files with 31 additions and 5 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

2
litellm/interactions/litellm_responses_transformation/streaming_iterator.py
View file

@ -133,7 +133,7 @@ class LiteLLMResponsesInteractionsStreamingIterator:
event_type="content.delta",
id=item_id,
object="content",
delta={"text": delta_text},
delta={"type": "text", "text": delta_text},
)
else:
return InteractionsAPIStreamingResponse(

2
litellm/llms/gemini/interactions/transformation.py
View file

@ -186,7 +186,7 @@ class GoogleAIStudioInteractionsConfig(BaseInteractionsAPIConfig):
response_format = optional_params.get("response_format")
response_mime_type = optional_params.get("response_mime_type")
if response_mime_type and (
if response_mime_type and not isinstance(response_format, list) and (
not isinstance(response_format, dict)
or "mime_type" not in response_format
):

32
tests/test_litellm/interactions/test_gemini_interactions_transformation.py
View file

@ -269,7 +269,7 @@ class TestStreamingIterator:
assert chunk.delta == {"type": "text", "text": "Hello"}
def test_content_delta_legacy_schema(self):
"""Legacy schema emits content.delta with text-only delta payload."""
"""Legacy schema emits content.delta with type and text fields."""
it = self._make_iterator(use_legacy=True)
it.sent_interaction_start = True
it.sent_content_start = True
@ -280,7 +280,7 @@ class TestStreamingIterator:
assert chunk is not None
assert chunk.event_type == "content.delta"
assert chunk.delta == {"text": "Hello"}
assert chunk.delta == {"type": "text", "text": "Hello"}
def test_response_created_emits_interaction_created(self):
it = self._make_iterator(use_legacy=False)
@ -353,7 +353,7 @@ class TestStreamingIterator:
)
assert third is not None
assert third.event_type == "content.delta"
assert third.delta == {"text": "!"}
assert third.delta == {"type": "text", "text": "!"}
def test_first_text_delta_without_item_id_uses_fallback_id(self):
it = self._make_iterator(use_legacy=False)
@ -482,6 +482,32 @@ class TestTransformRequestSchemaCoalescing:
assert rf["type"] == "image"
assert rf["aspect_ratio"] == "1:1"
def test_response_mime_type_skipped_when_response_format_is_list(self, config):
"""Lists are already polymorphic; do not wrap them into schema."""
original = litellm.use_legacy_interactions_schema
try:
litellm.use_legacy_interactions_schema = False
rf_list = [
{"type": "text", "mime_type": "application/json"},
{"type": "image", "aspect_ratio": "1:1"},
]
body = config.transform_request(
model="gemini/gemini-2.5-flash",
agent=None,
input="multimodal",
optional_params={
"response_format": rf_list,
"response_mime_type": "application/json",
},
litellm_params=GenericLiteLLMParams(),
headers={},
)
finally:
litellm.use_legacy_interactions_schema = original
assert body["response_format"] == rf_list
assert "response_mime_type" not in body
def test_image_config_appended_to_response_format_list_without_mutating_input(
self, config
):