From 05e89d9ccbfb74e89f85f6a49a4a29310608107c Mon Sep 17 00:00:00 2001
From: Cursor Agent <cursoragent@cursor.com>
Date: Tue, 18 Aug 2026 05:27:07 +0000
Subject: [PATCH] test(ui): teach TeamInfo mock about organizationKeys and stop
 stub buttons from submitting the form

The TeamInfo settings save path invalidates organization queries via
organizationKeys.all, and the ModelAliasManager stub renders <button>
elements without type="button", so any click inside the edit form was
submitting it. Together these masked each other: the accidental submit
threw on the missing organizationKeys export, the catch swallowed the
error, teamUpdateCall had already been recorded, and the assertion was
happy. Under CI load the pass-through routes test tipped past the 30s
testTimeout while the form was stuck mid-save.

Add organizationKeys to the mock so the invalidation succeeds and stamp
type="button" on the alias-editor stubs so Set Alias / Clear Aliases
only update parent state. The model_aliases tests now exercise the real
click Set Alias -> click Save Changes flow instead of passing on the
first accidental submit.

Co-authored-by: Krrish Dholakia <krrish-berri-2@users.noreply.github.com>
---
 .../src/components/team/TeamInfo.test.tsx                | 9 +++++++--
 1 file changed, 7 insertions(+), 2 deletions(-)

diff --git a/ui/litellm-dashboard/src/components/team/TeamInfo.test.tsx b/ui/litellm-dashboard/src/components/team/TeamInfo.test.tsx
index 1d6c46dc0c9..c9e41cb5344 100644
--- a/ui/litellm-dashboard/src/components/team/TeamInfo.test.tsx
+++ b/ui/litellm-dashboard/src/components/team/TeamInfo.test.tsx
@@ -62,6 +62,7 @@ vi.mock("@/app/(dashboard)/hooks/teams/useTeams", () => ({
 vi.mock("@/app/(dashboard)/hooks/organizations/useOrganizations", () => ({
   useOrganization: vi.fn(),
   useOrganizations: vi.fn().mockReturnValue({ data: [], isLoading: false }),
+  organizationKeys: { all: ["organizations"] },
 }));
 
 vi.mock("@/app/(dashboard)/hooks/users/useCurrentUser", () => ({
@@ -121,8 +122,12 @@ vi.mock("@/components/common_components/ModelAliasManager", () => ({
   default: vi.fn(({ initialModelAliases, onAliasUpdate }) => (
     <div>
       <div data-testid="alias-editor-initial">{JSON.stringify(initialModelAliases)}</div>
-      <button onClick={() => onAliasUpdate({ "gpt-4o": "gpt-4" })}>Set Alias</button>
-      <button onClick={() => onAliasUpdate({})}>Clear Aliases</button>
+      <button type="button" onClick={() => onAliasUpdate({ "gpt-4o": "gpt-4" })}>
+        Set Alias
+      </button>
+      <button type="button" onClick={() => onAliasUpdate({})}>
+        Clear Aliases
+      </button>
     </div>
   )),
 }));