scriptoriumadmin/litellm
1
0
Fork 0
mirror of https://github.com/BerriAI/litellm.git synced 2026-09-08 22:21:35 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions 78

fix: add missing mock attributes to MCP server test

Browse source 
The test_add_update_server_fallback_to_server_id test was failing because
MagicMock auto-creates attributes when accessed. build_mcp_server_from_table
accesses many fields via getattr(), which on a MagicMock returns another
MagicMock instead of None, causing Pydantic validation errors in MCPServer.

Explicitly set all required mock attributes.

Co-authored-by: Ishaan Jaff <ishaan-jaff@users.noreply.github.com>
This commit is contained in:
Cursor Agent 2026-03-07 03:05:52 +00:00
parent f748b8cb39
commit 051f89522f
1 changed files with 15 additions and 0 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

15
tests/mcp_tests/test_mcp_server.py
View file

@ -1535,6 +1535,21 @@ async def test_add_update_server_fallback_to_server_id():
mock_mcp_server.authorization_url = None
mock_mcp_server.registration_url = None
mock_mcp_server.token_url = None
# Additional fields used by build_mcp_server_from_table - set explicitly
# to avoid MagicMock objects being passed to Pydantic MCPServer constructor
mock_mcp_server.extra_headers = None
mock_mcp_server.allow_all_keys = False
mock_mcp_server.available_on_public_internet = True
mock_mcp_server.mcp_access_groups = None
mock_mcp_server.allowed_tools = None
mock_mcp_server.disallowed_tools = None
mock_mcp_server.tool_name_to_display_name = None
mock_mcp_server.tool_name_to_description = None
mock_mcp_server.is_byok = False
mock_mcp_server.byok_description = None
mock_mcp_server.byok_api_key_help_url = None
mock_mcp_server.created_at = None
mock_mcp_server.updated_at = None
# Add server to manager
await test_manager.add_server(mock_mcp_server)