From 036c3cd2c5bfdf4e5ce66786ac656d196abb24be Mon Sep 17 00:00:00 2001 From: Aman Sachan Date: Sat, 16 May 2026 02:48:01 +0000 Subject: [PATCH] fix(tests): remove misleading env vars from langfuse None-guard tests MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit The env vars in the regression tests had no effect — the functions under test operate only on the params dict and don't read from env vars. Clean up the test setup to avoid misleading future maintainers. Greptile feedback: P2 --- .../test_langfuse_dynamic_credentials.py | 18 +++++------------- 1 file changed, 5 insertions(+), 13 deletions(-) diff --git a/tests/logging_callback_tests/test_langfuse_dynamic_credentials.py b/tests/logging_callback_tests/test_langfuse_dynamic_credentials.py index 9f504b9bc5b..d2721be4396 100644 --- a/tests/logging_callback_tests/test_langfuse_dynamic_credentials.py +++ b/tests/logging_callback_tests/test_langfuse_dynamic_credentials.py @@ -129,34 +129,26 @@ def test_langfuse_handler_accepts_secret_key_alias(monkeypatch): assert captured["cached_logging_obj"] is logger -def test_dynamic_langfuse_credentials_are_passed_handles_none(monkeypatch): +def test_dynamic_langfuse_credentials_are_passed_handles_none(): """Regression test: _dynamic_langfuse_credentials_are_passed must not crash when standard_callback_dynamic_params is None. When Langfuse is configured via environment variables (no per-request dynamic params), standard_callback_dynamic_params is None, not {}. The function must not raise AttributeError: 'NoneType' object has no attribute 'get'. """ - monkeypatch.setenv("LANGFUSE_PUBLIC_KEY", "pk-test") - monkeypatch.setenv("LANGFUSE_SECRET_KEY", "sk-test") - monkeypatch.setenv("LANGFUSE_HOST", "https://langfuse.example") - # Should return False (no dynamic params passed), not raise AttributeError result = LangFuseHandler._dynamic_langfuse_credentials_are_passed(None) assert result is False -def test_get_dynamic_langfuse_logging_config_handles_none(monkeypatch): +def test_get_dynamic_langfuse_logging_config_handles_none(): """Regression test: get_dynamic_langfuse_logging_config must not crash when standard_callback_dynamic_params is None. When Langfuse is configured via environment variables, standard_callback_dynamic_params is None. The function should return a config with None values (relying on env var fallback downstream). """ - monkeypatch.setenv("LANGFUSE_PUBLIC_KEY", "pk-test") - monkeypatch.setenv("LANGFUSE_SECRET_KEY", "sk-test") - monkeypatch.setenv("LANGFUSE_HOST", "https://langfuse.example") - # Should not raise AttributeError config = LangFuseHandler.get_dynamic_langfuse_logging_config(None) - assert config["langfuse_public_key"] is None - assert config["langfuse_secret"] is None - assert config["langfuse_host"] is None + assert config.langfuse_public_key is None + assert config.langfuse_secret is None + assert config.langfuse_host is None