(sap) fix after bot review

This commit is contained in:
Vasilisa Parshikova 2026-03-05 20:09:44 +04:00 committed by Sameer Kankute
parent 2723c69bfe
commit 033a6ebcd0
No known key found for this signature in database
2 changed files with 7 additions and 5 deletions

View file

@ -70,18 +70,18 @@ pip install litellm
<Tabs>
<TabItem value="service-key" label="Service Key JSON (Recommended)">
The simplest approach - paste your entire service key as a single environment variable. The service key must be wrapped in a `credentials` object:
The simplest approach - paste your entire service key as a single environment variable.
> **Note:** the service key no more needs to be wrapped in a "credentials" key.
```bash
export AICORE_SERVICE_KEY='{
"credentials": {
"clientid": "your-client-id",
"clientsecret": "your-client-secret",
"url": "https://<your-instance>.authentication.sap.hana.ondemand.com",
"serviceurls": {
"AI_API_URL": "https://api.ai.<your-region>.aws.ml.hana.ondemand.com"
}
}
}'
export AICORE_RESOURCE_GROUP="default"
```

View file

@ -280,6 +280,7 @@ def get_token_creator(
service_key: Optional[Union[str, dict]] = None,
profile: Optional[str] = None,
*,
timeout: float = 30.0,
expiry_buffer_minutes: int = 60,
**overrides,
) -> Tuple[Callable[[], str], str, str]:
@ -294,6 +295,7 @@ def get_token_creator(
Args:
profile: Optional AICore profile name
timeout: Timeout for HTTP requests
expiry_buffer_minutes: Refresh the token this many minutes before expiry
overrides: Any explicit credential overrides (client_id, client_secret, etc.)
@ -330,10 +332,10 @@ def get_token_creator(
if cert_pair:
with httpx.Client(cert=cert_pair) as raw_client:
handler = HTTPHandler(client=raw_client)
resp = handler.post(auth_url, data=data) # type: ignore[arg-type]
resp = handler.post(auth_url, data=data, timeout=timeout) # type: ignore[arg-type]
else:
handler = _get_httpx_client()
resp = handler.post(auth_url, data=data) # type: ignore[arg-type]
resp = handler.post(auth_url, data=data, timeout=timeout) # type: ignore[arg-type]
payload = resp.json()
access_token = payload["access_token"]
expires_in = int(payload.get("expires_in", 3600))