From 02f9f188538338739dae033302f93723fb28e29b Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Marcel=20Wien=C3=B6bst?= Date: Mon, 7 Sep 2026 09:02:05 +0200 Subject: [PATCH] fix linter warnings in test_models --- .../llms/sap/chat/test_sap_models.py | 128 +++++++++--------- 1 file changed, 64 insertions(+), 64 deletions(-) diff --git a/tests/test_litellm/llms/sap/chat/test_sap_models.py b/tests/test_litellm/llms/sap/chat/test_sap_models.py index 9582258f753..bb38ee35253 100644 --- a/tests/test_litellm/llms/sap/chat/test_sap_models.py +++ b/tests/test_litellm/llms/sap/chat/test_sap_models.py @@ -12,52 +12,52 @@ from litellm.llms.sap.chat.models import ( class TestSAPMessage: def test_role_system(self): - msg = SAPMessage(role="system", content="Hi") + msg = SAPMessage.model_validate({"role": "system", "content": "Hi"}) assert msg.role == "system" def test_role_developer(self): - msg = SAPMessage(role="developer", content="Hi") + msg = SAPMessage.model_validate({"role": "developer", "content": "Hi"}) assert msg.role == "developer" def test_role_defaults_to_system(self): - msg = SAPMessage(content="Hi") + msg = SAPMessage.model_validate({"content": "Hi"}) assert msg.role == "system" def test_invalid_role_rejected(self): with pytest.raises(ValidationError): - SAPMessage(role="user", content="Hi") + SAPMessage.model_validate({"role": "user", "content": "Hi"}) def test_missing_content_rejected(self): with pytest.raises(ValidationError): - SAPMessage(role="system") + SAPMessage.model_validate({"role": "system"}) def test_string_content_accepted(self): - msg = SAPMessage(role="system", content="Hello") + msg = SAPMessage.model_validate({"role": "system", "content": "Hello"}) assert msg.content == "Hello" def test_text_content_block_accepted(self): - msg = SAPMessage(role="system", content={"type": "text", "text": "Hello"}) + msg = SAPMessage.model_validate({"role": "system", "content": {"type": "text", "text": "Hello"}}) assert isinstance(msg.content, TextContent) assert msg.content.text == "Hello" def test_list_of_text_content_blocks_accepted(self): - msg = SAPMessage( - role="system", - content=[{"type": "text", "text": "A"}, {"type": "text", "text": "B"}], - ) + msg = SAPMessage.model_validate({ + "role": "system", + "content": [{"type": "text", "text": "A"}, {"type": "text", "text": "B"}], + }) assert isinstance(msg.content, list) assert len(msg.content) == 2 assert isinstance(msg.content[0], TextContent) def test_invalid_content_type_rejected(self): with pytest.raises(ValidationError): - SAPMessage(role="system", content=123) + SAPMessage.model_validate({"role": "system", "content": 123}) def test_cache_control_on_content_block(self): - msg = SAPMessage( - role="system", - content={"type": "text", "text": "Hi", "cache_control": {"type": "ephemeral"}}, - ) + msg = SAPMessage.model_validate({ + "role": "system", + "content": {"type": "text", "text": "Hi", "cache_control": {"type": "ephemeral"}}, + }) assert isinstance(msg.content, TextContent) assert msg.content.cache_control is not None assert msg.content.cache_control.type == "ephemeral" @@ -65,51 +65,51 @@ class TestSAPMessage: class TestSAPUserMessage: def test_role_is_always_user(self): - msg = SAPUserMessage(content="Hi") + msg = SAPUserMessage.model_validate({"content": "Hi"}) assert msg.role == "user" def test_invalid_role_rejected(self): with pytest.raises(ValidationError): - SAPUserMessage(role="system", content="Hi") + SAPUserMessage.model_validate({"role": "system", "content": "Hi"}) def test_missing_content_rejected(self): with pytest.raises(ValidationError): - SAPUserMessage() + SAPUserMessage.model_validate({}) def test_string_content_accepted(self): - msg = SAPUserMessage(content="Hello") + msg = SAPUserMessage.model_validate({"content": "Hello"}) assert msg.content == "Hello" def test_text_content_block_accepted(self): - msg = SAPUserMessage(content={"type": "text", "text": "Hello"}) + msg = SAPUserMessage.model_validate({"content": {"type": "text", "text": "Hello"}}) assert isinstance(msg.content, TextContent) def test_image_content_accepted(self): from litellm.llms.sap.chat.models import ImageContent - msg = SAPUserMessage( - content={"type": "image_url", "image_url": {"url": "https://example.com/img.png"}} - ) + msg = SAPUserMessage.model_validate({ + "content": {"type": "image_url", "image_url": {"url": "https://example.com/img.png"}} + }) assert isinstance(msg.content, ImageContent) def test_mixed_list_of_text_and_image_accepted(self): - msg = SAPUserMessage( - content=[ + msg = SAPUserMessage.model_validate({ + "content": [ {"type": "text", "text": "Look at this:"}, {"type": "image_url", "image_url": {"url": "https://example.com/img.png"}}, ] - ) + }) assert isinstance(msg.content, list) assert len(msg.content) == 2 def test_invalid_content_type_rejected(self): with pytest.raises(ValidationError): - SAPUserMessage(content=123) + SAPUserMessage.model_validate({"content": 123}) def test_cache_control_on_content_block(self): - msg = SAPUserMessage( - content={"type": "text", "text": "Hi", "cache_control": {"type": "ephemeral"}}, - ) + msg = SAPUserMessage.model_validate({ + "content": {"type": "text", "text": "Hi", "cache_control": {"type": "ephemeral"}}, + }) assert isinstance(msg.content, TextContent) assert msg.content.cache_control is not None assert msg.content.cache_control.type == "ephemeral" @@ -117,52 +117,52 @@ class TestSAPUserMessage: class TestSAPAssistantMessage: def test_role_is_always_assistant(self): - msg = SAPAssistantMessage(content="Hi") + msg = SAPAssistantMessage.model_validate({"content": "Hi"}) assert msg.role == "assistant" def test_invalid_role_rejected(self): with pytest.raises(ValidationError): - SAPAssistantMessage(role="user", content="Hi") + SAPAssistantMessage.model_validate({"role": "user", "content": "Hi"}) def test_refusal_defaults_to_empty_string(self): - msg = SAPAssistantMessage() + msg = SAPAssistantMessage.model_validate({}) assert msg.refusal == "" def test_refusal_accepted(self): - msg = SAPAssistantMessage(refusal="I cannot help with that.") + msg = SAPAssistantMessage.model_validate({"refusal": "I cannot help with that."}) assert msg.refusal == "I cannot help with that." def test_tool_calls_default_to_empty_list(self): - msg = SAPAssistantMessage() + msg = SAPAssistantMessage.model_validate({}) assert msg.tool_calls == [] def test_string_content_accepted(self): - msg = SAPAssistantMessage(content="Hello") + msg = SAPAssistantMessage.model_validate({"content": "Hello"}) assert msg.content == "Hello" def test_default_empty_string(self): - msg = SAPAssistantMessage() + msg = SAPAssistantMessage.model_validate({}) assert msg.content == "" def test_text_content_block_accepted(self): - msg = SAPAssistantMessage(content={"type": "text", "text": "Hello"}) + msg = SAPAssistantMessage.model_validate({"content": {"type": "text", "text": "Hello"}}) assert isinstance(msg.content, TextContent) def test_list_of_text_blocks_accepted(self): - msg = SAPAssistantMessage( - content=[{"type": "text", "text": "A"}, {"type": "text", "text": "B"}] - ) + msg = SAPAssistantMessage.model_validate({ + "content": [{"type": "text", "text": "A"}, {"type": "text", "text": "B"}] + }) assert isinstance(msg.content, list) assert len(msg.content) == 2 def test_invalid_content_type_rejected(self): with pytest.raises(ValidationError): - SAPAssistantMessage(content={"type": "image_url", "image_url": {"url": "x"}}) + SAPAssistantMessage.model_validate({"content": {"type": "image_url", "image_url": {"url": "x"}}}) def test_cache_control_on_content_block(self): - msg = SAPAssistantMessage( - content={"type": "text", "text": "Hi", "cache_control": {"type": "ephemeral"}}, - ) + msg = SAPAssistantMessage.model_validate({ + "content": {"type": "text", "text": "Hi", "cache_control": {"type": "ephemeral"}}, + }) assert isinstance(msg.content, TextContent) assert msg.content.cache_control is not None assert msg.content.cache_control.type == "ephemeral" @@ -170,52 +170,52 @@ class TestSAPAssistantMessage: class TestSAPToolChatMessage: def test_role_is_always_tool(self): - msg = SAPToolChatMessage(tool_call_id="call_1", content="ok") + msg = SAPToolChatMessage.model_validate({"tool_call_id": "call_1", "content": "ok"}) assert msg.role == "tool" def test_invalid_role_rejected(self): with pytest.raises(ValidationError): - SAPToolChatMessage(role="user", tool_call_id="call_1", content="ok") + SAPToolChatMessage.model_validate({"role": "user", "tool_call_id": "call_1", "content": "ok"}) def test_tool_call_id_accepted(self): - msg = SAPToolChatMessage(tool_call_id="call_abc123", content="result") + msg = SAPToolChatMessage.model_validate({"tool_call_id": "call_abc123", "content": "result"}) assert msg.tool_call_id == "call_abc123" def test_missing_tool_call_id_rejected(self): with pytest.raises(ValidationError): - SAPToolChatMessage(content="result") + SAPToolChatMessage.model_validate({"content": "result"}) def test_string_content_accepted(self): - msg = SAPToolChatMessage(tool_call_id="call_1", content="result") + msg = SAPToolChatMessage.model_validate({"tool_call_id": "call_1", "content": "result"}) assert msg.content == "result" def test_text_content_block_accepted(self): - msg = SAPToolChatMessage( - tool_call_id="call_1", content={"type": "text", "text": "result"} - ) + msg = SAPToolChatMessage.model_validate({ + "tool_call_id": "call_1", "content": {"type": "text", "text": "result"} + }) assert isinstance(msg.content, TextContent) def test_list_of_text_blocks_accepted(self): - msg = SAPToolChatMessage( - tool_call_id="call_1", - content=[{"type": "text", "text": "A"}, {"type": "text", "text": "B"}], - ) + msg = SAPToolChatMessage.model_validate({ + "tool_call_id": "call_1", + "content": [{"type": "text", "text": "A"}, {"type": "text", "text": "B"}], + }) assert isinstance(msg.content, list) assert len(msg.content) == 2 def test_missing_content_rejected(self): with pytest.raises(ValidationError): - SAPToolChatMessage(tool_call_id="call_1") + SAPToolChatMessage.model_validate({"tool_call_id": "call_1"}) def test_invalid_content_type_rejected(self): with pytest.raises(ValidationError): - SAPToolChatMessage(tool_call_id="call_1", content=99) + SAPToolChatMessage.model_validate({"tool_call_id": "call_1", "content": 99}) def test_cache_control_on_content_block(self): - msg = SAPToolChatMessage( - tool_call_id="call_1", - content={"type": "text", "text": "result", "cache_control": {"type": "ephemeral"}}, - ) + msg = SAPToolChatMessage.model_validate({ + "tool_call_id": "call_1", + "content": {"type": "text", "text": "result", "cache_control": {"type": "ephemeral"}}, + }) assert isinstance(msg.content, TextContent) assert msg.content.cache_control is not None assert msg.content.cache_control.type == "ephemeral"