scriptoriumadmin/litellm
1
0
Fork 0
mirror of https://github.com/BerriAI/litellm.git synced 2026-11-15 09:12:18 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions 311

fix(ui): label users without an email by user id in key owner picker

Browse source 
Co-Authored-By: Devin AI <158243242+devin-ai-integration[bot]@users.noreply.github.com>
This commit is contained in:
jesus 2026-09-08 22:42:11 +00:00
parent d5f1822711
commit 01dfbb29ca
2 changed files with 30 additions and 6 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

32
ui/litellm-dashboard/src/components/organisms/create_key_button.integration.test.tsx
View file

@ -852,7 +852,7 @@ describe("CreateKey", () => {
});
it("keeps the current search's users when an abandoned search answers last", async () => {
const answers = new Map<string, (users: { user_id: string; user_email: string }[]) => void>();
const answers = new Map<string, (users: { user_id: string; user_email: string | null }[]) => void>();
vi.mocked(userFilterUICall).mockImplementation(
(_accessToken, params) =>
new Promise((resolve) => {
@ -883,8 +883,32 @@ describe("CreateKey", () => {
expect(screen.getByRole("option", { name: "alice.smith@example.com (u-smith)" })).toBeInTheDocument();
});
it("labels a user with no email by their user id", async () => {
const answers = new Map<string, (users: { user_id: string; user_email: string | null }[]) => void>();
vi.mocked(userFilterUICall).mockImplementation(
(_accessToken, params) =>
new Promise((resolve) => {
answers.set(params.get("search") ?? "", resolve);
}) as never,
);
const user = userEvent.setup();
renderCreateKey({ autoOpenCreate: true, prefillData: { owned_by: "another_user" } });
const search = await userSearchInput();
await user.type(search, "svc");
await waitFor(() => expect(answers.has("svc")).toBe(true), { timeout: 3000 });
await act(async () => {
answers.get("svc")?.([{ user_id: "svc-bot", user_email: null }]);
});
expect(await screen.findByRole("option", { name: "svc-bot" })).toBeInTheDocument();
expect(screen.queryByRole("option", { name: /null/ })).not.toBeInTheDocument();
});
it("stops searching once the box is cleared and the abandoned search answers", async () => {
const answers = new Map<string, (users: { user_id: string; user_email: string }[]) => void>();
const answers = new Map<string, (users: { user_id: string; user_email: string | null }[]) => void>();
vi.mocked(userFilterUICall).mockImplementation(
(_accessToken, params) =>
new Promise((resolve) => {
@ -912,7 +936,7 @@ describe("CreateKey", () => {
});
it("keeps searching while a newer search is still in flight", async () => {
const answers = new Map<string, (users: { user_id: string; user_email: string }[]) => void>();
const answers = new Map<string, (users: { user_id: string; user_email: string | null }[]) => void>();
vi.mocked(userFilterUICall).mockImplementation(
(_accessToken, params) =>
new Promise((resolve) => {
@ -946,7 +970,7 @@ describe("CreateKey", () => {
it("only warns about a failed search when it is the one the box is waiting on", async () => {
const answers = new Map<
string,
{ resolve: (users: { user_id: string; user_email: string }[]) => void; reject: (error: Error) => void }
{ resolve: (users: { user_id: string; user_email: string | null }[]) => void; reject: (error: Error) => void }
>();
vi.mocked(userFilterUICall).mockImplementation(
(_accessToken, params) =>

4
ui/litellm-dashboard/src/components/organisms/create_key_button.tsx
View file

@ -159,7 +159,7 @@ interface CreateKeyProps {
interface User {
user_id: string;
user_email: string;
user_email: string | null;
role?: string;
}
@ -577,7 +577,7 @@ const CreateKey: React.FC<CreateKeyProps> = ({ team, teams, data, addKey, autoOp
const data: User[] = response;
const options: SearchSelectOption[] = data.map((user) => ({
label: `${user.user_email} (${user.user_id})`,
label: user.user_email ? `${user.user_email} (${user.user_id})` : user.user_id,
value: user.user_id,
}));