fix(vector_stores): keep param name for backward compat, correct index deletion

This commit is contained in:
Sarveswaran MG 2026-07-22 20:51:30 +05:30
parent 22417073de
commit 00a478fb4d
2 changed files with 5 additions and 5 deletions

View file

@ -55,11 +55,13 @@ class VectorStoreIndexRegistry:
return
self.vector_store_indexes.append(vector_store_index)
def delete_vector_store_index(self, index_name: str):
def delete_vector_store_index(self, vector_store_index: str):
"""
Deletes a vector store index from the registry
"""
self.vector_store_indexes = [index for index in self.vector_store_indexes if index.index_name != index_name]
self.vector_store_indexes = [
index for index in self.vector_store_indexes if index.index_name != vector_store_index
]
def is_vector_store_index(self, vector_store_index_name: str) -> bool:
"""

View file

@ -267,9 +267,7 @@ def test_delete_vector_store_index_removes_by_name():
Regression test: delete_vector_store_index compared each stored index object against the
index-name string, which is never equal, so the delete was an unconditional no-op.
"""
registry = VectorStoreIndexRegistry(
[_managed_vector_store_index("idx_a"), _managed_vector_store_index("idx_b")]
)
registry = VectorStoreIndexRegistry([_managed_vector_store_index("idx_a"), _managed_vector_store_index("idx_b")])
registry.delete_vector_store_index("idx_a")