scriptoriumadmin/litellm
1
0
Fork 0
mirror of https://github.com/BerriAI/litellm.git synced 2026-09-06 08:16:43 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions 78

fix(vertex_ai): support model names with slashes in passthrough URLs (#19944)

Browse source 
The regex in get_vertex_model_id_from_url() was using [^/:]+
which stopped at the first slash, truncating model names like
'gcp/google/gemini-2.5-flash' to just 'gcp'. This caused
access_groups checks to fail for custom model names.

Changed the pattern to [^:]+ to allow slashes in model names,
only stopping at the colon before the action (e.g., :generateContent).
This commit is contained in:
michelligabriele 2026-01-28 18:33:53 +01:00 • committed by Ishaan Jaffer
parent 43642391c5
commit 0003e647ea
2 changed files with 31 additions and 1 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

2
litellm/llms/vertex_ai/common_utils.py
View file

@ -849,7 +849,7 @@ def get_vertex_model_id_from_url(url: str) -> Optional[str]:
`https://${LOCATION}-aiplatform.googleapis.com/v1/projects/${PROJECT_ID}/locations/${LOCATION}/publishers/google/models/${MODEL_ID}:streamGenerateContent`
"""
match = re.search(r"/models/([^/:]+)", url)
match = re.search(r"/models/([^:]+)", url)
return match.group(1) if match else None

30
tests/test_litellm/llms/vertex_ai/test_vertex_ai_common_utils.py
View file

@ -812,6 +812,36 @@ def test_get_vertex_model_id_from_url():
assert model_id is None
def test_get_vertex_model_id_from_url_with_slashes():
"""Test get_vertex_model_id_from_url with model names containing slashes (e.g., gcp/google/gemini-2.5-flash)
Regression test for NVIDIA issue: custom model names with slashes in passthrough URLs
were being truncated (e.g., 'gcp/google/gemini-2.5-flash' -> 'gcp'), causing access_groups
checks to fail.
"""
from litellm.llms.vertex_ai.common_utils import get_vertex_model_id_from_url
# Test with model name containing slashes: gcp/google/gemini-2.5-flash
url = "https://us-central1-aiplatform.googleapis.com/v1/projects/test-project/locations/us-central1/publishers/google/models/gcp/google/gemini-2.5-flash:generateContent"
model_id = get_vertex_model_id_from_url(url)
assert model_id == "gcp/google/gemini-2.5-flash"
# Test with model name containing slashes: gcp/google/gemini-3-flash-preview
url = "https://us-central1-aiplatform.googleapis.com/v1/projects/test-project/locations/global/publishers/google/models/gcp/google/gemini-3-flash-preview:streamGenerateContent"
model_id = get_vertex_model_id_from_url(url)
assert model_id == "gcp/google/gemini-3-flash-preview"
# Test with custom model path: custom/model
url = "https://us-central1-aiplatform.googleapis.com/v1/projects/test-project/locations/us-central1/publishers/google/models/custom/model:generateContent"
model_id = get_vertex_model_id_from_url(url)
assert model_id == "custom/model"
# Test passthrough URL format (without host)
url = "v1/projects/my-project/locations/us-central1/publishers/google/models/gcp/google/gemini-2.5-flash:generateContent"
model_id = get_vertex_model_id_from_url(url)
assert model_id == "gcp/google/gemini-2.5-flash"
def test_construct_target_url_with_version_prefix():
"""Test construct_target_url with version prefixes"""
from litellm.llms.vertex_ai.common_utils import construct_target_url