mirror of
https://github.com/featurebasedb/featurebase.git
synced 2026-09-06 16:45:55 +00:00
In this commit, the Directive is mocked; it doesn't actually reach out
to a controller.
Limits key translation to only those partitions (per index) specified in
the Directive. Attempting to create or find a key (or ID) for a
partition which is not handled by this node will result in an error;
translation requests are no longer forwarded to other nodes.
Limits import into only those shards specified, per index, by the
Directive. Attempting to import into a shard which is not handled by
this node will result in an error.
Stub out /directive endpoint
The `applyDirective()` method still needs to be implemented.
Update mds references to use the new /mds/types structure
In mds, we moved the shared types to mds/types. FeatureBase needs to
reference those instead.
This also bumps the mds version in go.mod.
Implement the Add/Remove Index part of Holder.ApplyDirective()
This adds functionality to `Holder.ApplyDirective()` which adds or
removes indexes (tables) based on those provided in the Directive. Still
to be implemented here: shards and partitions.
WIP: remove client from Batch
Move Batch into its own package: batch
Also, in order to avoid import loops, this introduces packages:
/batch/types
/client/types
Reorganize the Importer-related code
Moved the Importer interface to package: batch
Move the "pilosa client" implementation of the Importer interface to
package: client
Modify batch.NewBatch to take an Importer (not client)
This commit modifies the batch.NewBatch() function to use a functinal
option on Batch to inject an Importer into the Batch. Prior to this,
NewBatch() took a pointer to a client, which was a little too
restrictive. Now, MDS can implement an Importer which uses information
from MDS to determine to which node(s) the import calls should be directed.
Add client.SetAuthToken() method to satisfy SchemaManager interface
Update ApplyDirective logic to include fields.
This needs more work, but it was enough to get a basic test passing.
Move Transaction type into /types package.
Add interface check on batch.Importer no-op implementation
Updated ApplyDirective to create all currently support Field types
There are still the following TODOs:
- [ ] impolement field options (ex: decimal scale, int min/max, etc).
- [ ] `time` fields
Added support for Decimal.Scale in ApplyDirective
Update mds dependency
Add /health endpoint
Update to use dax (dax/mds) instead of mds.
After moving the mds repository into the dax repository as a
sub-package, this commit changes everything in FeatureBase to use the
dax repo instead of the now abandoned mds repo.
Introduce and implment the WriteLogger interfaces.
This adds both a `WriteLogReader` and `WriteLogWriter` interface. They
are both implemented by the implementation: `fileWriteLogger`. The
`fileWriteLogger` uses the dax/writelogger API to append log messages to
files on disk.
Add WriteLogWriter.ImportRoaring method to interface
This commit adds the `ImportRoaring` method to the `WriteLogWriter`
interface. Still to implement are the `Import` and `ImportValue`
methods.
Reorganize the ApplyDirective code
The primary goal was to cache the incoming Directive on the Holder prior
to applying all of the changes in the directive (i.e. loading data from
the WriteLogger) because applying those changes often validated against
the accepted state of the node.
Implement all of the WriteLogger read/write methods
Implement the HTTP WriteLogger implementation
WIP: Introduce shard.Version. Implement snapshotter.
Add HTTP Snapshotter implementation
This also recofigures server to use the HTTPSnapshotter instead of the
FileSnapshotter.
Implement snapshotter: TableKeys
Implement snapshotter: FieldKeys
Dependency dance
last of the dependency dance
Add support for prototype
This adds the Makefile targets to build the docker container and push it
to ECR.
SQL3 changes which break with dax changes
Missed TODO: implement FieldVersion version to WriteLogger
Address bug causing missing TranslateStores to error
Originally, we tried to limit the TranslateStores which get allocated to
only those for which the node is responsible. This works when adding a
new table. But if a table already exists, there's no logic to start
missing TranslateStores.
This reverts back to the old FeatureBase logic which brutishly allocates
a TranslateStore for every partition, even if one is not needed.
We need to address this by allowing the ApplyDirective logic to
initialize TranslateStores when they don't yet exist.
Move the ImportRoaringShardRequest type to the types package
Since the ImportRoaringShardRequest object is part of the Importer
interface, we need to move it to a non-root (i.e. pilosa) package. All
the other interface types are either concrete types or part of a
sub-package (such as roaring). We do this to prevent an implementer of
the interface from having to import the entire pilosa package and risk
circular imports.
buncha changes to support latest dax stuff
Move dax related types to /dax sub-package
This commit moves all the common "dax" types into the /dax sub-package.
The idea is to ensure that featurebase does not import dax at all.
It's ok if dax imports featurebase.
In the future, we might need to split the dax sub-package (common data
types used by muliple molecula data-plan services) into it's own repo.
Add type: dax.Schema
This isn't currently being used; I started to use is as a replacement
for pilosa_client.Schema, but then deferred that. But we'll need to do
it eventually, so it doesn't hurt to have this type in place.
Export RowIDs.Merge() method for use in orchestrator.
Add CreateSQL method to dax.Table type
The CreateSQL() method will return the "CREATE TABLE" statement required
to create the dax.Table.
Comment out confusing writelogger log message.
We need to revisit this, but for now, this log message is confusing.
Also, rename daxSharder to versionStore.
Remove hard-coded AWS account
Implement more FieldOptions such as Epoch
Some of the FieldOption logic was stubbed out in the dax package. This
commit fills that out more; specifically, it adds the
dax.Field.Options.Epoch parameter.
export stuff needed for TopK in orchestrator
export ValCount stuff to implement Percentile in orchestrator
export more stuff to support less code in orchestrator, shared objs
Port dax repo over to featurebase/dax (run all as sub-services)
This commit does ALOT. Sorry.
It introduces a `featurebase dax` sub-command which can be configured to
run the various dax services as sub-services within the same process, or
individually as the lone service in process.
It also changes all the URL paths to be prefixed with the service name.
So for example, instead of calling localhost:8080/status, you would now
call localhost:8080/featurebase/status.
Also, note that all services provide a /health endpoint to confirm they
are running in process.
Clean up integration tests. Remove PILOSA_ config prefix.
Remove duplicate clients (mistake from porting dax to featurebase)
Rename sub-service "featurebase" to "computer"
In the places where we have hard-coded the sub-service name into a URI
path, I've tried to tag the line with a comment containing:
`// #SERVICEPATHPREFIX`
Update copilot manifest files to reference "computer"
Port dax/README.md from dax repository
Separate (toml) Queryer Config from Injections
We needed to separate the toml config from the configuration required to
inject sub-services into the Queryer. I'm not sure this is the best
solution, but it's *a* solution. So here we are.
Clean up (i.e. remove) the queryer "implementations" package
Remove old test file
Run WriteLogger and Snapshotter as local sub-services.
Prior to this commit, the writelogger and snapshotter services only
worked when run as separate services. This allows them to be run in the
same process as all the other dax services.
There is still some naming issues that we should address, but it's
functional for now.
Clean up (i.e. organize) the intra-service interfaces.
Implement alpha Director for local messages from MDS to Computer
Prior to this commit, messages from MDS to the computer service were
still going over http. This commit introduces an interface
implementation which registers the local computer command, and use that
command's API to directly reference methods used by the Director.
Clean up a few more interface names
Add Queryer OpenAPI document.
Update copilot manifests to reflect latest changes
Add OpenAPI documents for WriteLogger and Snapshotter
Add OpenAPI document for MDS service
Add OpenAPI document for Computer service
Consolidate errors to use fb/errors package.
This commit is a first pass at trying to ensure that all of the DAX code
uses:
"github.com/molecula/featurebase/v3/errors"
This package is a wrapper for "github.com/pkg/errors", so going forward
we want to avoid importing that package.
The only method which isn't backward-compatible is `New()`; the
New() method in the featurebase/errors package takes an errors.Code. If
this becomes a problem, we could change this by reverting New() and then
introducing something like NewCoded(). But for now I think it might
actually discourage someone from just creating a New() error without
thinking about how it should be coded.
Introduce VersionStore interface
Move the existing VersionStore code to the `inmem` package as the
in-memory implementation of the new dax.VersionStore interface.
Introduce NodeService interface
With this, the Controller can maintain a registry of nodes by using this
NodeService interface as opposed to an in-memory map of nodes on the
Controller struct.
This also adds an inmem implementation of the NodeService interface.
Introduce controller.Balancer interface
This moves the existing balancer package to controller/naive package.
The idea is to allow us to add a different Balancer implementation in
the future.
Introduce DirectiveVersion interface
This commit also includes *A LOT* of refactoring to use dax.Worker and
dax.Job types everywhere instead of strings.
Introduce Schemar interface
The previous `Schemar` struct was moved to the `schemar/inmem` package,
and `Schemar` is now an interface implemented by that inmem package.
Remove unused type `nUnit`
Add boltdb implementation of VersionStore interface.
This removed the previous sqlite implementation; we decided not to use
sqlite for now (as a basic, local disk implementation) because it
requires CGO.
--------------------------------------------
No longer applicable:
Add sqlite implementation of VersionStore interface.
This commit implements the VersionStore interface using sqlite. Sqlite
requires CGO, so this may not be something we want to include, but it's
implemented here to get a feel for how an external implementation might
be used; the next step will be to determine how the user configured
FeatureBase to run using sqlite as a backing store for services like
MDS.
Add boltdb implementation of NodeService and DirectiveVersion interfaces.
Add boltdb implementation of naive Balancer interfaces.
This includes the two interfaces defined in `naive/balancer.go`:
- WorkerJobService
- FreeJobService
Add boltdb implementation of Schemar interface.
clean up a linter issue
Thread context.Context through all the interfaces.
Some of the interface implementations are going to use context, so we
need to make that part of the interface. The boltdb implementations, for
example, take a context. This is probably so we can do things like
cancel or timeout operations.
Update interfaces to return error; remove `panic(err)` everywhere.
Down-rev grpc version to 1.38.0
Later versions (after 1.42.0?) cause MustRunCluster.Close() in tests to
deadlock.
This commit also adds an `isComputeNode` feature flag around some of the
write log and shard/partition check functionality so that it doesn't run
under normal conditions (this is excercised by running the sql3 tests
for example).
Add MDS_Persistence test to cover meta data persistence
This adds a basic test which configures the MDS container to use boltdb
as its persistence storage, saved on a docker volume. Then, the mds
container is stopped/replaced, and we confirm that the data stored on
the volume is availble to the new MDS container.
Fix a few things after rebase with sql-experiment branch
The lastest version of sql-experiment contains a fairly significan
refactor of the way query iteration works. This commit adjusts for those
changes.
pull dax IDK changes in to FB IDK (#2177)
* pull dax IDK changes in to FB IDK
* Move docker-related IDK build stuff to featurebase root
Building the docker image required the root level go.mod and vendor
directory. This change moves the make targets to the root level
Makefile, and the Dockerfiles now copy the root level vendor directory
(and everything else in the root for that matter).
* Fix batch- and client-related tests
* InitializePoller on MDS restart/replacement
Prior to this change, if MDS was restarted, its internal poller (which
maintains an in-memory list of nodes to poll) is empty. This is bad,
because it doesn't know about nodes that it should be polling.
This change fixes that. Upon MDS startup, it intializes the poller with
the list of nodes that MDS keeps in persistent storage (currently:
boltdb).
* Add EFS volume to MDS Copilot manifest
This allows us to use MDS's persistent storage (via boltdb) in the
Copilot demo by saving metadata in a boltdb file on EFS.
* Thread logger.Logger through all dax components
* Revert some of the breaking changes from DAX development.
When we first started prototyping DAX, we made changes to the
featurebase core code which would have broken the existing featurebase
functionality. This commit reverts some of those changes. Anywhere that
we need to modify core featurebase functionilty, we put it behind some
kind of feature flag. This flag is typically determined by whether the
running node is a "compute" node (i.e. DAX.COMPUTER.RUN = true).
Co-authored-by: Travis Turner <travis@molecula.com>
add packaging for DAX
need cgo for datagen build
bind to 0.0.0.0, pass GOOS and GOARCH explicitly
not sure if the explicit GOOS/GOARCH is actually necessary...
Get INSERT INTO (aka ingest) working through SQL3
This commit does a few things which I'll try do describe here.
- Introduces a Qctx interface. The existing Qcx is an implementation of
this interface, and can be used exactly how it has been. But this
allows us to abstract away the notion of Qcx in the Queryer (which is
handling SQL3) until we're ready to address that. As an example, the
Qcx has a notion of a featurebase Holder, but that doesn't make sense
when we're at the Queryer layer. For now, the Qctx used in the Queryer
is a no-op.
- Adds a ComputeAPI interface implementation for the Queryer. This is
effectively the Import() and ImportValues() methods used for ingest.
The logic here handles the incoming ImportRequest by first doing any
necessary column and row translation for the entire request, then it
splits the records by shard, and generates a new ImportRequest per
shard with only the shard-appropriate records.
- Changes the mds.Importer to take an MDS interface implementation
(which can be an mds client) instead of an mdsAddress. This allows us
to use a localy MDS implementation rather than assuming we need a
client to make calls over a network.
Add queryer.Importer interface to handle ingest via SQL (#2203)
* Add queryer.Importer interface to handle ingest via SQL
This is meant to support ingest through SQL when the queryer and the
compute services are running in the same process, or when they are on
seperate processes and need to talk via http client.
* remove datagen from RPM
was originally added as a convenience to generate test data, but is
unused and annoying because datagen doesn't easily cross-compile due
to cgo
* add marshalUnmarshal to controller to avoid passing pointers
passing pointers across API boundaries can cause unpredictable things
in local vs remote configurations.
Co-authored-by: Matthew Jaffee <jaffee@pilosa.com>
"fix" a few issues with wrong default partition numbers
these still need to be properly fixed and actually get the correct
data from MDS
go mod tidy
Introduce TableQualifier (OrganizationID/DatabaseID) (#2220)
* add check in ApplyDirective that version is increasing
fix TestAPIDirective to make version always increasing
* fix docker image build and break out dax test in CI
We have to run the DAX integration tests separately as they call out
to Docker, and so it isn't easy to run them in a Docker container as
the other tests do. So we run them directly on the CI runner which has
Docker and Go installed.
We also explicitly exclude these tests from running during the other
tests.
Also my editor was automatically reformatting some comments badly
which is why I added the "data" thing in those two places
* add timeout to poller
* give Poller a default Logger
apparently we can NPE sometimes, seen in CI: https://gitlab.com/molecula/featurebase/-/jobs/3028286364
* bunch of testing fixes, mostly IDK/DAX related
make MDS error if sendDirectives errors, don't just
log. sendDirectives can error if computer nodes disagree about the
validity of a schema (for example), in which case it might need to get
deleted and user notified somehow. very messy, needs more thought.
re-introduce old env prefix to maintain compatibility with master
branch
make self-contained dax container for IDK testing
build IDK images from source (now that all the source is available
since it's in the same repo)
catch errors in DoExtractQuery in idktest.go
fix IDK bug where prefix path was hardcoded in all cases rather than
only when useMDS was true
fix TestBatchTargetMDS... needed to add field options and catch error
when creating table. also needed an _id field
* fix env prefix in tests
* WIP getting tests to pass, wanna see CI
* don't error if we get a zero version directive and we don't have a
directive yet
* cleanup debugging junk
* "fix" future.rename thing, run IDK tests
* Introduce TableQualifier (OrganizationID/DatabaseID)
This commit introduces a lot of new types (in dax/table.go) related to
TableQualifer (which is made up of OrganizationID and DatabaseID), as
well as things like TableID and TableKey.
For the most part, we try to thread a QualifiedTableID through the
entirety of DAX. There are some places (for example in the Balancers,
which are just aware of string keys) which use a string TableKey
(tbl__org__db__tableid).
* Remove some debugging comments
* Add Org/DB support to CLI.
This commit adds support for special commands:
SET
SET ORG acme
SET DB db1
USE db1
* remove ".pulled" from IDK Makefile
I don't think we need it any more as most things can be built
locally. I think it was only there to refresh the FeatureBase images
that were tagged as master, but we don't need to do that any more.
* Change DAX json tags to kebab-case (i.e. hyphenated)
This commit also renames some struct arguments to more accurately
reflect their type: for example, renaming `Table` to `TableKey` when the
type is TableKey.
* Return DAX TableName in SHOW TABLES (instead of Index.Name)
There are cases where SchemaAPI is used to return DAX friendly table
names (as opposed to featurebase index names, which are DAX TableKey).
This is an attempt to do that. With that said, it's not ideal because
anything could call those API methods and expect the other type.
* Fix a bug which wasn't completely dropping a table.
When using boltdb as a backend, DROP TABLE wasn't removing the
reverse-lookup key for the table in boltdb.
* Remove idk/testenv/certs which got accidentally committed.
also update .gitignore to include those.
* Fix IDK ingest tests to be TableQualifier aware.
* Add example Table types to dax/table.com godoc.
* ignore idk.Main fields for flags, upgrade commandeer
* go mod tidy
* Fix DAX integration tests: ingester using wrong ENV VARs
We change from ORGANIZATION_ID to ORG_ID
and from DATABASE_ID to DB_ID
* Clarify things around idk (docker) tests
* Stop running TestKafkaSourceIntegration with t.Parallel()
This test can't be run in parallel as it's currently written. Doing so
allows for interleaving of messages to the same kafka topic between
tests.
I didn't attempt to modify the test so it could be run in parallel. That
could be done, but left for someone more ambitious.
Co-authored-by: Matthew Jaffee <jaffee@pilosa.com>
Require Directive.Version be a non-zero value. (#2227)
Because the directive cached on the holder is not a pointer, its default
version is 0. In order to avoid having to compare against that, we just
require that Directive.Version start at 1.
General, non-invasive code cleanup and comment adjustment.
Move ImportRoaringShardRequest out of the types package
Early on in the DAX development, I moved ImportRoaringShardRequest into
a types package. There must have been some import loop going on, but
since that is not longer the case, it's safe to move this back into the
core featurebase (er... pilosa) package.
Move Transaction struct back into the pilosa package (from types)
Revert some name changes (cli -> client)
Add DAX Handler CloseTimeout
This was implemented in htt_handler.go, but it had been commented out in
the DAX handler. This just uncomments that and finishes the
implementation.
Remove Qcx from queryer.Importer interface
This sets us up to revert the Qctx interface that was initially
introduced to allow us to abstract away the need for a Qcx when calling
the ComputeAPI from a remote service (i.e. the queryer).
Add some go-doc comments and remove unused code.
Move SchemaManager setup from datagen to idk.Main (#2233)
The set for idk.SchemaManager (for dax implementations) was previously
in datagen. This may have been because of some import loop problem
during development, but that's no longer an issue.
The setup for this should be in idk.Main so anything using that can
leverage the MDS-specific SchemaManager setup.
Fix issues around nil TxFactory
First, don't return a nil. Rather return a new *TxFactory (with no
holder).
Second, don't call `f.holder` in the testhook outside of checking if
`f.holder` is nil.
Wrap all bare errors
Make service prefixes constants
Instead of having `"computer"` throughout the code, use instead a
constant: `dax.ServicePrefixComputer`.
MDS skip errors when sending empty directives
also add in the docker-login and ecr-push changes for serverless DAX
Fix the logic in Directive.IsEmpty() (#2236)
Update the cached value for Index.translatePartitions
In the case where a node already knows about an index, but its
assignment of partitions for that index changes (for example, when
another node goes down and the node in question is now responsible for
more partitions than it previously was), then we need to update the
cached value of Index.translatePartitions because that's used in
translation checks.
minor fixes for IDK-related bugs
WIP: tokenize CLI to access cloud
FB CLI cloud support with automatic token refresh
Also adds support for a GET command which allows making HTTP GET
queries to cloud CP which can be handy for debugging stuff. E.g. GET /v2/databases
buncha little fixes working on writelogger stuff
fix writelogger/snapshotter setup bugs
implement writelogging for importRoaringShard
add debug endpoint to MDS
use shard transactional endpoint in MDS datagen
add debugging to API related to writelogger
revert handleroption change
clean up big PR
remove "GET" command from CLI for making arbitrary HTTP request to
cloud control plane (was a messy hack and not that useful)
remove json tags from FB objects where we had to duplicate the object
elsewhere due to import loops and weren't actually json encoding it
unexport handlerOption which was exported to try to avoid doing
certain things if we're in DAX mode, but I didn't end up merging that code.
remove (hopefully) unecessary extra call to api.indexField
fix some formatting, unexport some vars, godoc, etc
oops, fix build failure
Update FeatureBase CLI to support a standard deployment
The standard deployment uses a different endpoint and request payload.
This commit tries to detect is the standard deployment is being used,
and if so, it uses a standard-specific FBQueryer.
It also modifies the auto-detection logic to try standard featurebase
and dax ports in the case where a port was not provided.
MDS API refactor (#2259)
* MDS API refactor
table IDs are exposed but only created server side
also cleaned up dax Makefile
* clean up review feedback
Co-authored-by: Travis Turner <travis@pilosa.com>
* remove TablesByName
* rip out inmem implementations and use boltdb everywhere
* remove inmem balancer, create bolt tempfile by default on startup
* WIP on snapshot table impl and test
* Minor comment and code layout adjustments.
This commit also adds the `Equals` method to `QualifiedTableID` for
equality comparisons. It's no longer safe to compare struct (two structs
might still be equal even if one of the structs doesn't have a `Name`
value.
* Use a unique docker network for each dax test
Ocassionally we would see some test failures due to a network already
existing. This shouldn't happen, but to avoid that, this commit
generates a unique name for each sub test (which gets deleted at the end
of every test).
* Fix one instance of NewQualifiedTableID losing Name
We should probably check the other instances and see if Name is getting
lost.
* simplify unique network stuff and fix api directive tests
* Remove TableIDRequest and TableIDResponse types for /table-id (#2267)
For the mds/table-id http requests, just use dax.QualifiedTableID as
both the request and response types.
* remove lattice from dax, no error on node re-reg, dax docker-compose
* various updates
* WIP: mds-refactor branch review
* no-op on SnapshotTableKeys if table is not keyed
* Makefile helpers
* add doWeCare so controller doesn't fail unnecessarily
* clean up table creation (#2272)
* Strip underscores from TableID stub name
* fix boltdb versionstore tests: generate unique, sorted tables
* fix controller test related to reregistering a node
* JobSet -> generic Set
Co-authored-by: Travis Turner <travis@pilosa.com>
Co-authored-by: Travis Turner <travis@molecula.com>
Cleanup after rebase on master
The latest rebase on master entailed all the client/batch changes as
well as some of the qcx refactoring. It made for a hairy rebase. This
commit fixes some of the tests that were failing after that rebase.
Fix batch/client import loop missed during rebase (#2280)
It's not surprising that `batch` can't import `client`. It was doing
that here (importing an error type from the `client` package). What is
surprising is that it's okay for `batch_test.go` to import `client` even
though `batch_test.go` is an internal test and therefore part of the
`batch` package.
different boltDB's for schemar/controller, explicit balancers
nice helpers for dax docker-compose, make build really fast
build FB binary outside of docker, then create Docker image with its
working dir in an empty subdirectory so it doesn't send a GB of
context to the daemon.
error on unassigned jobs and use client with timeout
fix CR feedback
deregister batch of nodes
also make removal faster via director dial timeout
implement WorkersForJobPrefix so orchestrator doesn't make up shards
also fix some godocs and remove unused method
Run sub-tasks of a Directive concurrently in a worker pool. (#2275)
* Run sub-tasks of a Directive concurrently in a worker pool.
This allows the compute node to concurrently load shapshot and writelog
data concurrently, instead of one keyset/partition/shard at a time.
It introduces a config parameter called `DirectiveWorkerPoolSize`.
* code review cleanup
* Use unique container names in DAX integration tests
We were seeing "container already exists" errors in CI, so just to be
safe, this commit constructs a unique container name for every container
in the DAX integration test run.
Stub in SystemAPI to Queryer (note: will not work if used)
This just makes is so that dax can compile. Actually implementing
system-table functionality for dax will take some planning.
Tlt/dax merge prep (#2282)
* Remove copilot directory
* Remove Dockerfile-datagen-long
* Remove orphaned RegisterNodeRequest
This type is not defined in the dax/mds/http package.
* implement TIMEQUANTUM and TTL in Table.Field type
* Remove the "service" misdirection in queryer/writelogger/snapshotter.
We had originally used an additional layer, er.. package, for a "service".
The main distinction was that the Config differed in that it was
internal, unlike the Config that we need to provide for the top-level
server config (i.e. toml). Having that additional layer just to support
a different Config seemed premature at best. So I'm removing it.
* Remove dax docker containers no longer used in tests
Since we run everything as "featurebase", we don't have multiple
container types anymore.
* Some minor comment updates
* Remove nfpm stuff related to dax
* Fix linter issues
Fix "duplicate" issues raised by sonarcloud.
run docker components of dax integration tests with coverage
trying to get dax integration coverage
add coverate volume mounts throughout dax integration tests
add a lock, tweak dax Makefile, remote flag on query handler
remove some unused code
convert batch tests to use clustertests to get coverage
maybe fix clustertests
more authclustertests fixes, test is failing locally
but also seems to have been silently failing in CI prior to these
changes... let's see if it's still silent
fix some lint to kick CI
just re-running the job wasn't working... strange behavior
remove RetryLogic test and pipe which don't work
RetryLogic test removed due to etcd changes. Seebs thinks we shouldn't
test this here.
Pipe was being ignored since we're no longer using "bash -c" to
execute the command. If we need to generate that output file we'll
either have to reintroduce bash -c and set -o pipefail so that it
actually fails properly, or figure out some other solution.
shooting into the dark...
first cut at bulk node registration
remove unused stuff from batch tests, set coverpkg to ../...
batch registration timeout and fix tests
disable most tests and don't run fb background batch test
debuggin!!!!!!!!!
and then he tried this....
Implement importer (for INSERT INTO) in the Queryer
Prior to this, we we passing a nil value in for the importer to the
planner.NewExecutionPlanner in the Queryer. This meant that INSERT INTO
statements didn't work. Now they should.
It uses the importer that we build for IDK in /idk/mds/importer.go, and
wrapps that with a type that can determine if the provided string
"index" is of the form indexName or TableKey.
turn off debug mode, fix log saving
Run sql3 test definitions in a dax integration test
There are currently 22 tests which are not passing. They are skipped in
the "skips" slice.
WIP, not working, pql queries to tests
Add TableQualifier to PQL query logic in the Queryer
Add more PQL tests to the keyed table
Allow instant node registration if registration-batch-timeout=0
When running dax services in process, we don't want to wait 3s for the
compute node to register; we know it's there because it's in the same
process.
Fixes related to IncludesColumn PQL test.
Tests for ConstRow and FieldValue
cleanup
add UnionRows and Options, better error reporting on bad queries
delete unused schemar client.go, clean up unused in batch test CI
move test timeouts into more reasonable territory
apparently this had already been done, but got merge-stommped at some point
move dax bolt test helpers into dax package
Add computer CheckIn routine (#2296)
* Add computer CheckIn routine
This adds a background routine which sends a "check-in" request to MDS
every <interval>. This is to address the case where the poller has
removed a computer node from the node list (due to a network fault, for
example), but the node is still healthy and becomes available again. In
that case, the node needs to "check-in" to tell MDS it is still there.
MDS will likely send the node a new directive with Method=reset telling
the node to delete all of its data an apply the latest directive.
* Don't send directives to Deregistered (i.e. removed) nodes
We have an issue where we're locking on sendDirective in the
controller, and when the node is unavailable, the send hangs and never
releases the lock. This is a temporary fix for that until we address the
real problem.
Fix .gitlab-ci.yml after rebase
fix some indentation shenanigans
(cherry picked from commit 20a8b5713a)
1359 lines
35 KiB
Go
1359 lines
35 KiB
Go
package idk
|
|
|
|
import (
|
|
"context"
|
|
"encoding/binary"
|
|
"fmt"
|
|
"math"
|
|
"reflect"
|
|
"sort"
|
|
"strconv"
|
|
"strings"
|
|
"time"
|
|
|
|
pilosacore "github.com/featurebasedb/featurebase/v3"
|
|
pilosaclient "github.com/featurebasedb/featurebase/v3/client"
|
|
"github.com/featurebasedb/featurebase/v3/pql"
|
|
"github.com/pkg/errors"
|
|
)
|
|
|
|
var (
|
|
// ErrSchemaChange is returned from Source.Record when the returned
|
|
// record has a different schema from the previous record.
|
|
ErrSchemaChange = errors.New("this record has a different schema from the previous record (or is the first one delivered). Please call Source.Schema() to fetch the schema in order to properly decode this record")
|
|
|
|
// ErrFlush is returned from Source.Record when the Source wants to
|
|
// signal that there may not be data for a while, so it's a good time
|
|
// to make sure all data which has been received is ingested. The
|
|
// record must be nil when ErrFlush is returned.
|
|
ErrFlush = errors.New("the Source is requesting the batch be flushed")
|
|
|
|
ErrFmtUnknownUnit = "unknown unit %q, please choose from d/h/m/s/ms/us/ns"
|
|
ErrIntOutOfRange = errors.New("value provided for int field is out of range")
|
|
ErrDecimalOutOfRange = errors.New("value provided for decimal field is out of range")
|
|
ErrTimestampOutOfRange = errors.New("value provided for timestamp field is out of range")
|
|
)
|
|
|
|
type (
|
|
// Source is an interface implemented by sources of data which can be
|
|
// ingested into Pilosa. Each Record returned from Record is described
|
|
// by the slice of Fields returned from Source.Schema directly after
|
|
// the call to Source.Record. If the error returned from Source.Record
|
|
// is nil, then the call to Schema which applied to the previous
|
|
// Record also applies to this Record. Source implementations are
|
|
// fundamentally not threadsafe (due to the interplay between Record
|
|
// and Schema).
|
|
Source interface {
|
|
// Record returns a data record, and an optional error. If the
|
|
// error is ErrSchemaChange, then the record is valid, but one
|
|
// should call Source.Schema to understand how each of its fields
|
|
// should be interpreted.
|
|
Record() (Record, error)
|
|
|
|
// Schema returns a slice of Fields which applies to the most
|
|
// recent Record returned from Source.Record. Every Field has a
|
|
// name and a type, and depending on the concrete type of the
|
|
// Field, may have other information which is relevant to how it
|
|
// should be indexed.
|
|
Schema() []Field
|
|
|
|
Close() error
|
|
}
|
|
|
|
Record interface {
|
|
// Commit notifies the Source which produced this record that it
|
|
// and any record which came before it have been completely
|
|
// processed. The Source can then take any necessary action to
|
|
// record which records have been processed, and restart from the
|
|
// earliest unprocessed record in the event of a failure.
|
|
Commit(ctx context.Context) error
|
|
|
|
Data() []interface{}
|
|
}
|
|
|
|
// OffsetStreamRecord is an extension of the record type which also tracks offsets within streams.
|
|
OffsetStreamRecord interface {
|
|
Record
|
|
|
|
// StreamOffset returns the stream from which the record originated, and the offset of the record within that stream.
|
|
StreamOffset() (key string, offset uint64)
|
|
}
|
|
|
|
Metadata interface {
|
|
// SchemaMetadata returns a string representation of source-specific details
|
|
// about the schema.
|
|
SchemaMetadata() string
|
|
SchemaSubject() string
|
|
SchemaSchema() string
|
|
SchemaVersion() int
|
|
SchemaID() int
|
|
}
|
|
|
|
// Field knows how to interpret values of different types and tells
|
|
// how they get indexed in Pilosa. Every field implementation should
|
|
// be a struct named like <something>Field, and have as members
|
|
// `NameVal string` and `DestNameVal string`, where NameVal contains
|
|
// the name of the field at the source, and DestNameVal contains the
|
|
// name of the field at the destination (pilosa)
|
|
//
|
|
// Many Field implementations have a Quantum field which can be any
|
|
// valid Pilosa time quantum, e.g. "Y", "YMDH", "DH", etc. If Quantum
|
|
// is set to a valid quantum, the Pilosa field created for this field
|
|
// will be of type "time". Other fields which control field type will
|
|
// be ignored until/if Pilosa supports time+(othertype) fields.
|
|
Field interface {
|
|
Name() string
|
|
DestName() string
|
|
PilosafyVal(val interface{}) (interface{}, error) // TODO rename this
|
|
}
|
|
)
|
|
|
|
// FieldsEqual is used in testing to compare Fields. The pointers make it a bit tricky for IntField.
|
|
func FieldsEqual(f1, f2 Field) bool {
|
|
if reflect.TypeOf(f1) != reflect.TypeOf(f2) {
|
|
return false
|
|
}
|
|
switch f1t := f1.(type) {
|
|
case IgnoreField, IDField, BoolField, RecordTimeField, StringField, LookupTextField, DecimalField, SignedIntBoolKeyField, StringArrayField, IDArrayField, TimestampField, DateIntField:
|
|
return f1 == f2
|
|
case IntField:
|
|
f2t := f2.(IntField)
|
|
if f1t.NameVal == f2t.NameVal && f1t.DestNameVal == f2t.DestNameVal && f1t.ForeignIndex == f2t.ForeignIndex {
|
|
if !(f1t.Min == nil && f2t.Min == nil) {
|
|
if f1t.Min == nil || f2t.Min == nil {
|
|
return false
|
|
}
|
|
if *f1t.Min != *f2t.Min {
|
|
return false
|
|
}
|
|
}
|
|
if !(f1t.Max == nil && f2t.Max == nil) {
|
|
if f1t.Max == nil || f2t.Max == nil {
|
|
return false
|
|
}
|
|
if *f1t.Max != *f2t.Max {
|
|
return false
|
|
}
|
|
}
|
|
return true
|
|
}
|
|
return false
|
|
default:
|
|
panic(fmt.Sprintf("unknown field type %T when comparing fields", f1))
|
|
}
|
|
}
|
|
|
|
// CacheConfigOf returns CacheConfig of the Field.
|
|
func CacheConfigOf(f Field) CacheConfig {
|
|
switch f := f.(type) {
|
|
case StringField:
|
|
if f.CacheConfig == nil {
|
|
if f.Quantum != "" {
|
|
return noneCacheConfig
|
|
}
|
|
return defaultCacheConfig
|
|
}
|
|
return *f.CacheConfig
|
|
case StringArrayField:
|
|
if f.CacheConfig == nil {
|
|
if f.Quantum != "" {
|
|
return noneCacheConfig
|
|
}
|
|
return defaultCacheConfig
|
|
}
|
|
return *f.CacheConfig
|
|
case IDField:
|
|
if f.CacheConfig == nil {
|
|
if f.Quantum != "" {
|
|
return noneCacheConfig
|
|
}
|
|
return defaultCacheConfig
|
|
}
|
|
return *f.CacheConfig
|
|
case IDArrayField:
|
|
if f.CacheConfig == nil {
|
|
if f.Quantum != "" {
|
|
return noneCacheConfig
|
|
}
|
|
return defaultCacheConfig
|
|
}
|
|
return *f.CacheConfig
|
|
default:
|
|
return defaultCacheConfig
|
|
}
|
|
}
|
|
|
|
// QuantumOf returns Quantum of the Field.
|
|
func QuantumOf(fld Field) string {
|
|
switch ft := fld.(type) {
|
|
case IDField:
|
|
return ft.Quantum
|
|
case StringField:
|
|
return ft.Quantum
|
|
case StringArrayField:
|
|
return ft.Quantum
|
|
case IDArrayField:
|
|
return ft.Quantum
|
|
default:
|
|
return ""
|
|
}
|
|
}
|
|
|
|
func TTLOf(fld Field) (time.Duration, error) {
|
|
var ttl time.Duration
|
|
var err error
|
|
|
|
switch ft := fld.(type) {
|
|
case IDField:
|
|
if ft.TTL != "" {
|
|
ttl, err = time.ParseDuration(ft.TTL)
|
|
} else {
|
|
return 0, nil
|
|
}
|
|
case StringField:
|
|
if ft.TTL != "" {
|
|
ttl, err = time.ParseDuration(ft.TTL)
|
|
} else {
|
|
return 0, nil
|
|
}
|
|
case StringArrayField:
|
|
if ft.TTL != "" {
|
|
ttl, err = time.ParseDuration(ft.TTL)
|
|
} else {
|
|
return 0, nil
|
|
}
|
|
case IDArrayField:
|
|
if ft.TTL != "" {
|
|
ttl, err = time.ParseDuration(ft.TTL)
|
|
} else {
|
|
return 0, nil
|
|
}
|
|
default:
|
|
return 0, nil
|
|
}
|
|
if err != nil {
|
|
return ttl, errors.Wrapf(err, "unable to parse TTL from field %s", fld.Name())
|
|
} else {
|
|
return ttl, nil
|
|
}
|
|
}
|
|
|
|
// HasMutex returns Mutex value of StringField or IDField, otherwise false
|
|
func HasMutex(fld Field) bool {
|
|
if sfld, ok := fld.(StringField); ok && sfld.Quantum == "" {
|
|
return sfld.Mutex
|
|
}
|
|
if sfld, ok := fld.(IDField); ok && sfld.Quantum == "" {
|
|
return sfld.Mutex
|
|
}
|
|
return false
|
|
}
|
|
|
|
// IgnoreField can be used when you wish not to process one of the
|
|
// input fields, but it is inconvenient to remove it ahead of time.
|
|
type IgnoreField struct{}
|
|
|
|
func (IgnoreField) Name() string { return "" }
|
|
func (IgnoreField) DestName() string { return "" }
|
|
func (IgnoreField) PilosafyVal(interface{}) (interface{}, error) { return nil, nil }
|
|
|
|
type IDField struct {
|
|
NameVal string
|
|
DestNameVal string
|
|
|
|
// Mutex denotes whether we need to enforce that each record only
|
|
// has a single value for this field. Put another way, says
|
|
// whether a new value for this field be treated as adding an
|
|
// additional value, or replacing the existing value (if there is
|
|
// one).
|
|
Mutex bool
|
|
|
|
// Quantum — see note about Quantum on "Field" interface.
|
|
Quantum string
|
|
|
|
TTL string
|
|
|
|
*CacheConfig
|
|
}
|
|
|
|
func (id IDField) Name() string { return id.NameVal }
|
|
func (id IDField) DestName() string {
|
|
if id.DestNameVal == "" {
|
|
return id.NameVal
|
|
}
|
|
|
|
return id.DestNameVal
|
|
}
|
|
func (id IDField) PilosafyVal(val interface{}) (interface{}, error) {
|
|
if val == nil {
|
|
return nil, nil
|
|
} else if vs, ok := val.(string); ok && vs == "" {
|
|
return nil, nil
|
|
}
|
|
return toUint64(val)
|
|
}
|
|
|
|
type BoolField struct {
|
|
NameVal string
|
|
DestNameVal string
|
|
}
|
|
|
|
func (b BoolField) Name() string { return b.NameVal }
|
|
func (b BoolField) DestName() string {
|
|
if b.DestNameVal == "" {
|
|
return b.NameVal
|
|
}
|
|
|
|
return b.DestNameVal
|
|
}
|
|
func (b BoolField) PilosafyVal(val interface{}) (interface{}, error) {
|
|
if val == nil {
|
|
return nil, nil
|
|
} else if vs, ok := val.(string); ok && vs == "" {
|
|
return nil, nil
|
|
}
|
|
return toBool(val)
|
|
}
|
|
|
|
var (
|
|
MinTimestampNano = time.Unix(-1<<32, 0).UTC() // 1833-11-24T17:31:44Z
|
|
MaxTimestampNano = time.Unix(1<<32, 0).UTC() // 2106-02-07T06:28:16Z
|
|
MinTimestamp = time.Unix(-62135596799, 0).UTC() // 0001-01-01T00:00:01Z
|
|
MaxTimestamp = time.Unix(253402300799, 0).UTC() // 9999-12-31T23:59:59Z
|
|
)
|
|
|
|
const (
|
|
Custom = Unit("c")
|
|
Day = Unit("d")
|
|
Hour = Unit("h")
|
|
Minute = Unit("m")
|
|
Second = Unit("s")
|
|
Millisecond = Unit("ms")
|
|
Microsecond = Unit("us")
|
|
Nanosecond = Unit("ns")
|
|
|
|
DefaultUnit = Second
|
|
)
|
|
|
|
type Unit string
|
|
|
|
func (u Unit) unit() Unit {
|
|
s := strings.ToLower(string(u))
|
|
if s == "" {
|
|
return DefaultUnit
|
|
}
|
|
return Unit(s)
|
|
}
|
|
|
|
func (u Unit) IsCustom() bool {
|
|
return u.unit() == Custom
|
|
}
|
|
|
|
func (u Unit) Duration() (time.Duration, error) {
|
|
duration := time.Duration(1)
|
|
switch u.unit() {
|
|
case Day:
|
|
duration *= 24
|
|
fallthrough
|
|
case Hour:
|
|
duration *= 60
|
|
fallthrough
|
|
case Minute:
|
|
duration *= 60
|
|
fallthrough
|
|
case Second:
|
|
duration *= 1000
|
|
fallthrough
|
|
case Millisecond:
|
|
duration *= 1000
|
|
fallthrough
|
|
case Microsecond:
|
|
duration *= 1000
|
|
fallthrough
|
|
case Nanosecond:
|
|
return duration, nil
|
|
}
|
|
return 0, errors.Errorf(ErrFmtUnknownUnit, u)
|
|
}
|
|
|
|
// ToNanos returns the number of Nanoseconds per given Unit
|
|
func (u Unit) ToNanos() (int64, error) {
|
|
duration := int64(1)
|
|
switch u.unit() {
|
|
case Day:
|
|
duration *= 24
|
|
fallthrough
|
|
case Hour:
|
|
duration *= 60
|
|
fallthrough
|
|
case Minute:
|
|
duration *= 60
|
|
fallthrough
|
|
case Second:
|
|
duration *= 1000
|
|
fallthrough
|
|
case Millisecond:
|
|
duration *= 1000
|
|
fallthrough
|
|
case Microsecond:
|
|
duration *= 1000
|
|
fallthrough
|
|
case Nanosecond:
|
|
return duration, nil
|
|
}
|
|
return 0, errors.Errorf(ErrFmtUnknownUnit, u)
|
|
}
|
|
|
|
func (u Unit) DurationFromValue(val int64) (time.Duration, error) {
|
|
scale, err := u.Duration()
|
|
if err != nil {
|
|
return 0, err
|
|
}
|
|
if max, min := int64(math.MaxInt64/scale), int64(math.MinInt64/scale); val > max || val < min {
|
|
return 0, errors.Errorf("%d%s is outside representable time scales, must be between %d and %d", val, u, min, max)
|
|
}
|
|
return time.Duration(val) * scale, nil
|
|
}
|
|
|
|
func (r RecordTimeField) epoch() time.Time {
|
|
if r.Epoch.IsZero() {
|
|
return time.Unix(0, 0)
|
|
}
|
|
return r.Epoch
|
|
}
|
|
|
|
// RecordTimeField applies to whole record, but doesn't have a name
|
|
// (or quantum) of its own since it applies to any other time fields
|
|
// in the record.
|
|
type RecordTimeField struct {
|
|
NameVal string
|
|
DestNameVal string
|
|
Layout string // Layout tells how the time should be parsed. Defaults to RFC3339.
|
|
// need a way to create other time fields in the record (add time/quantum to String, StringArray, ID, IDArray?)
|
|
// do we need a way to have timefields in a record with independent times/values
|
|
Epoch time.Time
|
|
Unit Unit
|
|
}
|
|
|
|
func (r RecordTimeField) Name() string { return r.NameVal }
|
|
func (r RecordTimeField) DestName() string {
|
|
if r.DestNameVal == "" {
|
|
return r.NameVal
|
|
}
|
|
|
|
return r.DestNameVal
|
|
}
|
|
|
|
// PilosafyVal for RecordTimeField always returns a time.Time or nil.
|
|
func (r RecordTimeField) PilosafyVal(val interface{}) (interface{}, error) {
|
|
if valt, ok := val.(time.Time); ok {
|
|
return valt, nil
|
|
}
|
|
if !r.Epoch.IsZero() || r.Unit != "" {
|
|
result, err := timeFromEpoch(val, r.epoch(), r.Unit)
|
|
if err != nil {
|
|
err = errors.Wrap(err, "converting RecordTimeField from epoch")
|
|
}
|
|
return result, err
|
|
}
|
|
|
|
result, err := timeFromTimestring(val, r.layout())
|
|
if err != nil {
|
|
err = errors.Wrap(err, "converting RecordTimeField from layout")
|
|
}
|
|
if result.IsZero() {
|
|
return nil, err
|
|
}
|
|
return result, err
|
|
}
|
|
|
|
func (r RecordTimeField) layout() string {
|
|
if r.Layout == "" {
|
|
return time.RFC3339
|
|
}
|
|
return r.Layout
|
|
}
|
|
|
|
// CacheConfig - type (ranked, lru, none) and size.
|
|
type CacheConfig struct {
|
|
CacheType pilosaclient.CacheType
|
|
CacheSize int
|
|
}
|
|
|
|
var defaultCacheConfig = CacheConfig{CacheType: pilosaclient.CacheTypeRanked, CacheSize: pilosacore.DefaultCacheSize}
|
|
var noneCacheConfig = CacheConfig{CacheType: "", CacheSize: 0}
|
|
|
|
func (cfg CacheConfig) setOption() pilosaclient.FieldOption {
|
|
if cfg == (CacheConfig{}) {
|
|
cfg = defaultCacheConfig
|
|
}
|
|
|
|
return pilosaclient.OptFieldTypeSet(pilosaclient.CacheType(cfg.CacheType), cfg.CacheSize)
|
|
}
|
|
|
|
func (cfg CacheConfig) mutexOption() pilosaclient.FieldOption {
|
|
if cfg == (CacheConfig{}) {
|
|
cfg = defaultCacheConfig
|
|
}
|
|
|
|
return pilosaclient.OptFieldTypeMutex(pilosaclient.CacheType(cfg.CacheType), cfg.CacheSize)
|
|
}
|
|
|
|
type StringField struct {
|
|
NameVal string
|
|
DestNameVal string
|
|
|
|
// Mutex denotes whether we need to enforce that each record only
|
|
// has a single value for this field. Put another way, says
|
|
// whether a new value for this field be treated as adding an
|
|
// additional value, or replacing the existing value (if there is
|
|
// one).
|
|
Mutex bool
|
|
|
|
// Quantum — see note about Quantum on "Field" interface.
|
|
Quantum string
|
|
|
|
TTL string
|
|
|
|
*CacheConfig
|
|
}
|
|
|
|
func (s StringField) Name() string { return s.NameVal }
|
|
func (s StringField) DestName() string {
|
|
if s.DestNameVal == "" {
|
|
return s.NameVal
|
|
}
|
|
|
|
return s.DestNameVal
|
|
}
|
|
func (s StringField) PilosafyVal(val interface{}) (interface{}, error) {
|
|
if val == nil {
|
|
return nil, nil
|
|
}
|
|
return toString(val)
|
|
}
|
|
|
|
type LookupTextField struct {
|
|
// NOTE this implements the Field interface for simplicity of implementation/API, but that interface is intended for data going into pilosa, while this is not.
|
|
NameVal string
|
|
DestNameVal string
|
|
// TODO this might should reference the lookupDB
|
|
}
|
|
|
|
func (s LookupTextField) Name() string { return s.NameVal }
|
|
func (s LookupTextField) DestName() string {
|
|
if s.DestNameVal == "" {
|
|
return s.NameVal
|
|
}
|
|
|
|
return s.DestNameVal
|
|
}
|
|
func (s LookupTextField) PilosafyVal(val interface{}) (interface{}, error) {
|
|
if val == nil {
|
|
return nil, nil
|
|
}
|
|
return toString(val)
|
|
}
|
|
|
|
// IntField - if you add any new fields to this struct, please update the FieldsEqual function to accomodate.
|
|
type IntField struct {
|
|
NameVal string
|
|
DestNameVal string
|
|
Min *int64
|
|
Max *int64
|
|
ForeignIndex string
|
|
}
|
|
|
|
func (i IntField) Name() string { return i.NameVal }
|
|
func (i IntField) DestName() string {
|
|
if i.DestNameVal == "" {
|
|
return i.NameVal
|
|
}
|
|
|
|
return i.DestNameVal
|
|
}
|
|
func (i IntField) PilosafyVal(val interface{}) (interface{}, error) {
|
|
if val == nil {
|
|
return nil, nil
|
|
}
|
|
if valS, ok := val.(string); ok && i.ForeignIndex != "" {
|
|
return valS, nil
|
|
} else if ok && valS == "" {
|
|
return nil, nil
|
|
}
|
|
asInt, err := toInt64(val)
|
|
if err != nil {
|
|
return nil, err
|
|
}
|
|
|
|
if i.Min != nil && asInt < *i.Min {
|
|
return nil, errors.Wrapf(ErrIntOutOfRange, "field = %v, value %v is smaller than min allowed %v", i.Name(), asInt, *i.Min)
|
|
}
|
|
if i.Max != nil && asInt > *i.Max {
|
|
return nil, errors.Wrapf(ErrIntOutOfRange, "field = %v, value %v is bigger than max allowed %v", i.Name(), asInt, *i.Max)
|
|
}
|
|
return asInt, nil
|
|
}
|
|
|
|
const DecimalPrecision = 18
|
|
|
|
type DecimalField struct {
|
|
NameVal string
|
|
DestNameVal string
|
|
Scale int64
|
|
}
|
|
|
|
func (d DecimalField) Name() string { return d.NameVal }
|
|
func (d DecimalField) DestName() string {
|
|
if d.DestNameVal == "" {
|
|
return d.NameVal
|
|
}
|
|
|
|
return d.DestNameVal
|
|
}
|
|
|
|
// PilosafyVal for DecimalField always returns an int64. If the
|
|
// incoming value is anything but a float or string we attempt to
|
|
// convert to int64 and then scale it. Strings are attempted to be
|
|
// parsed into floats, and all values are scaled by the 10^scale
|
|
// before being returned. Byte slices are assumed to represent the
|
|
// already scaled value and are interpreted as int64.
|
|
func (d DecimalField) PilosafyVal(val interface{}) (interface{}, error) {
|
|
// Make sure the provided scale is supported before proceeding.
|
|
// Note: the "1" value below doesn't matter; we're just
|
|
// validating the scale.
|
|
// Also, the existing tests don't exercise this check because
|
|
// they error creating the field prior to getting here.
|
|
// TODO: let's move scale validation to the pql package so
|
|
// that it can control the specific error message.
|
|
if !pql.NewDecimal(1, d.Scale).IsValid() {
|
|
return nil, errors.Errorf("scale values outside the range [0,19] are not supported: %d", d.Scale)
|
|
}
|
|
|
|
if val == nil {
|
|
return nil, nil
|
|
}
|
|
if vs, ok := val.(string); ok {
|
|
if vs == "" {
|
|
return nil, nil
|
|
}
|
|
asInt, err := scaledStringToInt(d.Scale, vs)
|
|
if err != nil {
|
|
// scaledStringToInt returns 0 on error. If there is a problem parsing the string,
|
|
// we want to import nil.
|
|
return nil, errors.Wrap(err, ErrDecimalOutOfRange.Error())
|
|
}
|
|
return asInt, nil
|
|
}
|
|
switch vt := val.(type) {
|
|
case pql.Decimal:
|
|
return vt.ToInt64(d.Scale), nil
|
|
|
|
case float32:
|
|
v := vt * float32(math.Pow10(int(d.Scale)))
|
|
return int64(v), nil
|
|
case float64:
|
|
vt = vt * math.Pow10(int(d.Scale))
|
|
return int64(vt), nil
|
|
case []byte:
|
|
// 16: int64(value)+int64(scale)
|
|
// 8: int64(value)
|
|
var tmp [8]byte
|
|
if len(vt) == 16 {
|
|
value := int64(binary.BigEndian.Uint64(vt[0:8]))
|
|
scale := int64(binary.BigEndian.Uint64(vt[8:16]))
|
|
return pql.NewDecimal(value, scale).ToInt64(d.Scale), nil
|
|
} else if len(vt) == 8 {
|
|
return int64(binary.BigEndian.Uint64(vt)), nil
|
|
} else if len(vt) < 8 {
|
|
copy(tmp[8-len(vt):], vt)
|
|
return int64(binary.BigEndian.Uint64(tmp[:])), nil
|
|
} else {
|
|
return nil, errors.Errorf("can only support decimal value up to 8 bytes, or 16 bytes containing value and scale, got %d for %s", len(vt), d.Name())
|
|
}
|
|
default:
|
|
v, err := toInt64(val)
|
|
if err != nil {
|
|
return nil, errors.Wrapf(err, "couldn't convert %v to int64 for decimal field", val)
|
|
}
|
|
return pql.NewDecimal(v, 0).ToInt64(d.Scale), nil
|
|
}
|
|
}
|
|
|
|
// SignedIntBoolKeyField translates a signed integer value to a (rowID, bool)
|
|
// pair corresponding to the magnitude and sign of the original value. This
|
|
// may be used to specify whether a bool value is to be set (positive/true)
|
|
// or cleared (negative/false).
|
|
type SignedIntBoolKeyField struct {
|
|
NameVal string
|
|
DestNameVal string
|
|
}
|
|
|
|
func (b SignedIntBoolKeyField) Name() string { return b.NameVal }
|
|
func (b SignedIntBoolKeyField) DestName() string {
|
|
if b.DestNameVal == "" {
|
|
return b.NameVal
|
|
}
|
|
|
|
return b.DestNameVal
|
|
}
|
|
|
|
func (SignedIntBoolKeyField) PilosafyVal(val interface{}) (interface{}, error) {
|
|
if val == nil {
|
|
return nil, nil
|
|
} else if vs, ok := val.(string); ok && vs == "" {
|
|
return nil, nil
|
|
}
|
|
|
|
return toInt64(val)
|
|
}
|
|
|
|
type StringArrayField struct {
|
|
NameVal string
|
|
DestNameVal string
|
|
|
|
// Quantum — see note about Quantum on "Field" interface.
|
|
Quantum string
|
|
|
|
TTL string
|
|
|
|
*CacheConfig
|
|
}
|
|
|
|
func (s StringArrayField) Name() string { return s.NameVal }
|
|
func (s StringArrayField) DestName() string {
|
|
if s.DestNameVal == "" {
|
|
return s.NameVal
|
|
}
|
|
|
|
return s.DestNameVal
|
|
}
|
|
func (StringArrayField) PilosafyVal(val interface{}) (interface{}, error) {
|
|
if val == nil {
|
|
return nil, nil
|
|
}
|
|
return toStringArray(val)
|
|
}
|
|
|
|
type IDArrayField struct {
|
|
NameVal string
|
|
DestNameVal string
|
|
|
|
// Quantum — see note about Quantum on "Field" interface.
|
|
Quantum string
|
|
|
|
TTL string
|
|
|
|
*CacheConfig
|
|
}
|
|
|
|
func (i IDArrayField) Name() string { return i.NameVal }
|
|
func (i IDArrayField) DestName() string {
|
|
if i.DestNameVal == "" {
|
|
return i.NameVal
|
|
}
|
|
|
|
return i.DestNameVal
|
|
}
|
|
func (IDArrayField) PilosafyVal(val interface{}) (interface{}, error) {
|
|
if val == nil {
|
|
return nil, nil
|
|
}
|
|
return toUint64Array(val)
|
|
}
|
|
|
|
type TimestampField struct {
|
|
NameVal string
|
|
DestNameVal string
|
|
Layout string
|
|
Epoch time.Time
|
|
Unit Unit
|
|
Granularity string
|
|
}
|
|
|
|
func (d TimestampField) Name() string { return d.NameVal }
|
|
|
|
func (d TimestampField) DestName() string {
|
|
if d.DestNameVal == "" {
|
|
return d.NameVal
|
|
}
|
|
return d.DestNameVal
|
|
}
|
|
|
|
// ValToTimestamp takes a timeunit and an integer value and converts it to time.Time
|
|
func ValToTimestamp(unit string, val int64) (time.Time, error) {
|
|
switch unit {
|
|
case string(Second):
|
|
return time.Unix(val, 0).UTC(), nil
|
|
case string(Millisecond):
|
|
return time.UnixMilli(val).UTC(), nil
|
|
case string(Microsecond):
|
|
return time.UnixMicro(val).UTC(), nil
|
|
case string(Nanosecond):
|
|
return time.Unix(0, val).UTC(), nil
|
|
default:
|
|
return time.Time{}, errors.Errorf("Unknown time unit: '%v'", unit)
|
|
}
|
|
}
|
|
|
|
// TimestampToVal takes a time unit and a time.Time and converts it to an integer value
|
|
func TimestampToVal(unit Unit, ts time.Time) int64 {
|
|
switch unit {
|
|
case Second:
|
|
return ts.Unix()
|
|
case Millisecond:
|
|
return ts.UnixMilli()
|
|
case Microsecond:
|
|
return ts.UnixMicro()
|
|
case Nanosecond:
|
|
return ts.UnixNano()
|
|
}
|
|
return 0
|
|
|
|
}
|
|
|
|
// PilosafyVal for TimestampField always returns an int or nil.
|
|
func (t TimestampField) PilosafyVal(val interface{}) (interface{}, error) {
|
|
if val == nil {
|
|
return nil, nil
|
|
}
|
|
|
|
var dur int64
|
|
// Check if the epoch alone is out-of-range. If so, ingest should halt, regardless
|
|
// of state of the timestamp out-of-range CLI option.
|
|
if err := validateTimestamp(t.granularity(), t.epoch()); err != nil {
|
|
return nil, errors.Wrap(err, "validating epoch")
|
|
}
|
|
|
|
epochAsVal := TimestampToVal(t.granularity(), t.epoch())
|
|
if _, ok := val.(time.Time); ok || (t.Epoch.IsZero() && t.Unit == "") {
|
|
ts, err := timeFromTimestring(val, t.layout())
|
|
if err != nil {
|
|
if strings.Contains(err.Error(), "out of range") {
|
|
return nil, errors.Wrap(err, ErrTimestampOutOfRange.Error())
|
|
}
|
|
return nil, errors.Wrap(err, "converting TimestampField from layout")
|
|
}
|
|
if err := validateTimestamp(t.granularity(), ts); err != nil {
|
|
return nil, errors.Wrap(ErrTimestampOutOfRange, "validating timestamp")
|
|
}
|
|
|
|
tsAsVal := TimestampToVal(t.granularity(), ts)
|
|
|
|
dur = tsAsVal - epochAsVal
|
|
} else {
|
|
valAsInt, err := toInt64(val)
|
|
if err != nil {
|
|
if strings.Contains(err.Error(), "out of range") {
|
|
return nil, errors.Wrap(err, ErrTimestampOutOfRange.Error())
|
|
}
|
|
return nil, errors.Wrap(err, "converting value to int64")
|
|
}
|
|
|
|
// Conversion ratio to scale incoming Units to Granularity
|
|
granNanos, err := Unit(t.granularity()).ToNanos()
|
|
if err != nil || granNanos == 0 {
|
|
return nil, errors.Wrap(err, "granularity not supported")
|
|
}
|
|
unitNanos, err := Unit(t.Unit).ToNanos()
|
|
if err != nil {
|
|
return nil, errors.Wrap(err, "unit not supported")
|
|
}
|
|
scale := float64(unitNanos) / float64(granNanos)
|
|
|
|
dur = int64(float64(valAsInt) * scale)
|
|
if (dur >= 0 && valAsInt < 0) || (dur < 0 && valAsInt > 0) {
|
|
return nil, errors.Wrap(ErrTimestampOutOfRange, "timestamp value out of range at specified granularity")
|
|
}
|
|
|
|
if err := validateDuration(dur, epochAsVal, Unit(t.granularity())); err != nil {
|
|
return nil, errors.Wrap(err, "validating duration")
|
|
}
|
|
}
|
|
|
|
return dur, nil
|
|
}
|
|
|
|
// validateTimestamp checks if the timestamp is within the range of what FB accepts.
|
|
func validateTimestamp(unit Unit, ts time.Time) error {
|
|
// Min and Max timestamps that Featurebase accepts
|
|
var minStamp, maxStamp time.Time
|
|
switch unit {
|
|
case Nanosecond:
|
|
minStamp = MinTimestampNano
|
|
maxStamp = MaxTimestampNano
|
|
default:
|
|
minStamp = MinTimestamp
|
|
maxStamp = MaxTimestamp
|
|
}
|
|
|
|
if ts.Before(minStamp) || ts.After(maxStamp) {
|
|
return errors.New(fmt.Sprintf("timestamp value must be within min: %v and max: %v", minStamp, maxStamp))
|
|
}
|
|
return nil
|
|
}
|
|
|
|
// validateDuration checks if the duration will overflow. Users can provide a custom epoch but
|
|
// Featurebase will ultimately convert this to some duration relative to the Unix epoch.
|
|
// So if the custom epoch + the provided value in the desired units is too far from
|
|
// Unix epoch such that it causes an interger overflow, this will return an error.
|
|
func validateDuration(dur int64, offset int64, granularity Unit) error {
|
|
var minInt, maxInt int64
|
|
switch granularity {
|
|
case Second:
|
|
minInt = MinTimestamp.Unix()
|
|
maxInt = MaxTimestamp.Unix()
|
|
case Millisecond:
|
|
minInt = MinTimestamp.UnixMilli()
|
|
maxInt = MaxTimestamp.UnixMilli()
|
|
case Microsecond:
|
|
minInt = MinTimestamp.UnixMicro()
|
|
maxInt = MaxTimestamp.UnixMicro()
|
|
case Nanosecond:
|
|
minInt = MinTimestampNano.UnixNano()
|
|
maxInt = MaxTimestampNano.UnixNano()
|
|
}
|
|
|
|
if offset > 0 {
|
|
if dur > maxInt-offset {
|
|
return errors.Wrap(ErrTimestampOutOfRange, "value + epoch is too far from Unix epoch")
|
|
}
|
|
} else if dur < minInt-offset {
|
|
return errors.Wrap(ErrTimestampOutOfRange, "value + epoch is too far from Unix epoch")
|
|
}
|
|
return nil
|
|
}
|
|
|
|
// Return default granularity if not set
|
|
func (t TimestampField) granularity() Unit {
|
|
if t.Granularity == "" {
|
|
return "s"
|
|
}
|
|
return Unit(t.Granularity)
|
|
}
|
|
|
|
// Return default layout if not set
|
|
func (t TimestampField) layout() string {
|
|
if t.Layout == "" {
|
|
return time.RFC3339Nano
|
|
}
|
|
return t.Layout
|
|
}
|
|
|
|
// Return default epoch if not set
|
|
func (t TimestampField) epoch() time.Time {
|
|
if t.Epoch.IsZero() {
|
|
return time.Unix(0, 0)
|
|
}
|
|
return t.Epoch
|
|
}
|
|
|
|
type DateIntField struct {
|
|
NameVal string
|
|
DestNameVal string
|
|
Layout string
|
|
Epoch time.Time
|
|
Unit Unit
|
|
CustomUnit string
|
|
}
|
|
|
|
func (d DateIntField) Name() string { return d.NameVal }
|
|
func (d DateIntField) DestName() string {
|
|
if d.DestNameVal == "" {
|
|
return d.NameVal
|
|
}
|
|
|
|
return d.DestNameVal
|
|
}
|
|
|
|
// PilosafyVal for a DateIntField takes a time.Time and int64 which
|
|
// represents the number units from the epoch.
|
|
func (d DateIntField) PilosafyVal(val interface{}) (interface{}, error) {
|
|
var vt time.Time
|
|
var err error
|
|
switch valt := val.(type) {
|
|
case nil:
|
|
return nil, nil
|
|
case []byte:
|
|
if len(valt) == 0 {
|
|
return nil, nil
|
|
}
|
|
vt, err = parseTimeWithLayout(d.layout(), string(valt))
|
|
if err != nil {
|
|
return nil, errors.Wrap(err, "converting DateIntField []byte")
|
|
}
|
|
case string:
|
|
vt, err = parseTimeWithLayout(d.layout(), valt)
|
|
if err != nil {
|
|
return nil, errors.Wrap(err, "converting DateIntField string")
|
|
}
|
|
case time.Time:
|
|
vt = valt
|
|
case uint, int, uint8, uint16, uint32, uint64, int8, int16, int32, int64:
|
|
return toInt64(valt)
|
|
default:
|
|
return nil, errors.Errorf("didn't know how to handle %v of type %[1]T in DateIntField", valt)
|
|
}
|
|
|
|
dur := vt.Sub(d.epoch())
|
|
|
|
var unit time.Duration
|
|
if d.Unit.IsCustom() {
|
|
if unit, err = time.ParseDuration(d.CustomUnit); err != nil {
|
|
return nil, errors.Wrapf(err, "parsing custom unit %s", d.CustomUnit)
|
|
}
|
|
} else {
|
|
if unit, err = d.Unit.Duration(); err != nil {
|
|
return nil, errors.Wrapf(err, "parsing unit %s", d.Unit)
|
|
}
|
|
}
|
|
|
|
return int64(dur / unit), nil
|
|
}
|
|
|
|
func (d DateIntField) epoch() time.Time {
|
|
if d.Epoch.IsZero() {
|
|
return time.Unix(0, 0)
|
|
}
|
|
return d.Epoch
|
|
}
|
|
|
|
func (d DateIntField) layout() string {
|
|
if d.Layout == "" {
|
|
// this is kind of a ridiculous default for layout
|
|
return "2006-01-02"
|
|
}
|
|
return d.Layout
|
|
}
|
|
|
|
func parseTimeWithLayout(layout string, val string) (time.Time, error) {
|
|
if val == "0000-00-00" { // TODO this is kind of a special hack
|
|
// that we should remove - was added
|
|
// for a particular case of unparsable
|
|
// data that we wanted to ignore.
|
|
return time.Time{}, nil
|
|
}
|
|
tim, err := time.Parse(layout, val)
|
|
if err != nil {
|
|
return time.Time{}, errors.Wrapf(err, "parsing time string %s", val)
|
|
}
|
|
return tim, nil
|
|
}
|
|
|
|
func timeFromEpoch(val interface{}, epoch time.Time, unit Unit) (interface{}, error) {
|
|
valAsInt, err := toInt64(val)
|
|
if err != nil {
|
|
return nil, errors.Wrap(err, "converting value to int64")
|
|
}
|
|
|
|
dur, err := unit.DurationFromValue(valAsInt)
|
|
if err != nil {
|
|
return nil, errors.Wrap(err, "getting duration from value")
|
|
}
|
|
|
|
return epoch.Add(dur), err
|
|
}
|
|
|
|
func timeFromTimestring(val interface{}, layout string) (time.Time, error) {
|
|
if val == nil {
|
|
return time.Time{}, nil
|
|
}
|
|
switch valt := val.(type) {
|
|
case nil:
|
|
return time.Time{}, nil
|
|
case []byte:
|
|
if len(valt) == 0 {
|
|
return time.Time{}, nil
|
|
}
|
|
vt, err := parseTimeWithLayout(layout, string(valt))
|
|
if err != nil {
|
|
return time.Time{}, errors.Wrap(err, "parsing []byte")
|
|
}
|
|
return vt, nil
|
|
case string:
|
|
if valt == "" {
|
|
return time.Time{}, nil
|
|
}
|
|
vt, err := parseTimeWithLayout(layout, valt)
|
|
if err != nil {
|
|
return time.Time{}, errors.Wrapf(err, "parsing time string %s", valt)
|
|
}
|
|
return vt, nil
|
|
case time.Time:
|
|
return valt, nil
|
|
default:
|
|
return time.Time{}, errors.Errorf("didn't know how to interpret %v of %[1]T as time", valt)
|
|
}
|
|
}
|
|
|
|
func toUint64(val interface{}) (uint64, error) {
|
|
switch vt := val.(type) {
|
|
case uint:
|
|
return uint64(vt), nil
|
|
case uint8:
|
|
return uint64(vt), nil
|
|
case uint16:
|
|
return uint64(vt), nil
|
|
case uint32:
|
|
return uint64(vt), nil
|
|
case uint64:
|
|
return vt, nil
|
|
case int:
|
|
return uint64(vt), nil
|
|
case int8:
|
|
return uint64(vt), nil
|
|
case int16:
|
|
return uint64(vt), nil
|
|
case int32:
|
|
return uint64(vt), nil
|
|
case int64:
|
|
return uint64(vt), nil
|
|
case float64:
|
|
return uint64(vt), nil
|
|
case string:
|
|
v, err := strconv.ParseUint(strings.TrimSpace(vt), 10, 64)
|
|
if err != nil {
|
|
return 0, err
|
|
}
|
|
return v, nil
|
|
default:
|
|
return 0, errors.Errorf("couldn't convert %v of %[1]T to uint64", vt)
|
|
}
|
|
}
|
|
|
|
func toBool(val interface{}) (bool, error) {
|
|
switch vt := val.(type) {
|
|
case bool:
|
|
return vt, nil
|
|
case byte:
|
|
if vt == '0' || vt == 'f' || vt == 'F' {
|
|
return false, nil
|
|
}
|
|
return vt != 0, nil
|
|
case string:
|
|
vt = strings.ToLower(vt)
|
|
vt = strings.TrimSpace(vt)
|
|
switch vt {
|
|
case "", "0", "f", "false":
|
|
return false, nil
|
|
case "1", "t", "true":
|
|
return true, nil
|
|
}
|
|
return false, errors.Errorf("couldn't convert %v of %[1]T to bool", vt)
|
|
|
|
default:
|
|
if vint, err := toInt64(val); err == nil {
|
|
return vint != 0, nil
|
|
}
|
|
return false, errors.Errorf("couldn't convert %v of %[1]T to bool", vt)
|
|
}
|
|
}
|
|
|
|
func toString(val interface{}) (string, error) {
|
|
switch vt := val.(type) {
|
|
case string:
|
|
return vt, nil
|
|
case []byte:
|
|
return string(vt), nil
|
|
default:
|
|
if vt == nil {
|
|
return "", nil
|
|
}
|
|
return fmt.Sprintf("%v", val), nil
|
|
}
|
|
}
|
|
|
|
func toInt64(val interface{}) (int64, error) {
|
|
switch vt := val.(type) {
|
|
case uint:
|
|
return int64(vt), nil
|
|
case uint8:
|
|
return int64(vt), nil
|
|
case uint16:
|
|
return int64(vt), nil
|
|
case uint32:
|
|
return int64(vt), nil
|
|
case uint64:
|
|
return int64(vt), nil
|
|
case int:
|
|
return int64(vt), nil
|
|
case int8:
|
|
return int64(vt), nil
|
|
case int16:
|
|
return int64(vt), nil
|
|
case int32:
|
|
return int64(vt), nil
|
|
case int64:
|
|
return vt, nil
|
|
case float32:
|
|
return int64(vt), nil
|
|
case float64:
|
|
return int64(vt), nil
|
|
case string: // added this case because of mysql driver sending the ids as strings
|
|
v, err := strconv.ParseInt(strings.TrimSpace(vt), 10, 64)
|
|
if err != nil {
|
|
return 0, err
|
|
}
|
|
return v, nil
|
|
default:
|
|
return 0, errors.Errorf("couldn't convert %v of %[1]T to int64", vt)
|
|
}
|
|
}
|
|
|
|
func toStringArray(val interface{}) ([]string, error) {
|
|
switch vt := val.(type) {
|
|
case []string:
|
|
return vt, nil
|
|
case []uint64:
|
|
ret := make([]string, len(vt))
|
|
for i, v := range vt {
|
|
ret[i] = strconv.FormatUint(v, 10)
|
|
}
|
|
return ret, nil
|
|
case map[uint64]struct{}:
|
|
arr, err := toUint64Array(val)
|
|
if err != nil {
|
|
return nil, err
|
|
}
|
|
return toStringArray(arr)
|
|
case string:
|
|
if vt == "" {
|
|
return nil, nil
|
|
}
|
|
if strings.HasPrefix(vt, "[") && strings.HasSuffix(vt, "]") {
|
|
vt = vt[1 : len(vt)-1]
|
|
}
|
|
vals := strings.Split(vt, ",")
|
|
return vals, nil
|
|
case []interface{}:
|
|
ret := make([]string, len(vt))
|
|
for i, v := range vt {
|
|
vs, ok := v.(string)
|
|
if !ok {
|
|
return nil, errors.Errorf("couldn't convert []interface{} to []string, value %v of type %[1]T at %d", v, i)
|
|
}
|
|
ret[i] = vs
|
|
}
|
|
return ret, nil
|
|
default:
|
|
return nil, errors.Errorf("couldn't convert %v of %[1]T to []string", vt)
|
|
}
|
|
}
|
|
|
|
func toUint64Array(val interface{}) ([]uint64, error) {
|
|
switch vt := val.(type) {
|
|
case []interface{}:
|
|
if len(vt) == 0 {
|
|
// Empty/nil set.
|
|
return nil, nil
|
|
}
|
|
arr := make([]uint64, len(vt))
|
|
for i := range vt {
|
|
vv, err := toUint64(vt[i])
|
|
if err != nil {
|
|
return nil, errors.Wrapf(err, "non uint64 value in []interface{}: %v (%[1]T)", vt[i])
|
|
}
|
|
arr[i] = vv
|
|
}
|
|
return arr, nil
|
|
case map[uint64]struct{}:
|
|
if len(vt) == 0 {
|
|
// Empty/nil set.
|
|
return nil, nil
|
|
}
|
|
arr := make([]uint64, len(vt))
|
|
i := 0
|
|
for v := range vt {
|
|
arr[i] = v
|
|
i++
|
|
}
|
|
|
|
// Move the elements into a deterministic order.
|
|
sort.Slice(arr, func(i, j int) bool { return arr[i] < arr[j] })
|
|
|
|
return arr, nil
|
|
case []uint64:
|
|
return vt, nil
|
|
case string:
|
|
if vt == "" {
|
|
return nil, nil
|
|
}
|
|
if strings.HasPrefix(vt, "[") && strings.HasSuffix(vt, "]") {
|
|
vt = vt[1 : len(vt)-1]
|
|
}
|
|
parts := strings.Split(vt, ",")
|
|
ret := make([]uint64, len(parts))
|
|
for i := range parts {
|
|
v, err := strconv.ParseUint(strings.TrimSpace(parts[i]), 10, 64)
|
|
if err != nil {
|
|
return nil, errors.Wrapf(err, "parsing uint64 from string: %s", vt)
|
|
}
|
|
ret[i] = v
|
|
}
|
|
return ret, nil
|
|
default:
|
|
return nil, errors.Errorf("couldn't convert %v of %[1]T to []uint64", vt)
|
|
}
|
|
}
|
|
|
|
// Fields is a list of Field, representing a schema.
|
|
type Fields []Field
|
|
|
|
// ContainsBool returns true if at least one field
|
|
// in the list is a BoolField.
|
|
func (f Fields) ContainsBool() bool {
|
|
for i := range f {
|
|
if _, ok := f[i].(BoolField); ok {
|
|
return true
|
|
}
|
|
}
|
|
return false
|
|
}
|
|
|
|
// SchemaManager is meant to be an interface for managing schema information;
|
|
// i.e. for interacting with a single source of truth for schema information,
|
|
// like the MDS Schemar. But... it currently contains methods which are not
|
|
// related to schema because the first goal was just to introduce an interface
|
|
// in ingest.go for any methods being called on *m.client. We don't want a
|
|
// FeatureBase client directly called from ingest, rather, we want to call these
|
|
// interface methods and allow for different implementations (such as an MDS
|
|
// implementation which uses the Schemar in MDS as opposed to a FeatureBase node
|
|
// or cluster).
|
|
type SchemaManager interface {
|
|
StartTransaction(id string, timeout time.Duration, exclusive bool, requestTimeout time.Duration) (*pilosacore.Transaction, error)
|
|
FinishTransaction(id string) (*pilosacore.Transaction, error)
|
|
Schema() (*pilosaclient.Schema, error)
|
|
SyncIndex(index *pilosaclient.Index) error
|
|
DeleteIndex(index *pilosaclient.Index) error
|
|
Status() (pilosaclient.Status, error)
|
|
SetAuthToken(string)
|
|
}
|
|
|
|
// Ensure type implements interface.
|
|
var _ SchemaManager = &nopSchemaManager{}
|
|
|
|
// NopSchemaManager is an implementation of the SchemaManager interface that
|
|
// doesn't do anything.
|
|
var NopSchemaManager SchemaManager = &nopSchemaManager{}
|
|
|
|
type nopSchemaManager struct{}
|
|
|
|
func (n *nopSchemaManager) StartTransaction(id string, timeout time.Duration, exclusive bool, requestTimeout time.Duration) (*pilosacore.Transaction, error) {
|
|
return nil, nil
|
|
}
|
|
func (n *nopSchemaManager) FinishTransaction(id string) (*pilosacore.Transaction, error) {
|
|
return nil, nil
|
|
}
|
|
func (n *nopSchemaManager) Schema() (*pilosaclient.Schema, error) {
|
|
return nil, nil
|
|
}
|
|
func (n *nopSchemaManager) SyncIndex(index *pilosaclient.Index) error {
|
|
return nil
|
|
}
|
|
func (n *nopSchemaManager) DeleteIndex(index *pilosaclient.Index) error {
|
|
return nil
|
|
}
|
|
func (n *nopSchemaManager) Status() (pilosaclient.Status, error) {
|
|
return pilosaclient.Status{}, nil
|
|
}
|
|
func (n *nopSchemaManager) SetAuthToken(token string) {}
|