mirror of
https://github.com/featurebasedb/featurebase.git
synced 2026-08-28 10:54:59 +00:00
The "batched" flag creates a complexity which is that the return value of Add might or might not be meaningful, but it doesn't really buy us very much. If we are concerned about the ops log size of writing single ops as 21-byte arrays of 1 op rather than as 13-byte ops, we can make the AddN code smarter about how it writes ops. And probably should. Along with this, change Remove to use the batched operation form, which writes a more meaningful ops log, and return a meaningful value for changes made. Otherwise, it ends up writing potentially thousands of ops to the ops log without reporting any OpN, because the number of ops written isn't the same as the number of changes those ops made. This could result in files growing by megabytes without OpN changing. There was a comment here about a test failing with RemoveN. I can't prove it, but I strongly suspect that this was actually a result of that test case hitting a particular bug that we eventually fixed, and which we might have fixed sooner if we'd realized why using RemoveN made that test fail.
556 lines
15 KiB
Go
556 lines
15 KiB
Go
// Copyright 2017 Pilosa Corp.
|
|
//
|
|
// Licensed under the Apache License, Version 2.0 (the "License");
|
|
// you may not use this file except in compliance with the License.
|
|
// You may obtain a copy of the License at
|
|
//
|
|
// http://www.apache.org/licenses/LICENSE-2.0
|
|
//
|
|
// Unless required by applicable law or agreed to in writing, software
|
|
// distributed under the License is distributed on an "AS IS" BASIS,
|
|
// WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
|
|
// See the License for the specific language governing permissions and
|
|
// limitations under the License.
|
|
|
|
package pilosa
|
|
|
|
import (
|
|
"bytes"
|
|
"fmt"
|
|
"io"
|
|
"io/ioutil"
|
|
"math"
|
|
"os"
|
|
"sort"
|
|
"strings"
|
|
"sync"
|
|
"sync/atomic"
|
|
|
|
"github.com/pilosa/pilosa/v2/rbf"
|
|
rbfcfg "github.com/pilosa/pilosa/v2/rbf/cfg"
|
|
"github.com/pilosa/pilosa/v2/roaring"
|
|
txkey "github.com/pilosa/pilosa/v2/short_txkey"
|
|
|
|
//txkey "github.com/pilosa/pilosa/v2/txkey"
|
|
"github.com/pkg/errors"
|
|
)
|
|
|
|
// RbfDBWrapper wraps an *rbf.DB
|
|
type RbfDBWrapper struct {
|
|
path string
|
|
db *rbf.DB
|
|
cfg *rbfcfg.Config
|
|
reg *rbfDBRegistrar
|
|
muDb sync.Mutex
|
|
|
|
openTx map[*RBFTx]bool
|
|
|
|
// make Close() idempotent, avoiding panic on double Close()
|
|
closed bool
|
|
|
|
//DeleteEmptyContainer bool // needed for roaring compat?
|
|
|
|
doAllocZero bool
|
|
}
|
|
|
|
func (w *RbfDBWrapper) Path() string {
|
|
return w.path
|
|
}
|
|
|
|
func (w *RbfDBWrapper) SetHolder(h *Holder) {
|
|
// don't need it at the moment
|
|
//w.h = h
|
|
}
|
|
|
|
func (w *RbfDBWrapper) CleanupTx(tx Tx) {
|
|
r := tx.(*RBFTx)
|
|
r.mu.Lock()
|
|
if r.done {
|
|
r.mu.Unlock()
|
|
return
|
|
}
|
|
r.done = true
|
|
r.mu.Unlock()
|
|
|
|
// try not to hold r.mu while locking w.muDb
|
|
w.muDb.Lock()
|
|
|
|
delete(w.openTx, r)
|
|
//vv("rbf CleanupTx gid %v about to call r.o.dbs.Cleanup(tx.Sn=%v)", curGID(), tx.Sn())
|
|
r.o.dbs.Cleanup(tx) // release the read/write lock.
|
|
|
|
w.muDb.Unlock()
|
|
}
|
|
|
|
// rbfDBRegistrar also allows opening the same path twice to
|
|
// result in sharing the same open database handle, and
|
|
// thus the same transactional guarantees.
|
|
//
|
|
type rbfDBRegistrar struct {
|
|
mu sync.Mutex
|
|
mp map[*RbfDBWrapper]bool
|
|
|
|
path2db map[string]*RbfDBWrapper
|
|
}
|
|
|
|
func (r *rbfDBRegistrar) Size() int {
|
|
r.mu.Lock()
|
|
defer r.mu.Unlock()
|
|
nmp := len(r.mp)
|
|
npa := len(r.path2db)
|
|
if nmp != npa {
|
|
panic(fmt.Sprintf("nmp=%v, vs npa=%v", nmp, npa))
|
|
}
|
|
return nmp
|
|
}
|
|
|
|
var globalRbfDBReg *rbfDBRegistrar = newRbfDBRegistrar()
|
|
|
|
func newRbfDBRegistrar() *rbfDBRegistrar {
|
|
return &rbfDBRegistrar{
|
|
mp: make(map[*RbfDBWrapper]bool),
|
|
path2db: make(map[string]*RbfDBWrapper),
|
|
}
|
|
}
|
|
|
|
// register each rbf.DB created, so we dedup and can
|
|
// can clean them up. This is called by OpenDBWrapper() while
|
|
// holding the r.mu.Lock, since it needs to atomically
|
|
// check the registry and make a new instance only
|
|
// if one does not exist for its path, and otherwise
|
|
// return the existing instance.
|
|
func (r *rbfDBRegistrar) unprotectedRegister(w *RbfDBWrapper) {
|
|
r.mp[w] = true
|
|
r.path2db[w.path] = w
|
|
}
|
|
|
|
// unregister removes w from r
|
|
func (r *rbfDBRegistrar) unregister(w *RbfDBWrapper) {
|
|
r.mu.Lock()
|
|
delete(r.mp, w)
|
|
delete(r.path2db, w.path)
|
|
r.mu.Unlock()
|
|
}
|
|
|
|
// rbfPath is a helper for determining the full directory
|
|
// in which the RBF database will be stored.
|
|
func rbfPath(path string) string {
|
|
if !strings.HasSuffix(path, "-rbfdb@") {
|
|
return path + "-rbfdb@"
|
|
}
|
|
return path
|
|
}
|
|
|
|
// OpenDBWrapper opens the database in the path directoy
|
|
// without deleting any prior content. Any
|
|
// database directory will have the "-rbfdb@" suffix.
|
|
//
|
|
// OpenDBWrapper will check the registry and make a new instance only
|
|
// if one does not exist for its path. Otherwise it returns
|
|
// the existing instance. This insures only one RbfDBWrapper
|
|
// per bpath in this pilosa node.
|
|
func (r *rbfDBRegistrar) OpenDBWrapper(path0 string, doAllocZero bool, cfg *rbfcfg.Config) (DBWrapper, error) {
|
|
path := rbfPath(path0)
|
|
r.mu.Lock()
|
|
defer r.mu.Unlock()
|
|
w, ok := r.path2db[path]
|
|
if ok {
|
|
// creates the effect of having only one DB open per pilosa node.
|
|
return w, nil
|
|
}
|
|
if cfg == nil {
|
|
cfg = rbfcfg.NewDefaultConfig()
|
|
cfg.DoAllocZero = doAllocZero
|
|
}
|
|
db := rbf.NewDB(path, cfg)
|
|
|
|
w = &RbfDBWrapper{
|
|
reg: r,
|
|
path: path,
|
|
db: db,
|
|
doAllocZero: doAllocZero,
|
|
openTx: make(map[*RBFTx]bool),
|
|
cfg: cfg,
|
|
}
|
|
r.unprotectedRegister(w)
|
|
|
|
err := db.Open()
|
|
if err != nil {
|
|
panic(fmt.Sprintf("cannot open rbfDB at path '%v': '%v'", path, err))
|
|
}
|
|
return w, nil
|
|
}
|
|
|
|
type RBFTx struct {
|
|
// initialIndex is only a debugging aid. Transactions
|
|
// can cross indexes. It can be left empty without consequence.
|
|
initialIndex string
|
|
frag *fragment
|
|
tx *rbf.Tx
|
|
o Txo
|
|
sn int64 // serial number
|
|
Db *RbfDBWrapper
|
|
|
|
done bool
|
|
mu sync.Mutex // protect done as it changes state
|
|
}
|
|
|
|
func (tx *RBFTx) IsDone() (done bool) {
|
|
tx.mu.Lock()
|
|
done = tx.done
|
|
tx.mu.Unlock()
|
|
return
|
|
}
|
|
|
|
func (tx *RBFTx) DBPath() string {
|
|
return tx.tx.DBPath()
|
|
}
|
|
|
|
func (tx *RBFTx) Type() string {
|
|
return RBFTxn
|
|
}
|
|
|
|
func (tx *RBFTx) Rollback() {
|
|
tx.tx.Rollback()
|
|
|
|
// must happen after actual rollback
|
|
tx.Db.CleanupTx(tx)
|
|
}
|
|
|
|
func (tx *RBFTx) Commit() (err error) {
|
|
err = tx.tx.Commit()
|
|
|
|
// must happen after actual commit
|
|
tx.Db.CleanupTx(tx)
|
|
return
|
|
}
|
|
|
|
func (tx *RBFTx) RoaringBitmap(index, field, view string, shard uint64) (*roaring.Bitmap, error) {
|
|
return tx.tx.RoaringBitmap(rbfName(index, field, view, shard))
|
|
}
|
|
|
|
func (tx *RBFTx) Container(index, field, view string, shard uint64, key uint64) (*roaring.Container, error) {
|
|
return tx.tx.Container(rbfName(index, field, view, shard), key)
|
|
}
|
|
|
|
func (tx *RBFTx) PutContainer(index, field, view string, shard uint64, key uint64, c *roaring.Container) error {
|
|
return tx.tx.PutContainer(rbfName(index, field, view, shard), key, c)
|
|
}
|
|
|
|
func (tx *RBFTx) RemoveContainer(index, field, view string, shard uint64, key uint64) error {
|
|
return tx.tx.RemoveContainer(rbfName(index, field, view, shard), key)
|
|
}
|
|
|
|
// Add sets all the a bits hot in the specified fragment.
|
|
func (tx *RBFTx) Add(index, field, view string, shard uint64, a ...uint64) (changeCount int, err error) {
|
|
return tx.addOrRemove(index, field, view, shard, false, a...)
|
|
}
|
|
|
|
// Remove clears all the specified a bits in the chosen fragment.
|
|
func (tx *RBFTx) Remove(index, field, view string, shard uint64, a ...uint64) (changeCount int, err error) {
|
|
return tx.addOrRemove(index, field, view, shard, true, a...)
|
|
}
|
|
|
|
func (tx *RBFTx) addOrRemove(index, field, view string, shard uint64, remove bool, a ...uint64) (changeCount int, err error) {
|
|
if len(a) == 0 {
|
|
return 0, nil
|
|
}
|
|
|
|
// have to sort, b/c input is not always sorted.
|
|
sort.Slice(a, func(i, j int) bool { return a[i] < a[j] })
|
|
|
|
var lastHi uint64 = math.MaxUint64 // highbits is always less than this starter.
|
|
var rc *roaring.Container
|
|
var hi uint64
|
|
var lo uint16
|
|
|
|
for i, v := range a {
|
|
|
|
hi, lo = highbits(v), lowbits(v)
|
|
if hi != lastHi {
|
|
// either first time through, or changed to a different container.
|
|
// do we need put the last updated container now?
|
|
if i > 0 {
|
|
// not first time through, write what we got.
|
|
if remove && (rc == nil || rc.N() == 0) {
|
|
err = tx.RemoveContainer(index, field, view, shard, lastHi)
|
|
panicOn(err)
|
|
} else {
|
|
err = tx.PutContainer(index, field, view, shard, lastHi, rc)
|
|
panicOn(err)
|
|
}
|
|
}
|
|
// get the next container
|
|
rc, err = tx.Container(index, field, view, shard, hi)
|
|
panicOn(err)
|
|
} // else same container, keep adding bits to rct.
|
|
chng := false
|
|
// rc can be nil before, and nil after, in both Remove/Add below.
|
|
// The roaring container add() and remove() methods handle this.
|
|
if remove {
|
|
rc, chng = rc.Remove(lo)
|
|
} else {
|
|
rc, chng = rc.Add(lo)
|
|
}
|
|
if chng {
|
|
changeCount++
|
|
}
|
|
lastHi = hi
|
|
}
|
|
// write the last updates.
|
|
if remove {
|
|
if rc == nil || rc.N() == 0 {
|
|
err = tx.RemoveContainer(index, field, view, shard, hi)
|
|
panicOn(err)
|
|
} else {
|
|
err = tx.PutContainer(index, field, view, shard, hi, rc)
|
|
panicOn(err)
|
|
}
|
|
} else {
|
|
if rc == nil || rc.N() == 0 {
|
|
panic("there should be no way to have an empty bitmap AFTER an Add() operation")
|
|
}
|
|
err = tx.PutContainer(index, field, view, shard, hi, rc)
|
|
panicOn(err)
|
|
}
|
|
return
|
|
}
|
|
|
|
func (tx *RBFTx) Contains(index, field, view string, shard uint64, v uint64) (exists bool, err error) {
|
|
return tx.tx.Contains(rbfName(index, field, view, shard), v)
|
|
}
|
|
|
|
func (tx *RBFTx) ContainerIterator(index, field, view string, shard uint64, key uint64) (citer roaring.ContainerIterator, found bool, err error) {
|
|
return tx.tx.ContainerIterator(rbfName(index, field, view, shard), key)
|
|
}
|
|
|
|
func (tx *RBFTx) ForEach(index, field, view string, shard uint64, fn func(i uint64) error) error {
|
|
return tx.tx.ForEach(rbfName(index, field, view, shard), fn)
|
|
}
|
|
|
|
func (tx *RBFTx) ForEachRange(index, field, view string, shard uint64, start, end uint64, fn func(uint64) error) error {
|
|
return tx.tx.ForEachRange(rbfName(index, field, view, shard), start, end, fn)
|
|
}
|
|
|
|
func (tx *RBFTx) Count(index, field, view string, shard uint64) (uint64, error) {
|
|
return tx.tx.Count(rbfName(index, field, view, shard))
|
|
}
|
|
|
|
func (tx *RBFTx) Max(index, field, view string, shard uint64) (uint64, error) {
|
|
return tx.tx.Max(rbfName(index, field, view, shard))
|
|
}
|
|
|
|
func (tx *RBFTx) Min(index, field, view string, shard uint64) (uint64, bool, error) {
|
|
return tx.tx.Min(rbfName(index, field, view, shard))
|
|
}
|
|
|
|
func (tx *RBFTx) UnionInPlace(index, field, view string, shard uint64, others ...*roaring.Bitmap) error {
|
|
return tx.tx.UnionInPlace(rbfName(index, field, view, shard), others...)
|
|
}
|
|
|
|
// CountRange returns the count of hot bits in the start, end range on the fragment.
|
|
// roaring.countRange counts the number of bits set between [start, end).
|
|
func (tx *RBFTx) CountRange(index, field, view string, shard uint64, start, end uint64) (n uint64, err error) {
|
|
return tx.tx.CountRange(rbfName(index, field, view, shard), start, end)
|
|
}
|
|
|
|
func (tx *RBFTx) OffsetRange(index, field, view string, shard uint64, offset, start, end uint64) (*roaring.Bitmap, error) {
|
|
return tx.tx.OffsetRange(rbfName(index, field, view, shard), offset, start, end)
|
|
}
|
|
|
|
func (tx *RBFTx) IncrementOpN(index, field, view string, shard uint64, changedN int) {}
|
|
|
|
func (tx *RBFTx) ImportRoaringBits(index, field, view string, shard uint64, rit roaring.RoaringIterator, clear bool, log bool, rowSize uint64, data []byte) (changed int, rowSet map[uint64]int, err error) {
|
|
return tx.tx.ImportRoaringBits(rbfName(index, field, view, shard), rit, clear, log, rowSize, data)
|
|
}
|
|
|
|
func (tx *RBFTx) RoaringBitmapReader(index, field, view string, shard uint64, fragmentPathForRoaring string) (r io.ReadCloser, sz int64, err error) {
|
|
|
|
rbm, err := tx.RoaringBitmap(index, field, view, shard)
|
|
if err != nil {
|
|
return nil, -1, errors.Wrap(err, "RoaringBitmapReader RoaringBitmap")
|
|
}
|
|
var buf bytes.Buffer
|
|
sz, err = rbm.WriteTo(&buf)
|
|
if err != nil {
|
|
return nil, -1, errors.Wrap(err, "RoaringBitmapReader rbm.WriteTo(buf)")
|
|
}
|
|
return ioutil.NopCloser(&buf), sz, err
|
|
}
|
|
|
|
func (tx *RBFTx) NewTxIterator(index, field, view string, shard uint64) *roaring.Iterator {
|
|
b, err := tx.RoaringBitmap(index, field, view, shard)
|
|
panicOn(err)
|
|
return b.Iterator()
|
|
}
|
|
|
|
func (tx *RBFTx) Pointer() string {
|
|
return fmt.Sprintf("%p", tx)
|
|
}
|
|
|
|
func (tx *RBFTx) Dump(short bool, shard uint64) {
|
|
tx.tx.Dump(short, shard)
|
|
}
|
|
|
|
// Readonly is true if the transaction is not read-and-write, but only doing reads.
|
|
func (tx *RBFTx) Readonly() bool {
|
|
return !tx.tx.Writable()
|
|
}
|
|
|
|
func (tx *RBFTx) Group() *TxGroup {
|
|
return tx.o.Group
|
|
}
|
|
|
|
func (tx *RBFTx) Options() Txo {
|
|
return tx.o
|
|
}
|
|
|
|
func (tx *RBFTx) Sn() int64 {
|
|
return tx.sn
|
|
}
|
|
|
|
func (tx *RBFTx) UseRowCache() bool {
|
|
// since RFB returns memory mapped data, we can't use
|
|
// the rowCache without first making a copy.
|
|
// So we only use the rowCache if the copy is
|
|
// enabled.
|
|
return rbf.EnableRowCache()
|
|
}
|
|
|
|
func (tx *RBFTx) ApplyFilter(index, field, view string, shard uint64, ckey uint64, filter roaring.BitmapFilter) (err error) {
|
|
return tx.tx.ApplyFilter(rbfName(index, field, view, shard), ckey, filter)
|
|
}
|
|
|
|
func (tx *RBFTx) GetSortedFieldViewList(idx *Index, shard uint64) (fvs []txkey.FieldView, err error) {
|
|
return tx.tx.GetSortedFieldViewList()
|
|
}
|
|
|
|
func (tx *RBFTx) GetFieldSizeBytes(index, field string) (uint64, error) {
|
|
return tx.tx.GetSizeBytesWithPrefix(string(txkey.FieldPrefix(index, field)))
|
|
}
|
|
|
|
// rbfName returns a NULL-separated key used for identifying bitmap maps in RBF.
|
|
func rbfName(index, field, view string, shard uint64) string {
|
|
return string(txkey.Prefix(index, field, view, shard))
|
|
}
|
|
|
|
// rbfFieldPrefix returns a prefix for field keys in RBF.
|
|
func rbfFieldPrefix(index, field string) string {
|
|
//return fmt.Sprintf("%s\x00%s\x00", index, field)
|
|
return string(txkey.FieldPrefix(index, field))
|
|
}
|
|
|
|
func (w *RbfDBWrapper) HasData() (has bool, err error) {
|
|
w.muDb.Lock()
|
|
defer w.muDb.Unlock()
|
|
return w.db.HasData(false) // false => any prior attempt at write means we "have data"
|
|
}
|
|
|
|
func (w *RbfDBWrapper) DeleteField(index, field, fieldPath string) error {
|
|
w.muDb.Lock()
|
|
defer w.muDb.Unlock()
|
|
|
|
if err := os.RemoveAll(fieldPath); err != nil {
|
|
return errors.Wrap(err, "removing directory")
|
|
}
|
|
|
|
tx, err := w.db.Begin(true)
|
|
if err != nil {
|
|
return err
|
|
}
|
|
defer tx.Rollback()
|
|
|
|
if err := tx.DeleteBitmapsWithPrefix(rbfFieldPrefix(index, field)); err != nil {
|
|
return err
|
|
}
|
|
return tx.Commit()
|
|
}
|
|
|
|
func (w *RbfDBWrapper) DeleteIndex(indexName string) error {
|
|
|
|
if strings.Contains(indexName, "'") {
|
|
return fmt.Errorf("error: bad indexName `%v` in RbfDBWrapper.DeleteIndex() call: indexName cannot contain apostrophes/single quotes.", indexName)
|
|
}
|
|
prefix := txkey.IndexOnlyPrefix(indexName)
|
|
|
|
w.muDb.Lock()
|
|
defer w.muDb.Unlock()
|
|
|
|
tx, err := w.db.Begin(true)
|
|
if err != nil {
|
|
return err
|
|
}
|
|
defer tx.Rollback()
|
|
|
|
if err := tx.DeleteBitmapsWithPrefix(string(prefix)); err != nil {
|
|
return err
|
|
}
|
|
return tx.Commit()
|
|
}
|
|
|
|
func (w *RbfDBWrapper) Close() error {
|
|
w.muDb.Lock()
|
|
defer w.muDb.Unlock()
|
|
if !w.closed {
|
|
w.reg.unregister(w)
|
|
w.closed = true
|
|
}
|
|
return w.db.Close()
|
|
}
|
|
|
|
var globalNextTxSnRBFTx int64
|
|
|
|
func (w *RbfDBWrapper) NewTx(write bool, initialIndex string, o Txo) (_ Tx, err error) {
|
|
tx, err := w.db.Begin(write)
|
|
if err != nil {
|
|
return nil, err
|
|
}
|
|
sn := atomic.AddInt64(&globalNextTxSnRBFTx, 1)
|
|
|
|
rtx := &RBFTx{
|
|
tx: tx,
|
|
initialIndex: initialIndex,
|
|
frag: o.Fragment,
|
|
o: o,
|
|
sn: sn,
|
|
Db: w,
|
|
}
|
|
|
|
w.muDb.Lock()
|
|
w.openTx[rtx] = true
|
|
w.muDb.Unlock()
|
|
|
|
return rtx, nil
|
|
}
|
|
|
|
func (w *RbfDBWrapper) DeleteFragment(index, field, view string, shard uint64, frag interface{}) error {
|
|
tx, err := w.db.Begin(true)
|
|
if err != nil {
|
|
return err
|
|
}
|
|
defer tx.Rollback()
|
|
|
|
err = tx.DeleteBitmapsWithPrefix(rbfName(index, field, view, shard))
|
|
if err != nil {
|
|
return err
|
|
}
|
|
return tx.Commit()
|
|
}
|
|
|
|
func (w *RbfDBWrapper) DeleteDBPath(dbs *DBShard) error {
|
|
path := dbs.pathForType(rbfTxn)
|
|
return os.RemoveAll(path)
|
|
}
|
|
|
|
func (w *RbfDBWrapper) OpenListString() (r string) {
|
|
return "rbf OpenListString not implemented yet"
|
|
}
|
|
|
|
func (w *RbfDBWrapper) OpenSnList() (slc []int64) {
|
|
w.muDb.Lock()
|
|
for v := range w.openTx {
|
|
slc = append(slc, v.sn)
|
|
}
|
|
w.muDb.Unlock()
|
|
return
|
|
}
|