mirror of
https://github.com/featurebasedb/featurebase.git
synced 2026-08-28 10:54:59 +00:00
932e84b681
We want to distinguish different *kinds* of GroupCounts, so we're making the GroupCounts parent object track its type so we can keep that correct. Adding this to protobuf, etc, then creates some weird behaviors because sometimes we expect []GroupCount, and sometimes we expect *GroupCounts. This implies changes to test cases. Also, the changes to test cases imply that some test cases are probably now wrong; for instance, they're expecting a "sum" column, equal to zero, when no sum was requested. We try to make the encoder handle a []*GroupCount gotten from another node without panicing, and avoid breaking the semantics of the existing messages, renumbering messages or components, etc. Since a previous version, the `.Groups` member has been privatized, and the `.Get()` convenience accessor has been renamed `.Groups()` and is now used consistently in a way that should reduce the risk of nil pointers causing crashes. Also, NewGroupCounts is used in a couple more places. |
||
|---|---|---|
| .. | ||
| clustertests | ||
| test | ||
| internal.go | ||
| LICENSE | ||
| private.pb.go | ||
| private.proto | ||
| public.pb.go | ||
| public.proto | ||