featurebase/sql3
Seebs f4905891d4 unbreak nested joins
It turns out that the problem with nested joins was that we were
trying to cleverly invert them, but that seems to be incorrect and
resulted in incorrect nesting.

The test case for this is
	SELECT * FROM X INNER JOIN Y ON true INNER JOIN Z ON false
this is now parsed as
	(X inner join Y on true) inner join z on false

Which, as it turns out, is the structure that stringizes back to the
original statement.

We were previously parsing it as
	X inner join (y inner join z on false) on true
which stringizes out to a different form, and is also, I think,
just straightforwardly not what we want.

So basically, we had special case code to recognize that we
were doing a join on top of another join, and invert them in
some way, and I have no idea why because that seems not to be
correct, or at least, it produces nonsensical stringizing that
we can't then parse.
2023-03-27 16:56:29 -05:00
..
parser unbreak nested joins 2023-03-27 16:56:29 -05:00
planner handle null results gracefully in SetContains{Any,All} 2023-03-24 16:01:09 -05:00
test Add SQL3 test coverage for expressionagg.go (#2351) 2023-03-27 12:00:47 -05:00
errors.go fb-2036 improve coverage for create view statement (#2333) 2023-03-21 14:06:38 -04:00
interfaces.go introduce performance counters and system table fanout, plus refactor metrics (#2363) 2023-01-19 21:35:02 +00:00
main_test.go added testify dependency 2022-09-30 11:31:37 -07:00
sql_complex_test.go support null/non-null tests for non-BSI fields 2023-03-24 16:01:09 -05:00
sql_test.go forward-port tests from SQL1 tree (#2261) 2023-03-01 13:40:50 -06:00