mirror of
https://github.com/featurebasedb/featurebase.git
synced 2026-08-28 02:44:59 +00:00
b6ae088f24
stdout/stderr around
A lot of functions in the cmd and ctl packages were passing these
around and barely using them. Replaced them with a logger for most
functions. Some functions get an io.Writer instead so that their
tests can find the output they're looking for.
More cleanup on fb-1766: reworked the tests that were using io.Pipe
or os.Pipe to check their results so they now use a bytes.Buffer.
Unexported some variables that didn't need to be exported.
Fixed NewConfigCommand to use the provided stderr, not os.Stderr.
Added tests for rbf_dump, rbf_page, and keygen, since those weren't
being tested at all.
Added chksum_test, final cleanup.
(cherry picked from commit f627199acb)
52 lines
1.3 KiB
Go
52 lines
1.3 KiB
Go
package ctl
|
|
|
|
import (
|
|
"context"
|
|
"errors"
|
|
"io"
|
|
"net/http"
|
|
"os"
|
|
"strings"
|
|
"testing"
|
|
|
|
"github.com/molecula/featurebase/v3/logger"
|
|
"github.com/molecula/featurebase/v3/test"
|
|
)
|
|
|
|
func TestRestoreTarCommand_Run(t *testing.T) {
|
|
cluster := test.MustRunCluster(t, 1)
|
|
defer cluster.Close()
|
|
cmd := cluster.GetNode(0)
|
|
|
|
cmLog := logger.NewStandardLogger(io.Discard)
|
|
cm := NewRestoreTarCommand(cmLog)
|
|
hostport := cmd.API.Node().URI.HostPort()
|
|
cm.Host = hostport
|
|
cm.Path = ""
|
|
err := cm.Run(context.Background())
|
|
if !errors.Is(err, UsageError) {
|
|
t.Fatalf("expected usage error with empty path, got %v", err)
|
|
}
|
|
cm.Path = "nonexistent-file"
|
|
err = cm.Run(context.Background())
|
|
if _, ok := err.(*os.PathError); !ok {
|
|
t.Fatalf("expected path error with nonexistent path, got %v", err)
|
|
}
|
|
// use stdin
|
|
cm.Path = "-"
|
|
|
|
resp, err := http.DefaultClient.Do(test.MustNewHTTPRequest("POST", "http://"+hostport+"/index/i", strings.NewReader("")))
|
|
if err != nil {
|
|
t.Fatalf("making http request: %v", err)
|
|
}
|
|
resp.Body.Close()
|
|
resp, err = http.DefaultClient.Do(test.MustNewHTTPRequest("POST", "http://"+hostport+"/index/i/field/f", strings.NewReader("")))
|
|
if err != nil {
|
|
t.Fatalf("making http request: %v", err)
|
|
}
|
|
resp.Body.Close()
|
|
|
|
if err := cm.Run(context.Background()); err != nil {
|
|
t.Fatalf("RestoreTarCommand Run error: %s", err)
|
|
}
|
|
}
|