mirror of
https://github.com/featurebasedb/featurebase.git
synced 2026-08-28 10:54:59 +00:00
b6ae088f24
stdout/stderr around
A lot of functions in the cmd and ctl packages were passing these
around and barely using them. Replaced them with a logger for most
functions. Some functions get an io.Writer instead so that their
tests can find the output they're looking for.
More cleanup on fb-1766: reworked the tests that were using io.Pipe
or os.Pipe to check their results so they now use a bytes.Buffer.
Unexported some variables that didn't need to be exported.
Fixed NewConfigCommand to use the provided stderr, not os.Stderr.
Added tests for rbf_dump, rbf_page, and keygen, since those weren't
being tested at all.
Added chksum_test, final cleanup.
(cherry picked from commit f627199acb)
44 lines
1.2 KiB
Go
44 lines
1.2 KiB
Go
// Copyright 2022 Molecula Corp. All rights reserved.
|
|
package ctl
|
|
|
|
import (
|
|
"bytes"
|
|
"context"
|
|
"os"
|
|
"path/filepath"
|
|
"strings"
|
|
"testing"
|
|
|
|
"github.com/molecula/featurebase/v3/logger"
|
|
)
|
|
|
|
func TestRBFPageCommand_Run(t *testing.T) {
|
|
t.Run("OK", func(t *testing.T) {
|
|
cmLog := logger.NewStandardLogger(os.Stderr)
|
|
cmd := NewRBFPageCommand(cmLog)
|
|
buf := &bytes.Buffer{}
|
|
cmd.stdout = buf
|
|
cmd.Path = filepath.Join("testdata", "ok")
|
|
cmd.Pgnos = []uint32{0}
|
|
if err := cmd.Run(context.Background()); err != nil {
|
|
t.Fatal(err)
|
|
} else if got, want := buf.String(), "Type: meta"; !strings.Contains(got, want) {
|
|
t.Fatalf("got:\n%s\n\nwant:\n%s", got, want)
|
|
}
|
|
})
|
|
|
|
t.Run("ErrInvalidPageType", func(t *testing.T) {
|
|
t.Skip("RBF panics if we do this")
|
|
cmLog := logger.NewStandardLogger(os.Stderr)
|
|
cmd := NewRBFPageCommand(cmLog)
|
|
buf := &bytes.Buffer{}
|
|
cmd.stdout = buf
|
|
cmd.Path = filepath.Join("testdata", "err-invalid-page-type")
|
|
cmd.Pgnos = []uint32{4}
|
|
if err := cmd.Run(context.Background()); err == nil || err.Error() != `check failed` {
|
|
t.Fatal(err)
|
|
} else if got, want := buf.String(), `page not in-use & not free: pgno=4`+"\n"; got != want {
|
|
t.Fatalf("got:\n%s\n\nwant:\n%s", got, want)
|
|
}
|
|
})
|
|
}
|