mirror of
https://github.com/featurebasedb/featurebase.git
synced 2026-08-28 10:54:59 +00:00
stdout/stderr around
A lot of functions in the cmd and ctl packages were passing these
around and barely using them. Replaced them with a logger for most
functions. Some functions get an io.Writer instead so that their
tests can find the output they're looking for.
More cleanup on fb-1766: reworked the tests that were using io.Pipe
or os.Pipe to check their results so they now use a bytes.Buffer.
Unexported some variables that didn't need to be exported.
Fixed NewConfigCommand to use the provided stderr, not os.Stderr.
Added tests for rbf_dump, rbf_page, and keygen, since those weren't
being tested at all.
Added chksum_test, final cleanup.
(cherry picked from commit f627199acb)
32 lines
825 B
Go
32 lines
825 B
Go
// Copyright 2021 Molecula Corp. All rights reserved.
|
|
package cmd
|
|
|
|
import (
|
|
"io"
|
|
|
|
"github.com/molecula/featurebase/v3/ctl"
|
|
"github.com/molecula/featurebase/v3/dax/server"
|
|
"github.com/pkg/errors"
|
|
"github.com/spf13/cobra"
|
|
)
|
|
|
|
// newDAXCommand runs the FeatureBase CLI subcommand for ingesting bulk data.
|
|
func newDAXCommand(stderr io.Writer) *cobra.Command {
|
|
server := server.NewCommand(stderr)
|
|
daxCmd := &cobra.Command{
|
|
Use: "dax",
|
|
Short: "Run a collection of DAX services",
|
|
Long: ``,
|
|
RunE: func(cmd *cobra.Command, args []string) error {
|
|
if err := server.Start(); err != nil {
|
|
return considerUsageError(cmd, errors.Wrap(err, "running server"))
|
|
}
|
|
return errors.Wrap(server.Wait(), "waiting on Server")
|
|
},
|
|
}
|
|
|
|
// Attach flags to the command.
|
|
ctl.BuildDAXFlags(daxCmd, server)
|
|
|
|
return daxCmd
|
|
}
|