mirror of
https://github.com/featurebasedb/featurebase.git
synced 2026-08-28 10:54:59 +00:00
b6ae088f24
stdout/stderr around
A lot of functions in the cmd and ctl packages were passing these
around and barely using them. Replaced them with a logger for most
functions. Some functions get an io.Writer instead so that their
tests can find the output they're looking for.
More cleanup on fb-1766: reworked the tests that were using io.Pipe
or os.Pipe to check their results so they now use a bytes.Buffer.
Unexported some variables that didn't need to be exported.
Fixed NewConfigCommand to use the provided stderr, not os.Stderr.
Added tests for rbf_dump, rbf_page, and keygen, since those weren't
being tested at all.
Added chksum_test, final cleanup.
(cherry picked from commit f627199acb)
23 lines
526 B
Go
23 lines
526 B
Go
// Copyright 2022 Molecula Corp. (DBA FeatureBase).
|
|
// SPDX-License-Identifier: Apache-2.0
|
|
package ctl
|
|
|
|
import (
|
|
"os"
|
|
"testing"
|
|
|
|
"github.com/featurebasedb/featurebase/v3/server"
|
|
"github.com/spf13/cobra"
|
|
)
|
|
|
|
func TestBuildServerFlags(t *testing.T) {
|
|
cm := &cobra.Command{}
|
|
Server := server.NewCommand(os.Stderr)
|
|
BuildServerFlags(cm, Server)
|
|
if cm.Flags().Lookup("data-dir").Name == "" {
|
|
t.Fatal("data-dir flag is required")
|
|
}
|
|
if cm.Flags().Lookup("log-path").Name == "" {
|
|
t.Fatal("log-path flag is required")
|
|
}
|
|
}
|