mirror of
https://github.com/featurebasedb/featurebase.git
synced 2026-09-05 16:15:56 +00:00
214a1492a8
Performance of tests on MacOS has been atrocious for a while, and a lot of that is fsync, so we're trying to make that optional. To test all of this, I modified RBF to panic if anything tried to open an RBF database without disabling fsync, and ran the tests that way, and tracked down the various places this could still happen. There's a lot of places in our tree where we were creating test holders which were not getting created with fsync disabled, which results in a surprisingly large number of points at which we end up calling fsync in tests, which makes tests much slower than they need to be. There's also a bunch of places where the flags don't get propagated correctly; for instance, storage.fsync didn't propagate to the RBFConfig. We add an "fsync enabled" flag to OpenTranslateStoreFunc, so we can tell translation stores that we don't need syncing, so the server's config can be passed on appropriately. More of the test code that sets things up is correctly configuring that flag by default. We also change the barely-used bolt storage backend to support this as well. With this done, the only calls to fsync left in a run of `go test -short` in the top-level directory are from the zap logger in etcd, and consumed around 0.03 seconds. The overall impact is that `go test -short` went from "takes enough more than 10 minutes that i don't know how long it takes" to about 2.5 minutes.
131 lines
3.2 KiB
Go
131 lines
3.2 KiB
Go
// Copyright 2017 Pilosa Corp.
|
|
//
|
|
// Licensed under the Apache License, Version 2.0 (the "License");
|
|
// you may not use this file except in compliance with the License.
|
|
// You may obtain a copy of the License at
|
|
//
|
|
// http://www.apache.org/licenses/LICENSE-2.0
|
|
//
|
|
// Unless required by applicable law or agreed to in writing, software
|
|
// distributed under the License is distributed on an "AS IS" BASIS,
|
|
// WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
|
|
// See the License for the specific language governing permissions and
|
|
// limitations under the License.
|
|
|
|
package pilosa
|
|
|
|
import (
|
|
"testing"
|
|
"time"
|
|
|
|
"github.com/molecula/featurebase/v2/testhook"
|
|
. "github.com/molecula/featurebase/v2/vprint" // nolint:staticcheck
|
|
"golang.org/x/sync/errgroup"
|
|
)
|
|
|
|
// mustOpenView returns a new instance of View with a temporary path.
|
|
func mustOpenView(tb testing.TB, index, field, name string) *view {
|
|
path, err := testhook.TempDirInDir(tb, *TempDir, "pilosa-view-")
|
|
if err != nil {
|
|
PanicOn(err)
|
|
}
|
|
|
|
fo := FieldOptions{
|
|
CacheType: DefaultCacheType,
|
|
CacheSize: DefaultCacheSize,
|
|
}
|
|
|
|
h := NewHolder(path, mustHolderConfig())
|
|
// h needs an *Index so we can call h.Index() and get Index.Txf, in TestView_DeleteFragment
|
|
|
|
cim := &CreateIndexMessage{
|
|
Index: index,
|
|
CreatedAt: 0,
|
|
Meta: IndexOptions{},
|
|
}
|
|
|
|
idx, err := h.createIndex(cim, false)
|
|
testhook.Cleanup(tb, func() {
|
|
h.Close()
|
|
})
|
|
PanicOn(err)
|
|
|
|
v := newView(h, path, index, field, name, fo)
|
|
v.idx = idx
|
|
if err := v.openEmpty(); err != nil {
|
|
PanicOn(err)
|
|
}
|
|
return v
|
|
}
|
|
|
|
// Ensure view can open and retrieve a fragment.
|
|
func TestView_DeleteFragment(t *testing.T) {
|
|
v := mustOpenView(t, "i", "f", "v")
|
|
defer v.close()
|
|
|
|
shard := uint64(9)
|
|
|
|
// Create fragment.
|
|
fragment, err := v.CreateFragmentIfNotExists(shard)
|
|
if err != nil {
|
|
t.Fatal(err)
|
|
} else if fragment == nil {
|
|
t.Fatal("expected fragment")
|
|
}
|
|
|
|
err = v.deleteFragment(shard)
|
|
if err != nil {
|
|
t.Fatal(err)
|
|
}
|
|
|
|
if v.Fragment(shard) != nil {
|
|
t.Fatal("fragment still exists in view")
|
|
}
|
|
|
|
// Recreate fragment with same shard, verify that the old fragment was not reused.
|
|
fragment2, err := v.CreateFragmentIfNotExists(shard)
|
|
if err != nil {
|
|
t.Fatal(err)
|
|
} else if fragment == fragment2 {
|
|
t.Fatal("failed to create new fragment")
|
|
}
|
|
}
|
|
|
|
// Ensure that simultaneous attempts to grab a new fragment don't clash even
|
|
// if the broadcast operation takes a bit of time.
|
|
func TestView_CreateFragmentRace(t *testing.T) {
|
|
var creates errgroup.Group
|
|
v := mustOpenView(t, "i", "f", "v")
|
|
defer v.close()
|
|
|
|
// Use a broadcaster which intentionally fails.
|
|
v.broadcaster = delayBroadcaster{delay: 10 * time.Millisecond}
|
|
|
|
shard := uint64(0)
|
|
|
|
creates.Go(func() error {
|
|
_, err := v.CreateFragmentIfNotExists(shard)
|
|
return err
|
|
})
|
|
creates.Go(func() error {
|
|
_, err := v.CreateFragmentIfNotExists(shard)
|
|
return err
|
|
})
|
|
err := creates.Wait()
|
|
if err != nil {
|
|
t.Fatalf("unexpected error: %v", err)
|
|
}
|
|
}
|
|
|
|
// delayBroadcaster is a nopBroadcaster with a configurable delay.
|
|
type delayBroadcaster struct {
|
|
nopBroadcaster
|
|
delay time.Duration
|
|
}
|
|
|
|
// SendSync is an implementation of Broadcaster SendSync which delays for a
|
|
// specified interval before succeeding.
|
|
func (d delayBroadcaster) SendSync(Message) error {
|
|
time.Sleep(d.delay)
|
|
return nil
|
|
}
|