mirror of
https://github.com/featurebasedb/featurebase.git
synced 2026-10-15 07:18:04 +00:00
Performance of tests on MacOS has been atrocious for a while, and a lot of that is fsync, so we're trying to make that optional. To test all of this, I modified RBF to panic if anything tried to open an RBF database without disabling fsync, and ran the tests that way, and tracked down the various places this could still happen. There's a lot of places in our tree where we were creating test holders which were not getting created with fsync disabled, which results in a surprisingly large number of points at which we end up calling fsync in tests, which makes tests much slower than they need to be. There's also a bunch of places where the flags don't get propagated correctly; for instance, storage.fsync didn't propagate to the RBFConfig. We add an "fsync enabled" flag to OpenTranslateStoreFunc, so we can tell translation stores that we don't need syncing, so the server's config can be passed on appropriately. More of the test code that sets things up is correctly configuring that flag by default. We also change the barely-used bolt storage backend to support this as well. With this done, the only calls to fsync left in a run of `go test -short` in the top-level directory are from the zap logger in etcd, and consumed around 0.03 seconds. The overall impact is that `go test -short` went from "takes enough more than 10 minutes that i don't know how long it takes" to about 2.5 minutes.
277 lines
7.9 KiB
Go
277 lines
7.9 KiB
Go
// Copyright 2017 Pilosa Corp.
|
|
//
|
|
// Licensed under the Apache License, Version 2.0 (the "License");
|
|
// you may not use this file except in compliance with the License.
|
|
// You may obtain a copy of the License at
|
|
//
|
|
// http://www.apache.org/licenses/LICENSE-2.0
|
|
//
|
|
// Unless required by applicable law or agreed to in writing, software
|
|
// distributed under the License is distributed on an "AS IS" BASIS,
|
|
// WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
|
|
// See the License for the specific language governing permissions and
|
|
// limitations under the License.
|
|
|
|
package pilosa_test
|
|
|
|
import (
|
|
"reflect"
|
|
"testing"
|
|
|
|
"github.com/molecula/featurebase/v2"
|
|
"github.com/molecula/featurebase/v2/pql"
|
|
"github.com/molecula/featurebase/v2/test"
|
|
"github.com/molecula/featurebase/v2/testhook"
|
|
"github.com/pkg/errors"
|
|
)
|
|
|
|
// ShardWidth is a helper reference to use when testing.
|
|
const ShardWidth = pilosa.ShardWidth
|
|
|
|
// Ensure index can open and retrieve a field.
|
|
func TestIndex_CreateFieldIfNotExists(t *testing.T) {
|
|
index := test.MustOpenIndex(t)
|
|
defer index.Close()
|
|
|
|
// Create field.
|
|
f, err := index.CreateFieldIfNotExists("f", pilosa.OptFieldTypeDefault())
|
|
if err != nil {
|
|
t.Fatal(err)
|
|
} else if f == nil {
|
|
t.Fatal("expected field")
|
|
}
|
|
|
|
// Retrieve existing field.
|
|
other, err := index.CreateFieldIfNotExists("f", pilosa.OptFieldTypeDefault())
|
|
if err != nil {
|
|
t.Fatal(err)
|
|
} else if f.Field != other.Field {
|
|
t.Fatal("field mismatch")
|
|
}
|
|
|
|
if f.Field != index.Field("f") {
|
|
t.Fatal("field mismatch")
|
|
}
|
|
}
|
|
|
|
func TestIndex_CreateField(t *testing.T) {
|
|
// Ensure time quantum can be set appropriately on a new field.
|
|
t.Run("TimeQuantum", func(t *testing.T) {
|
|
t.Run("Explicit", func(t *testing.T) {
|
|
index := test.MustOpenIndex(t)
|
|
defer index.Close()
|
|
|
|
// Create field with explicit quantum.
|
|
f, err := index.CreateField("f", pilosa.OptFieldTypeTime(pilosa.TimeQuantum("YMDH")))
|
|
if err != nil {
|
|
t.Fatal(err)
|
|
} else if q := f.TimeQuantum(); q != pilosa.TimeQuantum("YMDH") {
|
|
t.Fatalf("unexpected field time quantum: %s", q)
|
|
}
|
|
})
|
|
})
|
|
|
|
// Ensure time quantum can be set appropriately on a new field.
|
|
t.Run("TimeQuantumNoStandardView", func(t *testing.T) {
|
|
t.Run("Explicit", func(t *testing.T) {
|
|
index := test.MustOpenIndex(t)
|
|
defer index.Close()
|
|
|
|
// Create field with explicit quantum with no standard view
|
|
f, err := index.CreateField("f", pilosa.OptFieldTypeTime(pilosa.TimeQuantum("YMDH"), true))
|
|
if err != nil {
|
|
t.Fatal(err)
|
|
} else if q := f.TimeQuantum(); q != pilosa.TimeQuantum("YMDH") {
|
|
t.Fatalf("unexpected field time quantum: %s", q)
|
|
}
|
|
})
|
|
})
|
|
|
|
// Ensure field can include range columns.
|
|
t.Run("BSIFields", func(t *testing.T) {
|
|
t.Run("Int", func(t *testing.T) {
|
|
index := test.MustOpenIndex(t)
|
|
defer index.Close()
|
|
|
|
// Create field with schema and verify it exists.
|
|
if f, err := index.CreateField("f", pilosa.OptFieldTypeInt(-990, 1000)); err != nil {
|
|
t.Fatal(err)
|
|
} else if !reflect.DeepEqual(f.Type(), pilosa.FieldTypeInt) {
|
|
t.Fatalf("unexpected type: %#v", f.Type())
|
|
}
|
|
|
|
// Reopen the index & verify the fields are loaded.
|
|
if err := index.Reopen(); err != nil {
|
|
t.Fatal(err)
|
|
} else if f := index.Field("f"); !reflect.DeepEqual(f.Type(), pilosa.FieldTypeInt) {
|
|
t.Fatalf("unexpected type after reopen: %#v", f.Type())
|
|
}
|
|
})
|
|
|
|
t.Run("Timestamp", func(t *testing.T) {
|
|
index := test.MustOpenIndex(t)
|
|
defer index.Close()
|
|
|
|
// Create field with schema and verify it exists.
|
|
if f, err := index.CreateField("f", pilosa.OptFieldTypeTimestamp(pilosa.DefaultEpoch, pilosa.TimeUnitSeconds)); err != nil {
|
|
t.Fatal(err)
|
|
} else if !reflect.DeepEqual(f.Type(), pilosa.FieldTypeTimestamp) {
|
|
t.Fatalf("unexpected type: %#v", f.Type())
|
|
}
|
|
|
|
// Reopen the index & verify the fields are loaded.
|
|
if err := index.Reopen(); err != nil {
|
|
t.Fatal(err)
|
|
} else if f := index.Field("f"); !reflect.DeepEqual(f.Type(), pilosa.FieldTypeTimestamp) {
|
|
t.Fatalf("unexpected type after reopen: %#v", f.Type())
|
|
}
|
|
})
|
|
|
|
// TODO: These errors don't apply here. Instead, we need these tests
|
|
// on field creation FieldOptions validation.
|
|
/*
|
|
t.Run("ErrRangeCacheAllowed", func(t *testing.T) {
|
|
index := test.MustOpenIndex(t)
|
|
defer index.Close()
|
|
|
|
if _, err := index.CreateField("f", pilosa.FieldOptions{
|
|
CacheType: pilosa.CacheTypeRanked,
|
|
}); err != nil {
|
|
t.Fatal(err)
|
|
}
|
|
})
|
|
|
|
t.Run("BSIFieldsWithCacheTypeNone", func(t *testing.T) {
|
|
index := test.MustOpenIndex(t)
|
|
defer index.Close()
|
|
if _, err := index.CreateField("f", pilosa.FieldOptions{
|
|
CacheType: pilosa.CacheTypeNone,
|
|
CacheSize: uint32(5),
|
|
}); err != nil {
|
|
t.Fatal(err)
|
|
}
|
|
})
|
|
|
|
t.Run("ErrFieldFieldsAllowed", func(t *testing.T) {
|
|
index := test.MustOpenIndex(t)
|
|
defer index.Close()
|
|
|
|
if _, err := index.CreateField("f", pilosa.FieldOptions{
|
|
Fields: []*pilosa.Field{
|
|
{Name: "field0", Type: pilosa.FieldTypeInt},
|
|
},
|
|
}); err != nil {
|
|
t.Fatal(err)
|
|
}
|
|
})
|
|
|
|
t.Run("ErrFieldNameRequired", func(t *testing.T) {
|
|
index := test.MustOpenIndex(t)
|
|
defer index.Close()
|
|
|
|
if _, err := index.CreateField("f", pilosa.FieldOptions{
|
|
Fields: []*pilosa.Field{
|
|
{Name: "", Type: pilosa.FieldTypeInt},
|
|
},
|
|
}); err != pilosa.ErrFieldNameRequired {
|
|
t.Fatal(err)
|
|
}
|
|
})
|
|
|
|
t.Run("ErrInvalidFieldType", func(t *testing.T) {
|
|
index := test.MustOpenIndex(t)
|
|
defer index.Close()
|
|
|
|
if _, err := index.CreateField("f", pilosa.FieldOptions{
|
|
Fields: []*pilosa.Field{
|
|
{Name: "field0", Type: "bad_type"},
|
|
},
|
|
}); err != pilosa.ErrInvalidFieldType {
|
|
t.Fatal(err)
|
|
}
|
|
})
|
|
|
|
t.Run("ErrInvalidBSIGroupRange", func(t *testing.T) {
|
|
index := test.MustOpenIndex(t)
|
|
defer index.Close()
|
|
|
|
if _, err := index.CreateField("f", pilosa.FieldOptions{
|
|
Fields: []*pilosa.Field{
|
|
{Name: "field0", Type: pilosa.FieldTypeInt, Min: 100, Max: 50},
|
|
},
|
|
}); err != pilosa.ErrInvalidBSIGroupRange {
|
|
t.Fatal(err)
|
|
}
|
|
})
|
|
*/
|
|
})
|
|
|
|
t.Run("WithKeys", func(t *testing.T) {
|
|
// Don't allow an int field to be created with keys=true
|
|
t.Run("IntField", func(t *testing.T) {
|
|
index := test.MustOpenIndex(t)
|
|
defer index.Close()
|
|
|
|
_, err := index.CreateField("f", pilosa.OptFieldTypeInt(-1, 1), pilosa.OptFieldKeys())
|
|
if errors.Cause(err) != pilosa.ErrIntFieldWithKeys {
|
|
t.Fatal("int field cannot be created with keys=true")
|
|
}
|
|
})
|
|
|
|
// Don't allow a decimal field to be created with keys=true
|
|
t.Run("DecimalField", func(t *testing.T) {
|
|
index := test.MustOpenIndex(t)
|
|
defer index.Close()
|
|
|
|
_, err := index.CreateField("f", pilosa.OptFieldTypeDecimal(1, pql.Decimal{Value: -1}, pql.Decimal{Value: 1}), pilosa.OptFieldKeys())
|
|
if errors.Cause(err) != pilosa.ErrDecimalFieldWithKeys {
|
|
t.Fatal("decimal field cannot be created with keys=true")
|
|
}
|
|
})
|
|
})
|
|
}
|
|
|
|
// Ensure index can delete a field.
|
|
func TestIndex_DeleteField(t *testing.T) {
|
|
index := test.MustOpenIndex(t)
|
|
defer index.Close()
|
|
|
|
// Create field.
|
|
if _, err := index.CreateFieldIfNotExists("f", pilosa.OptFieldTypeDefault()); err != nil {
|
|
t.Fatal(err)
|
|
}
|
|
|
|
// Delete field & verify it's gone.
|
|
if err := index.DeleteField("f"); err != nil {
|
|
t.Fatal(err)
|
|
} else if index.Field("f") != nil {
|
|
t.Fatal("expected nil field")
|
|
}
|
|
|
|
// Delete again to make sure it errors.
|
|
err := index.DeleteField("f")
|
|
if !isNotFoundError(err) {
|
|
t.Fatalf("expected 'field not found' error, got: %#v", err)
|
|
}
|
|
}
|
|
|
|
// Ensure index can validate its name.
|
|
func TestIndex_InvalidName(t *testing.T) {
|
|
path, err := testhook.TempDir(t, "pilosa-index-")
|
|
if err != nil {
|
|
panic(err)
|
|
}
|
|
index, err := pilosa.NewIndex(pilosa.NewHolder(path, mustHolderConfig()), path, "ABC")
|
|
if err == nil {
|
|
t.Fatalf("should have gotten an error on index name with caps")
|
|
}
|
|
if index != nil {
|
|
t.Fatalf("unexpected index name %v", index)
|
|
}
|
|
}
|
|
|
|
func isNotFoundError(err error) bool {
|
|
root := errors.Cause(err)
|
|
_, ok := root.(pilosa.NotFoundError)
|
|
return ok
|
|
}
|