mirror of
https://github.com/featurebasedb/featurebase.git
synced 2026-09-07 09:05:55 +00:00
97b530ca78
- all tests green on RoaringTx
- RoaringTx on by default
- blueGreenTx testing framework available for A-vs-B comparison
of Tx implementations
- flag -tx added to server command line but not wired to
change NewIndex() selection yet.
- 918 green tests, 14 tests red on BadgerTx.
A full list of the 14 red tests on BadgerTx follows.
Note that these red tests represent not defects in BadgerDB
or BadgerTx but rather failures of the pre-existing pilosa infrastructure to yet
be fully adapted from files to using a transactional storage engine.
As such these are tests that RBF should not be expected to
pass yet either.
Fixing the pilosa infrastructure to allow these tests
to go green under Badger is the next and highest priority
order of business, but RBF can get much testing benefit
from the 918 green tests we do have, and hence we merge
as much as we have today.
The 14 red tests when NewIndex() is set to use
BadgerTx are as follows. Note in particular
that pilosa cluster resizing is not working yet under a
transactional store.
TestCluster_ResizeStates/Multiple_nodes,_with_data
TestImportClearRestart/0MaxOpN10000
TestImportClearRestart/1MaxOpN10000
TestImportClearRestart/2MaxOpN10000
TestImportClearRestart/3MaxOpN10000
TestExecutor_Execute_Existence/Row
TestExecutor_ForeignIndex
TestExecutor_Execute_CountDistinct/Distinct
TestExecutor_Execute_CountDistinct/Count(Distinct)
TestExecutor_Execute_CountDistinct/GroupBy(Distinct)
TestExecutor_BareDistinct
TestExecutor_Execute_TopNDistinct/TopN
TestHolderSyncer_IntField/BasicSync
TestHolderSyncer_IntField/MultiShard
100 lines
2.3 KiB
Go
100 lines
2.3 KiB
Go
// Copyright 2017 Pilosa Corp.
|
|
//
|
|
// Licensed under the Apache License, Version 2.0 (the "License");
|
|
// you may not use this file except in compliance with the License.
|
|
// You may obtain a copy of the License at
|
|
//
|
|
// http://www.apache.org/licenses/LICENSE-2.0
|
|
//
|
|
// Unless required by applicable law or agreed to in writing, software
|
|
// distributed under the License is distributed on an "AS IS" BASIS,
|
|
// WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
|
|
// See the License for the specific language governing permissions and
|
|
// limitations under the License.
|
|
package pilosa
|
|
|
|
import (
|
|
"fmt"
|
|
|
|
"github.com/pilosa/pilosa/v2/rbf"
|
|
"github.com/pilosa/pilosa/v2/roaring"
|
|
)
|
|
|
|
type Converter interface {
|
|
Convert(index, field, view string, shard uint64, rb *roaring.Bitmap) error
|
|
Shutdown()
|
|
}
|
|
|
|
type RBFConverter struct {
|
|
Dbs map[string]*rbf.DB
|
|
Base string
|
|
}
|
|
|
|
func (rbc *RBFConverter) GetOrCreateDB(index string, shard uint64) (*rbf.DB, error) {
|
|
key := fmt.Sprintf("%s/%d", index, shard)
|
|
db, found := rbc.Dbs[key]
|
|
if found {
|
|
return db, nil
|
|
}
|
|
path := rbc.Base + "/" + key
|
|
db = rbf.NewDB(path)
|
|
err := db.Open()
|
|
if err != nil {
|
|
return nil, err
|
|
}
|
|
rbc.Dbs[key] = db
|
|
return db, nil
|
|
}
|
|
func (rbc *RBFConverter) Shutdown() {
|
|
for key, db := range rbc.Dbs {
|
|
fmt.Println("Shutdown", key)
|
|
db.Close()
|
|
|
|
}
|
|
|
|
}
|
|
func (rbc *RBFConverter) Convert(index, field, view string, shard uint64, rb *roaring.Bitmap) error {
|
|
fmt.Println("CONVERT", index, field, view, shard)
|
|
db, err := rbc.GetOrCreateDB(index, shard)
|
|
if err != nil {
|
|
return err
|
|
}
|
|
tx, err := db.Begin(writable)
|
|
if err != nil {
|
|
return err
|
|
}
|
|
defer func() { _ = tx.Rollback() }()
|
|
|
|
name := fmt.Sprintf("%s/%s", field, view)
|
|
err = tx.CreateBitmap(name)
|
|
if err != nil {
|
|
return err
|
|
}
|
|
_, err = tx.AddRoaring(name, rb)
|
|
if err != nil {
|
|
return err
|
|
}
|
|
return tx.Commit()
|
|
}
|
|
|
|
func (h *Holder) ConvertToRBF(c Converter) {
|
|
/*
|
|
for idxname, idx := range h.indexes {
|
|
for fieldName, field := range idx.fields {
|
|
for _, view := range field.views() {
|
|
for shard, fragment := range view.fragments {
|
|
panic("NEED bitmap from storage")
|
|
junk := roaring.NewBitmap()
|
|
err := c.Convert(idxname, fieldName, view.name, shard, junk)
|
|
if err != nil {
|
|
fmt.Println("ERR", err, fragment.shard) //just added shard for compile
|
|
}
|
|
}
|
|
}
|
|
|
|
}
|
|
|
|
}
|
|
c.Shutdown()
|
|
*/
|
|
}
|