mirror of
https://github.com/featurebasedb/featurebase.git
synced 2026-09-09 14:41:02 +00:00
c88192b4ac
In rare cases, RBF can produce containers which have a recorded N value which is incorrect. This rarely affects anything, but on some particular queries, this can result in very strange outcomes, like array containers with more than 1<<16 entries. To fix this, we have toContainer specify that it doesn't know the correct N for the bitmap containers it's creating, which costs extra time for counting, and should be considered a temporary workaround. Also, we add a CheckN() function which is controlled by the roaringparanoia flag, and add a number of calls to it, for instance, as deferred calls after every container operation when roaringparanoia is enabled. This means that we get improved confidence that we've caught the relevant errors, but is not suitable for production use.
34 lines
1,014 B
Go
34 lines
1,014 B
Go
// Copyright 2017 Pilosa Corp.
|
|
//
|
|
// Licensed under the Apache License, Version 2.0 (the "License");
|
|
// you may not use this file except in compliance with the License.
|
|
// You may obtain a copy of the License at
|
|
//
|
|
// http://www.apache.org/licenses/LICENSE-2.0
|
|
//
|
|
// Unless required by applicable law or agreed to in writing, software
|
|
// distributed under the License is distributed on an "AS IS" BASIS,
|
|
// WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
|
|
// See the License for the specific language governing permissions and
|
|
// limitations under the License.
|
|
|
|
// +build roaringparanoia
|
|
|
|
package roaring
|
|
|
|
import "fmt"
|
|
|
|
const roaringParanoia = true
|
|
|
|
// CheckN verifies that the container's cached count is correct. Note
|
|
// that this has two definitions, depending on the presence of the
|
|
// roaringparanoia build tag.
|
|
func (c *Container) CheckN() {
|
|
if c == nil {
|
|
return
|
|
}
|
|
count := c.count()
|
|
if count != c.n {
|
|
panic(fmt.Sprintf("CheckN (%p): n %d, count %d", c, c.n, count))
|
|
}
|
|
}
|