featurebase/idk
jonathan.cheng 43f63b93e3
Cloud 940, skip bad row, enable ingest subsequent rows (#2201)
* first try to skip decodeMessage() error

* force idk to skip a row if there are errors in recordizing

* add comment for removing returning errors from decodemessage()

* added ingest flag SkipBadRows and implementation for skipping Bad Rows (errors that come from recordizer)

* added some comments

* removed comment

* made changes as per discussion with jaffee and walter. i hope this works...

* adding unit tests to check functionality implemented for CLOUD-940

* addressing review comments

* changed a variable name in test file

* removed a variable from ingest test file

* testing sonarcloud failure

* drop spurious second sonar-scanner call

We call sonar-scanner on the IDK data, and then we change
into the IDK directory and try to run it again on the same files,
which don't exist.

* abandon idk change detection for now

the "changes" rule appears not to be good at detecting changes
in some cases. specifically, it appears that you have to be in
an "only:" clause, not a "rules" clause, to trigger the
merge-specific behavior which checks the entire merge branch
instead of the top commit, but that means that if your last
commit doesn't touch IDK, we don't run IDK tests, and I haven't
been able to fix this yet.

So for now, revert the IDK-specific change detection behavior,
which slows CI down but gets us test coverage.

* fix path references

we had three tests all creating idk_coverage.out, then we tried
to grab all files named coverage.out from the testdata directory.

* refactoring tests to avoid duplication

* reverting changes made for local testing

Co-authored-by: CHIN JUNG CHENG <chengcj@CHINs-MacBook-Pro.local>
Co-authored-by: Pranitha-malae <56414132+Pranitha-malae@users.noreply.github.com>
Co-authored-by: Pranitha-malae <pranitha453@gmail.com>
Co-authored-by: Seebs <seebs@molecula.com>
2022-10-06 16:20:35 -05:00
..
api FB-1597: unifying idk and featurebase (#2160) 2022-07-28 17:23:16 -05:00
bankgen FB-1597: unifying idk and featurebase (#2160) 2022-07-28 17:23:16 -05:00
cmd Cloud 940, skip bad row, enable ingest subsequent rows (#2201) 2022-10-06 16:20:35 -05:00
common FB-1597: unifying idk and featurebase (#2160) 2022-07-28 17:23:16 -05:00
csv FB-1618: Fix code smells due to unifying IDK and Featurebase (#2184) 2022-08-12 17:00:29 -05:00
datagen FB-1597: unifying idk and featurebase (#2160) 2022-07-28 17:23:16 -05:00
docker-sasl FB-1597: unifying idk and featurebase (#2160) 2022-07-28 17:23:16 -05:00
fakeidp Distinguish between three copies of fakeidp service (#2192) 2022-08-16 09:13:11 -05:00
idktest [CLOUD-934] Optionally broadcast IDK Kinesis errors/panics to externa… (#2185) 2022-08-12 17:59:56 -05:00
internal FB-1597: unifying idk and featurebase (#2160) 2022-07-28 17:23:16 -05:00
kafka FB-1696 - fixed debug message to show topic's name instead of topic's address 2022-10-04 15:50:46 -05:00
kafka_sasl [FB-1617] Commit Messages out of order (#2180) 2022-08-08 14:41:22 -05:00
kafka_static FB-1597: unifying idk and featurebase (#2160) 2022-07-28 17:23:16 -05:00
kafkagen FB-1597: unifying idk and featurebase (#2160) 2022-07-28 17:23:16 -05:00
kinesis [CLOUD-934] Optionally broadcast IDK Kinesis errors/panics to externa… (#2185) 2022-08-12 17:59:56 -05:00
sql FB-1597: unifying idk and featurebase (#2160) 2022-07-28 17:23:16 -05:00
testdata FB-1597: unifying idk and featurebase (#2160) 2022-07-28 17:23:16 -05:00
testenv/certs FB-1597: unifying idk and featurebase (#2160) 2022-07-28 17:23:16 -05:00
.cloud-env.template FB-1597: unifying idk and featurebase (#2160) 2022-07-28 17:23:16 -05:00
docker-compose.yml FB-1597: unifying idk and featurebase (#2160) 2022-07-28 17:23:16 -05:00
Dockerfile Upgrade Go to 1.19 (#2204) 2022-08-25 14:54:14 -06:00
Dockerfile-fakeIDP Upgrade Go to 1.19 (#2204) 2022-08-25 14:54:14 -06:00
Dockerfile-test Upgrade Go to 1.19 (#2204) 2022-08-25 14:54:14 -06:00
Dockerfile-wait FB-1597: unifying idk and featurebase (#2160) 2022-07-28 17:23:16 -05:00
dup.go FB-1597: unifying idk and featurebase (#2160) 2022-07-28 17:23:16 -05:00
dup_arm64.go FB-1597: unifying idk and featurebase (#2160) 2022-07-28 17:23:16 -05:00
file_with_line_delimited_values FB-1597: unifying idk and featurebase (#2160) 2022-07-28 17:23:16 -05:00
header.go FB-1618: Fix code smells due to unifying IDK and Featurebase (#2184) 2022-08-12 17:00:29 -05:00
header_test.go FB-1597: unifying idk and featurebase (#2160) 2022-07-28 17:23:16 -05:00
idallocator.go drop ioutil 2022-09-23 16:56:27 -05:00
idallocator_test.go FB-1597: unifying idk and featurebase (#2160) 2022-07-28 17:23:16 -05:00
ingest.go Cloud 940, skip bad row, enable ingest subsequent rows (#2201) 2022-10-06 16:20:35 -05:00
ingest_test.go Cloud 940, skip bad row, enable ingest subsequent rows (#2201) 2022-10-06 16:20:35 -05:00
interfaces.go [FB-1024 FB-1590] Increase timerange (un-revert) (#2174) 2022-08-04 15:20:45 -07:00
interfaces_test.go FB-1618: Fix code smells due to unifying IDK and Featurebase (#2184) 2022-08-12 17:00:29 -05:00
Makefile Cloud 940, skip bad row, enable ingest subsequent rows (#2201) 2022-10-06 16:20:35 -05:00
metrics.go FB-1597: unifying idk and featurebase (#2160) 2022-07-28 17:23:16 -05:00
pilosa-sec-test.conf FB-1597: unifying idk and featurebase (#2160) 2022-07-28 17:23:16 -05:00
postgres.go FB-1597: unifying idk and featurebase (#2160) 2022-07-28 17:23:16 -05:00
progress.go FB-1597: unifying idk and featurebase (#2160) 2022-07-28 17:23:16 -05:00
README.md Distinguish between three copies of fakeidp service (#2192) 2022-08-16 09:13:11 -05:00
reingest_test.sh FB-1597: unifying idk and featurebase (#2160) 2022-07-28 17:23:16 -05:00
sample.csv FB-1597: unifying idk and featurebase (#2160) 2022-07-28 17:23:16 -05:00
test_postgres.go FB-1597: unifying idk and featurebase (#2160) 2022-07-28 17:23:16 -05:00
tls.go drop ioutil 2022-09-23 16:56:27 -05:00
util.go FB-1597: unifying idk and featurebase (#2160) 2022-07-28 17:23:16 -05:00
util_test.go FB-1597: unifying idk and featurebase (#2160) 2022-07-28 17:23:16 -05:00
version.go FB-1597: unifying idk and featurebase (#2160) 2022-07-28 17:23:16 -05:00
wait.sh FB-1597: unifying idk and featurebase (#2160) 2022-07-28 17:23:16 -05:00

idk: Ingest Development Kit

Integration tests

To run the tests, you will need to install the following dependencies:

  1. Docker
  2. Docker Compose
  3. Certstrap

In addition to these dependancies, you will need to be added to the moleculacorp Dockerhub account.

First start the test environment. This is a docker-compose environment that includes pilosa and a confluent kafka stack. Run the following to start those services:

BRANCH_NAME=master make startup

To build and run the integration tests, run:

make test-run

Then to shut down the test environment, run:

make shutdown

You can run all of the previous commands by calling test-all:

BRANCH_NAME=master make test-all

The previous command is equivalent to running the following:

make startup
sleep 30 # wait for services to come up
make test-run
make shutdown

To run an individual test, you can run the command directly using docker-compose. Note that you must run docker-compose build idk-test for docker to run the latest code. Modify the following as needed:

make startup
docker-compose build idk-test
docker-compose run idk-test /usr/local/go/bin/go test -count=1 -mod=vendor -run=TestCmdMainOne ./kafka

To shutdown and reset the environment:

make clean

Running dependencies locally (rather than in docker) "make test-local"

This is for running the tests locally and not in Docker... so you have to be running a bunch of stuff natively on your machine.

Run Pilosa with default config:

pilosa server

Run another pilosa like

pilosa server --config=pilosa-sec-test.conf

which will run Pilosa with TLS using certs in testenv. (make testenv first if you haven't).

You also need to be running the Confluent stack which, after you've installed it from Confluent's site might look something like:

export JAVA_HOME=/Library/Java/JavaVirtualMachines/jdk1.8.0_66.jdk/Contents/Home
confluent local destroy && confluent local start schema-registry

Or it might not! You may not need the first line, but if you have the wrong Java version by default, that's how you set it. The second line may change depending on what version of the confluent stack you get. According to

confluent version

I'm running:

Version:     v0.212.0
Git Ref:     2b04985

Use the test-local make target:

make test-local

This sets a number of environment variables (which it prints when you run it), and should set them correctly if you follow the instructions above, but if you're running things on non-default ports you may need to tweak them.

CSV Ingester

  1. make sure you're running Pilosa (localhost:10101 for these instructions)

molecula-consumer-csv --primary-key-fields=asset_tag -i sample-index --files sample.csv

asset_tag__String,fan_time__RecordTime_2006-01-02,fan_val__String_F_YMD
ABCD,2019-01-02,70%
ABCD,2019-01-03,20%
ABCD,2019-01-04,30%
BEDF,2019-01-02,70%
BEDF,2019-01-05,90%
BEDF,2019-01-08,10%
BEDF,2019-01-08,20%
ABCD,2019-01-30,40%

Datagen

Datagen is an internal command-line tool to generate various application-specific datasets, and ingest them directly into Pilosa. After running make install, run datagen with no arguments to see a list of available "sources".

When running Datagen with local Docker stacks, make sure to add individual docker stacks to the /etc/hosts file:

127.0.0.1 kafka
127.0.0.1 pilosa
127.0.0.1 <docker stack>

ODBC Support

By default, the SQL ingester is not built with ODBC support. This is because it uses CGO with extra dependencies, and the resulting binaries are not portable. In order to build with ODBC support, it is necessary to install unixODBC to the system. Then run:

make bin/molecula-consumer-sql-odbc

Different Linux distros will store certain libraries in different locations. ODBC uses dynamic library loading to handle drivers, so full static linking of dependencies is not possible. It is therefore necessary to build on a system with the same distro and the same software versions as the target machine.