featurebase/sql3/planner/compilealtertable.go
Pat Okeeffe 5c74b64722
A bug fix roundup (#2242)
* fb-1940 re-implemented some changes that got missed private-public

* fb-1939 fixes to between + decimals

* fb-1935 - avg() on and id type + fixed some tests

* fb-1953 add min/max for string types

* fb-1938 - remove internal_type column from show columns

* fb-1964 - fix space_used in fb_cluster_nodes to be int

* fb-1996 - make sure all Idents that are being used as object references to schema objects are lowercased

* fixed failing test

* added some missed changes

* fb-1969 found another case issue with identifier used for column idents
2023-02-13 12:28:34 -06:00

113 lines
3.6 KiB
Go

// Copyright 2021 Molecula Corp. All rights reserved.
package planner
import (
"context"
"strings"
"github.com/featurebasedb/featurebase/v3/dax"
"github.com/featurebasedb/featurebase/v3/sql3"
"github.com/featurebasedb/featurebase/v3/sql3/parser"
"github.com/featurebasedb/featurebase/v3/sql3/planner/types"
)
type alterOperation int64
const (
alterOpAdd alterOperation = iota
alterOpDrop
alterOpRename
alterOpSet
)
// compileAlterTableStatement compiles an ALTER TABLE statement into a
// PlanOperator.
func (p *ExecutionPlanner) compileAlterTableStatement(ctx context.Context, stmt *parser.AlterTableStatement) (_ types.PlanOperator, err error) {
tableName := strings.ToLower(parser.IdentName(stmt.Name))
// does the table exist
tname := dax.TableName(tableName)
tbl, err := p.schemaAPI.TableByName(ctx, tname)
if err != nil {
if isTableNotFoundError(err) {
return nil, sql3.NewErrTableNotFound(stmt.Name.NamePos.Line, stmt.Name.NamePos.Column, tableName)
}
return nil, err
}
if stmt.Drop.IsValid() {
columnName := strings.ToLower(parser.IdentName(stmt.DropColumnName))
// does this column exist
found := false
for _, f := range tbl.Fields {
if strings.EqualFold(string(f.Name), columnName) {
found = true
break
}
}
if !found {
return nil, sql3.NewErrColumnNotFound(stmt.DropColumnName.NamePos.Line, stmt.DropColumnName.NamePos.Column, columnName)
}
return NewPlanOpQuery(p, NewPlanOpAlterTable(p, tableName, alterOpDrop, columnName, "", nil), p.sql), nil
} else if stmt.Add.IsValid() {
col := stmt.ColumnDef
columnName := strings.ToLower(parser.IdentName(col.Name))
// does this column exist
for _, f := range tbl.Fields {
if strings.EqualFold(string(f.Name), columnName) {
return nil, sql3.NewErrDuplicateColumn(col.Name.NamePos.Line, col.Name.NamePos.Column, columnName)
}
}
column, err := p.compileColumn(ctx, col)
if err != nil {
return nil, err
}
return NewPlanOpQuery(p, NewPlanOpAlterTable(p, tableName, alterOpAdd, "", columnName, column), p.sql), nil
} else if stmt.Rename.IsValid() {
oldColumnName := strings.ToLower(parser.IdentName(stmt.OldColumnName))
newColumnName := strings.ToLower(parser.IdentName(stmt.NewColumnName))
return NewPlanOpQuery(p, NewPlanOpAlterTable(p, tableName, alterOpRename, oldColumnName, newColumnName, nil), p.sql), nil
} else {
return nil, sql3.NewErrInternal("unhandled alter operation")
}
}
// analyzeAlterTableStatement analyze an ALTER TABLE statement and returns an
// error if anything is invalid.
func (p *ExecutionPlanner) analyzeAlterTableStatement(stmt *parser.AlterTableStatement) error {
if stmt.Drop.IsValid() {
//no checks for now
} else if stmt.Add.IsValid() {
col := stmt.ColumnDef
columnName := strings.ToLower(parser.IdentName(col.Name))
typeName := parser.IdentName(col.Type.Name)
if !parser.IsValidTypeName(typeName) {
return sql3.NewErrUnknownType(col.Type.Name.NamePos.Line, col.Type.Name.NamePos.Column, typeName)
}
if strings.ToLower(columnName) == "_id" {
//not allowed to add an _id column after the fact
return sql3.NewErrTableIDColumnAlter(col.Name.NamePos.Line, col.Name.NamePos.Column)
}
err := p.analyzeColumn(typeName, col)
if err != nil {
return err
}
} else if stmt.Rename.IsValid() {
//check the new and old are not the same
oldColumnName := strings.ToLower(parser.IdentName(stmt.OldColumnName))
newColumnName := strings.ToLower(parser.IdentName(stmt.NewColumnName))
if strings.EqualFold(oldColumnName, newColumnName) {
return sql3.NewErrDuplicateColumn(stmt.NewColumnName.NamePos.Line, stmt.NewColumnName.NamePos.Column, newColumnName)
}
}
return nil
}