mirror of
https://github.com/featurebasedb/featurebase.git
synced 2026-09-07 17:15:56 +00:00
ac7be132ef
a) All tests green under -race for both PILOSA_TXSRC=roaring and PILOSA_TXSRC=badger. b) Distinct is merged back into mainline pilosa. Seebs notes on the Distinct work: merge Distinct plugin back into main source tree, convert to Tx We drop all references to the Preemptively Deprecated Don't You Dare Use This extension interface, and move the one and only extension we had (Distinct) into the main executor. Also this fixes an arguable bug, which is that Container.AsBitmap() would panic on a nil parameter, but it should have returned an empty bitmap, because a nil *Ccontainer is a valid empty container. This simplifies logic significantly in Distinct. Fixes #569 #570 #571 #572 #573 #584 #585
91 lines
2.4 KiB
Go
91 lines
2.4 KiB
Go
// Copyright 2017 Pilosa Corp.
|
|
//
|
|
// Licensed under the Apache License, Version 2.0 (the "License");
|
|
// you may not use this file except in compliance with the License.
|
|
// You may obtain a copy of the License at
|
|
//
|
|
// http://www.apache.org/licenses/LICENSE-2.0
|
|
//
|
|
// Unless required by applicable law or agreed to in writing, software
|
|
// distributed under the License is distributed on an "AS IS" BASIS,
|
|
// WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
|
|
// See the License for the specific language governing permissions and
|
|
// limitations under the License.
|
|
|
|
package pilosa
|
|
|
|
import (
|
|
"io/ioutil"
|
|
"testing"
|
|
)
|
|
|
|
// mustOpenIndex returns a new, opened index at a temporary path. Panic on error.
|
|
func mustOpenIndex(opt IndexOptions) *Index {
|
|
path, err := ioutil.TempDir(*TempDir, "pilosa-index-")
|
|
if err != nil {
|
|
panic(err)
|
|
}
|
|
h := NewHolder(1)
|
|
h.Path = path
|
|
index, err := h.CreateIndex("i", opt)
|
|
|
|
if err != nil {
|
|
panic(err)
|
|
}
|
|
|
|
index.keys = opt.Keys
|
|
index.trackExistence = opt.TrackExistence
|
|
|
|
if err := index.Open(false); err != nil {
|
|
panic(err)
|
|
}
|
|
return index
|
|
}
|
|
|
|
// reopen closes the index and reopens it.
|
|
func (i *Index) reopen() error {
|
|
if err := i.Close(); err != nil {
|
|
return err
|
|
}
|
|
if err := i.Open(false); err != nil {
|
|
return err
|
|
}
|
|
return nil
|
|
}
|
|
|
|
// Ensure that deleting the existence field is handled properly.
|
|
func TestIndex_Existence_Delete(t *testing.T) {
|
|
// Create Index (with existence tracking).
|
|
index := mustOpenIndex(IndexOptions{TrackExistence: true})
|
|
defer index.Close()
|
|
|
|
// Ensure existence field has been created.
|
|
ef := index.Field(existenceFieldName)
|
|
if ef == nil {
|
|
t.Fatalf("expected field to have been created: %s", existenceFieldName)
|
|
} else if !index.trackExistence {
|
|
t.Fatalf("expected index.trackExistence to be true")
|
|
} else if index.existenceFld == nil {
|
|
t.Fatalf("expected index.existenceField to be non-nil")
|
|
}
|
|
|
|
// Delete existence field.
|
|
if err := index.DeleteField(existenceFieldName); err != nil {
|
|
t.Fatal(err)
|
|
}
|
|
|
|
// Re-open index.
|
|
if err := index.reopen(); err != nil {
|
|
t.Fatal(err)
|
|
}
|
|
|
|
// Ensure existence field no longer exists.
|
|
ef = index.Field(existenceFieldName)
|
|
if ef != nil {
|
|
t.Fatalf("expected field to have been deleted: %s", existenceFieldName)
|
|
} else if index.trackExistence {
|
|
t.Fatalf("expected index.trackExistence to be false")
|
|
} else if index.existenceFld != nil {
|
|
t.Fatalf("expected index.existenceField to be nil")
|
|
}
|
|
}
|