mirror of
https://github.com/featurebasedb/featurebase.git
synced 2026-08-28 10:54:59 +00:00
This patch replaces a lot of circumstances in which containers were being copied with circumstances in which they are shared, using copy-on-write semantics. To achieve this, we emulate somewhat the design of go's native `append` function. Operations on a container may optionally yield a new container. A container can be marked "frozen", after which no operation should ever write to it in any way; that applies both to the container itself and the backing store it refers to, if any. So for instance, instead of: c.arrayToBitmap() we now write: c = c.arrayToBitmap() Operations which need to modify a container in any way need to be able to return a new container, which is a modified copy of the previous container. This applies to operations like add/remove, but also to things like unmapping memory-mapped storage, or changing a container's type. Bitmaps do not support the same copy-on-write semantics, currently, but "copying" a bitmap and sharing the containers instead of duplicating them is *much* cheaper than copying the containers. Bitmaps do support a .Freeze method, which currently copies the previous bitmap, making a new one with the same container pointers, and freezes the individual containers. Use this if you need a writeable copy of a bitmap -- the resulting bitmap can safely have its set of containers modified, and bitmap operators that would want to modify the containers will use copy-on-write for that. The primary motivation of this is to reduce the cost of the row cache used by fragments. As a secondary issue, the row cache is no longer updated on writes -- that update was actually a race condition waiting to happen. Rather, writes to a row invalidate the cache entry for that row. The row cache is created by creating a new bitmap, and freezing the relevant containers from the fragment's storage. In the case where nothing is being written, the row cache grows to contain bitmaps containing all those containers, but never copies any containers. If nothing's being read, the row cache is never created, and the containers are in general not getting frozen. The only circumstance where copies have to happen is when things are read (and thus stored in the row cache) and later modified. In that case, each read freezes objects, and the first write to a container after it's been frozen will create a new copy. We drop the enterprise/b btree implementation, because we don't really need it anymore -- we now provide that implementation by default in the open source product anyway. Along with this, there's a lot of other changes which improve support for nil containers, as a cheaper representation for empty containers. Operations which we know will provide an empty container can always short-circuit and just yield a nil *Container. Similarly, operations which would provide a full container can return a single shared full container object (which is frozen). The higher-level (non type-specific) container ops are now using that logic to short-circuit operations for empty and full containers. (For instance, difference of anything minus an empty container is the original thing, union of anything and empty is the original thing, and so on.) The Containers interface adds "Update" and "UpdateEvery" methods, based in part on the "Put" interface provided by the underlying btree implementation; Update performs a possible update in-place of a container for a given key, bypassing the need to replicate the search for that key in the container. UpdateEvery loops through all the containers. Containers do not strictly guarantee that they won't return nil `*Container` objects. However, the container iterators won't return those -- empty containers aren't interesting. Some tests are updated to reflect this. Some of the container internals, like N(), or the isArray() and related functions, accept nil container pointers. Some, like Thaw(), do not. For the array(), bitmap(), and runs() methods, roaringparanoia enables an explicit panic on a nil container explaining the problem, but the intent is that those should never be called unless you already know you have the right kind of container, so by default they don't perform the extra checks. In most cases, this is already covered because a nil container is empty, and there's no operation we can perform that requires us to inspect the contents of an empty container. This is passing a fair amount of testing, but the testing may not be comprehensive enough. The overall impact of this is pretty trivial performance-wise. In our default roaring/ benchmarks, a few things get a few percent faster, or slower. The advantage is that, with read-heavy workloads, the row cache no longer eats up incredible amounts of memory. For a smallish test case, pilosa's memory usage (RES in top) after startup was ~2.5GB. Without this patch, simply reading every row a few times got memory usage to about 9GB, which seemed reasonably stable. With this patch, memory usage went to about 3GB. This will be less noticeable in mixed read/write loads, but it should be consistently significantly lower. In addition to dropping things from the rowCache on modifications, we also stopped performing a full count on a modified row when not using a cache of a kind that would use that count, and don't repopulate the rowCache regardless. We don't want every write to imply a corresponding read after it. There's a lot of room for possible future optimizations in terms of things like in-place operations, and some of the row/rowSegment code is a little suspicious to me, but I don't think it should be *worse* in any cases.
504 lines
12 KiB
Go
504 lines
12 KiB
Go
// Copyright 2017 Pilosa Corp.
|
|
//
|
|
// Licensed under the Apache License, Version 2.0 (the "License");
|
|
// you may not use this file except in compliance with the License.
|
|
// You may obtain a copy of the License at
|
|
//
|
|
// http://www.apache.org/licenses/LICENSE-2.0
|
|
//
|
|
// Unless required by applicable law or agreed to in writing, software
|
|
// distributed under the License is distributed on an "AS IS" BASIS,
|
|
// WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
|
|
// See the License for the specific language governing permissions and
|
|
// limitations under the License.
|
|
|
|
package pilosa
|
|
|
|
import (
|
|
"encoding/json"
|
|
"sort"
|
|
|
|
"github.com/pilosa/pilosa/roaring"
|
|
"github.com/pkg/errors"
|
|
)
|
|
|
|
// Row is a set of integers (the associated columns), and attributes which are
|
|
// arbitrary key/value pairs storing metadata about what the row represents.
|
|
type Row struct {
|
|
segments []rowSegment
|
|
|
|
// String keys translated to/from segment columns.
|
|
Keys []string
|
|
|
|
// Attributes associated with the row.
|
|
Attrs map[string]interface{}
|
|
}
|
|
|
|
// NewRow returns a new instance of Row.
|
|
func NewRow(columns ...uint64) *Row {
|
|
r := &Row{}
|
|
for _, i := range columns {
|
|
r.SetBit(i)
|
|
}
|
|
return r
|
|
}
|
|
|
|
// IsEmpty returns true if the row doesn't contain any set bits.
|
|
func (r *Row) IsEmpty() bool {
|
|
if len(r.segments) == 0 {
|
|
return true
|
|
}
|
|
for i := range r.segments {
|
|
if r.segments[i].n > 0 {
|
|
return false
|
|
}
|
|
|
|
}
|
|
return true
|
|
}
|
|
|
|
func (r *Row) Freeze() {
|
|
for _, s := range r.segments {
|
|
s.Freeze()
|
|
}
|
|
}
|
|
|
|
// Merge merges data from other into r.
|
|
func (r *Row) Merge(other *Row) {
|
|
var segments []rowSegment
|
|
|
|
itr := newMergeSegmentIterator(r.segments, other.segments)
|
|
for s0, s1 := itr.next(); s0 != nil || s1 != nil; s0, s1 = itr.next() {
|
|
// Use the other row's data if segment is missing.
|
|
if s0 == nil {
|
|
segments = append(segments, *s1)
|
|
continue
|
|
} else if s1 == nil {
|
|
segments = append(segments, *s0)
|
|
continue
|
|
}
|
|
|
|
// Otherwise merge.
|
|
s0.Merge(s1)
|
|
segments = append(segments, *s0)
|
|
}
|
|
|
|
r.segments = segments
|
|
r.invalidateCount()
|
|
}
|
|
|
|
// intersectionCount returns the number of intersections between r and other.
|
|
func (r *Row) intersectionCount(other *Row) uint64 {
|
|
var n uint64
|
|
|
|
itr := newMergeSegmentIterator(r.segments, other.segments)
|
|
for s0, s1 := itr.next(); s0 != nil || s1 != nil; s0, s1 = itr.next() {
|
|
// Ignore non-overlapping segments.
|
|
if s0 == nil || s1 == nil {
|
|
continue
|
|
}
|
|
|
|
n += s0.IntersectionCount(s1)
|
|
}
|
|
return n
|
|
}
|
|
|
|
// Intersect returns the itersection of r and other.
|
|
func (r *Row) Intersect(other *Row) *Row {
|
|
var segments []rowSegment
|
|
|
|
itr := newMergeSegmentIterator(r.segments, other.segments)
|
|
for s0, s1 := itr.next(); s0 != nil || s1 != nil; s0, s1 = itr.next() {
|
|
// Ignore non-overlapping segments.
|
|
if s0 == nil || s1 == nil {
|
|
continue
|
|
}
|
|
segments = append(segments, *s0.Intersect(s1))
|
|
}
|
|
|
|
return &Row{segments: segments}
|
|
}
|
|
|
|
// Any returns true if row contains any bits.
|
|
func (r *Row) Any() bool {
|
|
for _, s := range r.segments {
|
|
if s.data.Any() {
|
|
return true
|
|
}
|
|
}
|
|
return false
|
|
}
|
|
|
|
// Xor returns the xor of r and other.
|
|
func (r *Row) Xor(other *Row) *Row {
|
|
var segments []rowSegment
|
|
|
|
itr := newMergeSegmentIterator(r.segments, other.segments)
|
|
for s0, s1 := itr.next(); s0 != nil || s1 != nil; s0, s1 = itr.next() {
|
|
if s1 == nil {
|
|
segments = append(segments, *s0)
|
|
continue
|
|
} else if s0 == nil {
|
|
segments = append(segments, *s1)
|
|
continue
|
|
}
|
|
|
|
segments = append(segments, *s0.Xor(s1))
|
|
}
|
|
|
|
return &Row{segments: segments}
|
|
}
|
|
|
|
// Union returns the bitwise union of r and other.
|
|
func (r *Row) Union(other *Row) *Row {
|
|
var segments []rowSegment
|
|
itr := newMergeSegmentIterator(r.segments, other.segments)
|
|
for s0, s1 := itr.next(); s0 != nil || s1 != nil; s0, s1 = itr.next() {
|
|
if s1 == nil {
|
|
segments = append(segments, *s0)
|
|
continue
|
|
} else if s0 == nil {
|
|
segments = append(segments, *s1)
|
|
continue
|
|
}
|
|
segments = append(segments, *s0.Union(s1))
|
|
}
|
|
|
|
return &Row{segments: segments}
|
|
}
|
|
|
|
// Difference returns the diff of r and other.
|
|
func (r *Row) Difference(other *Row) *Row {
|
|
var segments []rowSegment
|
|
|
|
itr := newMergeSegmentIterator(r.segments, other.segments)
|
|
for s0, s1 := itr.next(); s0 != nil || s1 != nil; s0, s1 = itr.next() {
|
|
if s0 == nil {
|
|
continue
|
|
} else if s1 == nil {
|
|
segments = append(segments, *s0)
|
|
continue
|
|
}
|
|
segments = append(segments, *s0.Difference(s1))
|
|
}
|
|
|
|
return &Row{segments: segments}
|
|
}
|
|
|
|
// Shift returns the bitwise shift of r by n bits.
|
|
// Currently only positive shift values are supported.
|
|
func (r *Row) Shift(n int64) (*Row, error) {
|
|
if n < 0 {
|
|
return nil, errors.New("cannot shift by negative values")
|
|
} else if n == 0 {
|
|
return r, nil
|
|
}
|
|
|
|
work := r
|
|
var segments []rowSegment
|
|
for i := int64(0); i < n; i++ {
|
|
segments = segments[:0]
|
|
for _, segment := range work.segments {
|
|
shifted, err := segment.Shift()
|
|
if err != nil {
|
|
return nil, errors.Wrap(err, "shifting row segment")
|
|
}
|
|
segments = append(segments, *shifted)
|
|
}
|
|
work = &Row{segments: segments}
|
|
}
|
|
|
|
return work, nil
|
|
}
|
|
|
|
// SetBit sets the i-th column of the row.
|
|
func (r *Row) SetBit(i uint64) (changed bool) {
|
|
return r.createSegmentIfNotExists(i / ShardWidth).SetBit(i)
|
|
}
|
|
|
|
// Segments returns a list of all segments in the row.
|
|
func (r *Row) Segments() []rowSegment {
|
|
return r.segments
|
|
}
|
|
|
|
// segment returns a segment for a given shard.
|
|
// Returns nil if segment does not exist.
|
|
func (r *Row) segment(shard uint64) *rowSegment {
|
|
if i := sort.Search(len(r.segments), func(i int) bool {
|
|
return r.segments[i].shard >= shard
|
|
}); i < len(r.segments) && r.segments[i].shard == shard {
|
|
return &r.segments[i]
|
|
}
|
|
return nil
|
|
}
|
|
|
|
func (r *Row) createSegmentIfNotExists(shard uint64) *rowSegment {
|
|
i := sort.Search(len(r.segments), func(i int) bool {
|
|
return r.segments[i].shard >= shard
|
|
})
|
|
|
|
// Return exact match.
|
|
if i < len(r.segments) && r.segments[i].shard == shard {
|
|
return &r.segments[i]
|
|
}
|
|
|
|
// Insert new segment.
|
|
r.segments = append(r.segments, rowSegment{data: roaring.NewSliceBitmap()})
|
|
if i < len(r.segments) {
|
|
copy(r.segments[i+1:], r.segments[i:])
|
|
}
|
|
r.segments[i] = rowSegment{
|
|
data: roaring.NewSliceBitmap(),
|
|
shard: shard,
|
|
writable: true,
|
|
}
|
|
|
|
return &r.segments[i]
|
|
}
|
|
|
|
// invalidateCount updates the cached count in the row.
|
|
func (r *Row) invalidateCount() {
|
|
for i := range r.segments {
|
|
r.segments[i].InvalidateCount()
|
|
}
|
|
}
|
|
|
|
// Count returns the number of columns in the row.
|
|
func (r *Row) Count() uint64 {
|
|
var n uint64
|
|
for i := range r.segments {
|
|
n += r.segments[i].Count()
|
|
}
|
|
return n
|
|
}
|
|
|
|
// MarshalJSON returns a JSON-encoded byte slice of r.
|
|
func (r *Row) MarshalJSON() ([]byte, error) {
|
|
var o struct {
|
|
Attrs map[string]interface{} `json:"attrs"`
|
|
Columns []uint64 `json:"columns"`
|
|
Keys []string `json:"keys,omitempty"`
|
|
}
|
|
o.Columns = r.Columns()
|
|
o.Keys = r.Keys
|
|
|
|
o.Attrs = r.Attrs
|
|
if o.Attrs == nil {
|
|
o.Attrs = make(map[string]interface{})
|
|
}
|
|
|
|
return json.Marshal(&o)
|
|
}
|
|
|
|
// Columns returns the columns in r as a slice of ints.
|
|
func (r *Row) Columns() []uint64 {
|
|
a := make([]uint64, 0, r.Count())
|
|
for i := range r.segments {
|
|
a = append(a, r.segments[i].Columns()...)
|
|
}
|
|
return a
|
|
}
|
|
|
|
// rowSegment holds a subset of a row.
|
|
// This could point to a mmapped roaring bitmap or an in-memory bitmap. The
|
|
// width of the segment will always match the shard width.
|
|
type rowSegment struct {
|
|
// Shard this segment belongs to
|
|
shard uint64
|
|
|
|
// Underlying raw bitmap implementation.
|
|
// This is an mmapped bitmap if writable is false. Otherwise
|
|
// it is a heap allocated bitmap which can be manipulated.
|
|
data *roaring.Bitmap
|
|
writable bool
|
|
|
|
// Bit count
|
|
n uint64
|
|
}
|
|
|
|
func (s *rowSegment) Freeze() {
|
|
s.data.Freeze()
|
|
}
|
|
|
|
// Merge adds chunks from other to s.
|
|
// Chunks in s are overwritten if they exist in other.
|
|
func (s *rowSegment) Merge(other *rowSegment) {
|
|
s.ensureWritable()
|
|
|
|
itr := other.data.Iterator()
|
|
for v, eof := itr.Next(); !eof; v, eof = itr.Next() {
|
|
s.SetBit(v)
|
|
}
|
|
}
|
|
|
|
// IntersectionCount returns the number of intersections between s and other.
|
|
func (s *rowSegment) IntersectionCount(other *rowSegment) uint64 {
|
|
return s.data.IntersectionCount(other.data)
|
|
}
|
|
|
|
// Intersect returns the itersection of s and other.
|
|
func (s *rowSegment) Intersect(other *rowSegment) *rowSegment {
|
|
data := s.data.Intersect(other.data)
|
|
data.Freeze()
|
|
|
|
return &rowSegment{
|
|
data: data,
|
|
shard: s.shard,
|
|
n: data.Count(),
|
|
writable: true,
|
|
}
|
|
}
|
|
|
|
// Union returns the bitwise union of s and other.
|
|
func (s *rowSegment) Union(other *rowSegment) *rowSegment {
|
|
data := s.data.Union(other.data)
|
|
data.Freeze()
|
|
|
|
return &rowSegment{
|
|
data: data,
|
|
shard: s.shard,
|
|
n: data.Count(),
|
|
writable: true,
|
|
}
|
|
}
|
|
|
|
// Difference returns the diff of s and other.
|
|
func (s *rowSegment) Difference(other *rowSegment) *rowSegment {
|
|
data := s.data.Difference(other.data)
|
|
data.Freeze()
|
|
|
|
return &rowSegment{
|
|
data: data,
|
|
shard: s.shard,
|
|
n: data.Count(),
|
|
writable: true,
|
|
}
|
|
}
|
|
|
|
// Xor returns the xor of s and other.
|
|
func (s *rowSegment) Xor(other *rowSegment) *rowSegment {
|
|
data := s.data.Xor(other.data)
|
|
data.Freeze()
|
|
|
|
return &rowSegment{
|
|
data: data,
|
|
shard: s.shard,
|
|
n: data.Count(),
|
|
writable: true,
|
|
}
|
|
}
|
|
|
|
// Shift returns s shifted by 1 bit.
|
|
func (s *rowSegment) Shift() (*rowSegment, error) {
|
|
//TODO deal with overflow
|
|
data, err := s.data.Shift(1)
|
|
if err != nil {
|
|
return nil, errors.Wrap(err, "shifting roaring data")
|
|
}
|
|
data.Freeze()
|
|
|
|
return &rowSegment{
|
|
data: data,
|
|
shard: s.shard,
|
|
n: data.Count(),
|
|
writable: true,
|
|
}, nil
|
|
}
|
|
|
|
// SetBit sets the i-th column of the row.
|
|
func (s *rowSegment) SetBit(i uint64) (changed bool) {
|
|
s.ensureWritable()
|
|
changed, _ = s.data.Add(i)
|
|
if changed {
|
|
s.n++
|
|
}
|
|
return changed
|
|
}
|
|
|
|
// ClearBit clears the i-th column of the row.
|
|
func (s *rowSegment) ClearBit(i uint64) (changed bool) {
|
|
s.ensureWritable()
|
|
|
|
changed, _ = s.data.Remove(i)
|
|
if changed {
|
|
s.n--
|
|
}
|
|
return changed
|
|
}
|
|
|
|
// InvalidateCount updates the cached count in the row.
|
|
func (s *rowSegment) InvalidateCount() {
|
|
s.n = s.data.Count()
|
|
}
|
|
|
|
// Columns returns a list of all columns set in the segment.
|
|
func (s *rowSegment) Columns() []uint64 {
|
|
a := make([]uint64, 0, s.Count())
|
|
itr := s.data.Iterator()
|
|
for v, eof := itr.Next(); !eof; v, eof = itr.Next() {
|
|
a = append(a, v)
|
|
}
|
|
return a
|
|
}
|
|
|
|
// Count returns the number of set columns in the row.
|
|
func (s *rowSegment) Count() uint64 { return s.n }
|
|
|
|
// ensureWritable clones the segment if it is pointing to non-writable data.
|
|
func (s *rowSegment) ensureWritable() {
|
|
if s.writable {
|
|
return
|
|
}
|
|
|
|
// This doesn't actually clone all the containers, but does clone
|
|
// the bitmap itself -- we get a new bitmap, but it just marks the
|
|
// containers as frozen and shares them. It's now safe to write to
|
|
// this bitmap, but the actual containers are copy-on-write.
|
|
s.data = s.data.Freeze()
|
|
s.writable = true
|
|
}
|
|
|
|
// mergeSegmentIterator produces an iterator that loops through two sets of segments.
|
|
type mergeSegmentIterator struct {
|
|
a0, a1 []rowSegment
|
|
}
|
|
|
|
// newMergeSegmentIterator returns a new instance of mergeSegmentIterator.
|
|
func newMergeSegmentIterator(a0, a1 []rowSegment) mergeSegmentIterator {
|
|
return mergeSegmentIterator{a0: a0, a1: a1}
|
|
}
|
|
|
|
// next returns the next set of segments.
|
|
func (itr *mergeSegmentIterator) next() (s0, s1 *rowSegment) {
|
|
// Find current segments.
|
|
if len(itr.a0) > 0 {
|
|
s0 = &itr.a0[0]
|
|
}
|
|
if len(itr.a1) > 0 {
|
|
s1 = &itr.a1[0]
|
|
}
|
|
|
|
// Return if either or both are nil.
|
|
if s0 == nil && s1 == nil {
|
|
return
|
|
} else if s0 == nil {
|
|
itr.a1 = itr.a1[1:]
|
|
return
|
|
} else if s1 == nil {
|
|
itr.a0 = itr.a0[1:]
|
|
return
|
|
}
|
|
|
|
// Otherwise determine which is first.
|
|
if s0.shard < s1.shard {
|
|
itr.a0 = itr.a0[1:]
|
|
return s0, nil
|
|
} else if s0.shard > s1.shard {
|
|
itr.a1 = itr.a1[1:]
|
|
return s1, nil
|
|
}
|
|
|
|
// Return both if shards are equal.
|
|
itr.a0, itr.a1 = itr.a0[1:], itr.a1[1:]
|
|
return s0, s1
|
|
}
|