No description
Find a file
Seebs 244d80753e reuse clients instead of making new clients
Buckle in, this one's a ride.

This is attached to the same PR as a fix for exiting abruptly
during some tests because I ran into that issue, and comprehended
it, while trying to track down weird and sporadic test failures
that were actually this issue.

The actual, underlying, problem: `make test`, by running all the
tests at once, was hitting a bug that was mostly effectively
triggered by running the `dax/test/dax` tests, and the top-level
`featurebase/v3` tests, at the same time. However, the interaction
was nothing as obvious as temporary files, etcd configuration,
or whatever.

We were running out of port numbers.

The tests were using a bit over 30k simultaneous established TCP
connections, each to different ports, because we were creating
new clients for basically every single operation. For instance,
in a single SQL test that did an import and then a read, we
were creating a new client for each field written to, and then
also creating a new client for each field in results that needed
key translation. And none of these clients were closed or
timed out in any way. In fact, Go doesn't really *do* "closing"
of clients; the closest is that an http.Client can be told to
close idle connections that it has been keeping open.

The worst offenders were both named `fbClient`, and were nigh-identical,
except one of them was implemented as a method on `importer` in the
IDK tree, and one was a standalone function.

It may seem surprising that the method on `importer` is using a shared
client pool for all importers, rather than a new pool for each
importer. This is because we potentially make quite a few importers
during tests.

Before this, running either of the dax tests or the top-level
tests would show well over ten thousand simultaneous ESTABLISHED
connections. After this, the dax tests used nearly twenty.

The problem with port consumption like this, while more noticeable
on MacOS, is also something we could hit on the CI runners, especially
if a single runner ended up with more than one test suite running
at the same time. This probably manifests as sporadic very strange
failures of CI, with messages about "cannot assign requested address".
(Note that an outgoing connection to a successfully-created port
requires *another* port to be assigned for the outbound socket.)

This was complicated dramatically by the fact that, for some
utterly cursed reason, it was *especially* common for the point
at which we hit this, in the top-level featurebase tests, to be
running one of the backup tests in TestVariousQueries, and
specifically, to be hitting it on the dataframe part of the
backup... Which is to say, on the *one* path in the backup function
that called log.Fatal, and thus terminated the featurebase process
abruptly without further commentary.
2023-03-06 13:12:22 -06:00
.github/workflows Stop go test in GitHub CI 2023-01-23 13:48:24 -07:00
.gitlab Remove pre_clone_script 2023-03-02 17:24:43 -07:00
api/client enable staticcheck in ci; remove dead code (#2281) 2022-11-15 11:33:12 -08:00
authn Dataframe (#2241) 2022-12-12 09:01:20 -08:00
authz fix: updating code to meet linting requirements (#2171) 2022-09-29 12:34:29 -04:00
batch Use the correct epoch when converting field.Options.Base to timestamp (#2241) 2023-02-10 17:13:09 -06:00
buffer limit memory for backuptar/restoretar (#2270) 2023-02-23 18:35:52 -06:00
bufferpool implemented DISTINCT (fb-1562) (#2388) 2023-01-10 23:28:00 +00:00
cli Use json.Number decoder to handle large ints in sql wire protocol (#2285) 2023-03-02 14:49:55 -06:00
client Support for setting individual DatabaseOptions (#2231) 2023-02-06 08:50:28 -06:00
cmd Reverted some testing log messages and commented out code 2023-03-01 21:43:53 -08:00
context implement fb_exec_requests system table (#2327) 2022-12-12 09:01:20 -08:00
ctl don't use things that instantly exit in a code path tests hit 2023-03-06 13:12:22 -06:00
dax reuse clients instead of making new clients 2023-03-06 13:12:22 -06:00
debugstats Updated code to latest version for open-sourcing. 2022-09-02 13:23:39 -07:00
disco controller commit to DB first then send directives (#2259) 2023-02-17 09:12:15 -06:00
encoding/proto Sup 294 pre sort command (#2209) 2023-01-23 12:26:38 -06:00
errors Cloud 1359 errors across http (#2279) 2023-02-27 16:34:51 -05:00
etcd enforce int min/max constraints on insert (fb-1772) (#2325) 2022-12-12 09:01:20 -08:00
extendiblehash fix import paths 2023-01-11 18:59:24 +00:00
gcnotify Updated dependency paths to reflect new repo location 2022-09-06 09:39:22 -07:00
generator Updated code to latest version for open-sourcing. 2022-09-02 13:23:39 -07:00
gopsutil Updated dependency paths to reflect new repo location 2022-09-06 09:39:22 -07:00
hash fix: updating code to meet linting requirements (#2171) 2022-09-29 12:34:29 -04:00
idk reuse clients instead of making new clients 2023-03-06 13:12:22 -06:00
install Packaging improvements to improve mcloud updates (#2288) 2022-11-15 11:33:12 -08:00
internal Sup 294 pre sort command (#2209) 2023-01-23 12:26:38 -06:00
lattice Bump minimist from 1.2.5 to 1.2.8 in /lattice (#2289) 2023-03-03 16:09:14 -06:00
logger tweak a bunch of logging and config (#2234) 2023-02-03 14:59:07 -06:00
lru Updated code to latest version for open-sourcing. 2022-09-02 13:23:39 -07:00
mock Updated dependency paths to reflect new repo location 2022-09-06 09:39:22 -07:00
monitor Updated code to latest version for open-sourcing. 2022-09-02 13:23:39 -07:00
net staticcheck fixes (#2278) 2022-11-15 11:33:10 -08:00
pb [FB-1776] support for marshaling ExtractedIDMatrixSorted (#2319) 2022-12-12 09:01:20 -08:00
pql SUP-302 (#2243) 2023-02-22 11:30:14 -06:00
prometheus Sup 294 pre sort command (#2209) 2023-01-23 12:26:38 -06:00
proto Sup 294 pre sort command (#2209) 2023-01-23 12:26:38 -06:00
qa Rename some interfaces. Remove the ComputeAPI (#2333) 2022-12-12 09:01:20 -08:00
querycontext bump timeout on overlapping write requests test 2022-12-12 09:01:20 -08:00
rbf adding more error handling for rbf (#2395) 2023-01-10 23:28:09 +00:00
roaring Sup 294 pre sort command (#2209) 2023-01-23 12:26:38 -06:00
runners feat: builds docker images for running featurebase from a release (#2193) 2022-11-08 13:07:17 -05:00
scripts Updated code to latest version for open-sourcing. 2022-09-02 13:23:39 -07:00
server fb-2013 removing sql feature flag entirely. (#2283) 2023-03-01 15:12:04 -05:00
shardwidth feat: updates shardwidth.Exponent to single constant (#2185) 2022-10-25 13:30:00 -04:00
short_txkey staticcheck fixes (#2278) 2022-11-15 11:33:10 -08:00
sql Fixed some import issues resulting from syncing the private repo 2022-11-17 08:58:22 -08:00
sql3 fb-1915 Support large id's in NDJSON (#2290) 2023-03-03 15:37:56 -06:00
statik staticcheck fixes (#2278) 2022-11-15 11:33:10 -08:00
stats introduce performance counters and system table fanout, plus refactor metrics (#2363) 2023-01-19 21:35:02 +00:00
storage Updated code to latest version for open-sourcing. 2022-09-02 13:23:39 -07:00
systemlayer try to make sure we're releasing large allocations (#2225) 2023-01-25 14:48:01 -06:00
syswrap Updated code to latest version for open-sourcing. 2022-09-02 13:23:39 -07:00
task task pool: avoid race condition on shutdown/close 2023-02-17 11:32:07 -06:00
test Sync from private repo to commit 12d608c80d 2022-12-12 09:01:20 -08:00
testdata refactor testing to share clusters more often 2022-09-30 11:10:47 -07:00
testhook improve post-hook behavior 2022-09-30 11:10:47 -07:00
toml Updated code to latest version for open-sourcing. 2022-09-02 13:23:39 -07:00
tracing Updated dependency paths to reflect new repo location 2022-09-06 09:39:22 -07:00
txkey staticcheck fixes (#2278) 2022-11-15 11:33:10 -08:00
vprint Updated code to latest version for open-sourcing. 2022-09-02 13:23:39 -07:00
wireprotocol Use json.Number decoder to handle large ints in sql wire protocol (#2285) 2023-03-02 14:49:55 -06:00
.gitignore added test for inserts with timestamp + constraints (#2244) 2023-02-13 16:15:59 -06:00
.golangci.yml Sup 294 pre sort command (#2209) 2023-01-23 12:26:38 -06:00
api.go CLI: make it more like psql (#2235) 2023-02-14 09:23:51 -06:00
api_directive.go Support for setting individual DatabaseOptions (#2231) 2023-02-06 08:50:28 -06:00
api_directive_internal_test.go Add DAX - full list of squashed commits below 2022-12-12 09:01:20 -08:00
api_directive_test.go Database isolation: Balancer (#2407) 2023-01-19 22:10:08 +00:00
api_test.go Don't use reflect.DeepEqual to compare errors. 2022-12-12 09:01:20 -08:00
apimethod_string.go Drop the ingest subpackage and related endpoints. 2022-11-15 11:31:10 -08:00
apply.go Sup 294 pre sort command (#2209) 2023-01-23 12:26:38 -06:00
arrow.go fb-1915 Support large id's in NDJSON (#2290) 2023-03-03 15:37:56 -06:00
arrow_test.go [FB-1822] Change dataframe disk format to Arrow from parquet (#2376) 2023-01-10 23:22:58 +00:00
audit.go Updated dependency paths to reflect new repo location 2022-09-06 09:39:22 -07:00
audit_internal_test.go Updated dependency paths to reflect new repo location 2022-09-06 09:39:22 -07:00
audit_test.go fix import paths and import cycles 2023-01-12 00:31:14 +00:00
broadcast.go Dataframe (#2241) 2022-12-12 09:01:20 -08:00
bsi.go Add DAX - full list of squashed commits below 2022-12-12 09:01:20 -08:00
bsi_test.go Add DAX - full list of squashed commits below 2022-12-12 09:01:20 -08:00
cache.go fix go deps, add lattice 2023-01-20 02:11:00 +00:00
cache_test.go fix import paths and import cycles 2023-01-12 00:31:14 +00:00
catcher.go Add DAX - full list of squashed commits below 2022-12-12 09:01:20 -08:00
cluster.go linter directive should not have space (dummy commit to trigger CI) (#2228) 2023-01-25 17:00:23 -06:00
cluster_internal_test.go drop anti-entropy feature, since it doesn't work 2022-11-15 11:31:13 -08:00
CODE_OF_CONDUCT.md Updated code to latest version for open-sourcing. 2022-09-02 13:23:39 -07:00
const_amd64.go Updated code to latest version for open-sourcing. 2022-09-02 13:23:39 -07:00
const_other.go Updated code to latest version for open-sourcing. 2022-09-02 13:23:39 -07:00
dataframe_test.go string support for dataframe (#2405) 2023-01-19 21:51:16 +00:00
dbshard.go staticcheck fixes (#2278) 2022-11-15 11:33:10 -08:00
dbshard_internal_test.go merge: featurebase merge updates for 2022-10-28 (#2188) 2022-10-28 13:08:23 -04:00
dbshard_test.go cleaned up sync from private repo 2022-09-30 11:20:58 -07:00
delete_test.go refactor testing to share clusters more often 2022-09-30 11:10:47 -07:00
diagnostics.go Updated dependency paths to reflect new repo location 2022-09-06 09:39:22 -07:00
diagnostics_internal_test.go tweak a bunch of logging and config (#2234) 2023-02-03 14:59:07 -06:00
doc.go Updated code to latest version for open-sourcing. 2022-09-02 13:23:39 -07:00
Dockerfile Make SOURCE_DATE_EPOCH changes for idk 2022-12-12 09:01:20 -08:00
Dockerfile-clustertests introduce performance counters and system table fanout, plus refactor metrics (#2363) 2023-01-19 21:35:02 +00:00
Dockerfile-clustertests-client introduce performance counters and system table fanout, plus refactor metrics (#2363) 2023-01-19 21:35:02 +00:00
Dockerfile-datagen Add DAX - full list of squashed commits below 2022-12-12 09:01:20 -08:00
Dockerfile-dax move DD profiling/tracing setup into command where it belongs (#2233) 2023-02-01 16:20:39 -06:00
Dockerfile-dax-quick Add DAX - full list of squashed commits below 2022-12-12 09:01:20 -08:00
et_test.go Sync from private repo to commit 12d608c80d 2022-12-12 09:01:20 -08:00
event.go Updated dependency paths to reflect new repo location 2022-09-06 09:39:22 -07:00
executor.go A bug fix roundup (#2242) 2023-02-13 12:28:34 -06:00
executor_internal_test.go Dataframe (#2241) 2022-12-12 09:01:20 -08:00
executor_test.go actually yield checksums to caller 2023-03-01 12:48:00 -06:00
field.go fix go deps, add lattice 2023-01-20 02:11:00 +00:00
field_internal_test.go use separate qcx for write/read in test 2023-01-10 23:22:58 +00:00
field_test.go merge: featurebase merge updates for 2022-10-28 (#2188) 2022-10-28 13:08:23 -04:00
filesystem.go Updated code to latest version for open-sourcing. 2022-09-02 13:23:39 -07:00
fragment.go fix go deps, add lattice 2023-01-20 02:11:00 +00:00
fragment_internal_test.go drop anti-entropy feature, since it doesn't work 2022-11-15 11:31:13 -08:00
gc.go Updated code to latest version for open-sourcing. 2022-09-02 13:23:39 -07:00
gid.go Updated code to latest version for open-sourcing. 2022-09-02 13:23:39 -07:00
go.mod Bump golang.org/x/net from 0.2.0 to 0.7.0 2023-03-02 13:21:48 -06:00
go.sum Bump golang.org/x/net from 0.2.0 to 0.7.0 2023-03-02 13:21:48 -06:00
hack.go Sup 294 pre sort command (#2209) 2023-01-23 12:26:38 -06:00
handler.go Don't use reflect.DeepEqual to compare errors. 2022-12-12 09:01:20 -08:00
handler_test.go Don't use reflect.DeepEqual to compare errors. 2022-12-12 09:01:20 -08:00
holder.go controller commit to DB first then send directives (#2259) 2023-02-17 09:12:15 -06:00
holder_internal_test.go merge: featurebase merge updates for 2022-10-28 (#2188) 2022-10-28 13:08:23 -04:00
holder_test.go Fixed a few more conflicts around imports with the latest sync 2022-11-17 10:00:53 -08:00
http_handler.go Use json.Number decoder to handle large ints in sql wire protocol (#2285) 2023-03-02 14:49:55 -06:00
http_handler_internal_test.go fix: updating code to meet linting requirements (#2171) 2022-09-29 12:34:29 -04:00
http_handler_test.go fb-2013 removing sql feature flag entirely. (#2283) 2023-03-01 15:12:04 -05:00
http_translator.go fix: updating code to meet linting requirements (#2171) 2022-09-29 12:34:29 -04:00
http_translator_test.go merge: featurebase merge updates for 2022-10-28 (#2188) 2022-10-28 13:08:23 -04:00
idalloc.go Updated code to latest version for open-sourcing. 2022-09-02 13:23:39 -07:00
idalloc_test.go Updated dependency paths to reflect new repo location 2022-09-06 09:39:22 -07:00
importer.go introduce performance counters and system table fanout, plus refactor metrics (#2363) 2023-01-19 21:35:02 +00:00
index.go fix go deps, add lattice 2023-01-20 02:11:00 +00:00
index_internal_test.go merge: featurebase merge updates for 2022-10-28 (#2188) 2022-10-28 13:08:23 -04:00
index_test.go don't use things that instantly exit in a code path tests hit 2023-03-06 13:12:22 -06:00
internal_client.go use primary as source for FieldTranslate backup data (#2255) 2023-02-16 12:13:11 -06:00
internal_client_test.go Sync from private repo to commit 12d608c80d 2022-12-12 09:01:20 -08:00
iterator.go Sup 294 pre sort command (#2209) 2023-01-23 12:26:38 -06:00
iterator_internal_test.go Updated code to latest version for open-sourcing. 2022-09-02 13:23:39 -07:00
LICENSE update license to full license 2023-01-12 18:23:09 -06:00
LICENSE-2.0.txt Updated code to latest version for open-sourcing. 2022-09-02 13:23:39 -07:00
license.exceptions Updated code to latest version for open-sourcing. 2022-09-02 13:23:39 -07:00
like.go Updated code to latest version for open-sourcing. 2022-09-02 13:23:39 -07:00
like_test.go Updated code to latest version for open-sourcing. 2022-09-02 13:23:39 -07:00
main_test.go use testhook test cleanup 2022-09-30 11:25:27 -07:00
Makefile force count to 1 to disable test caching 2023-03-01 12:48:00 -06:00
metrics.go introduce performance counters and system table fanout, plus refactor metrics (#2363) 2023-01-19 21:35:02 +00:00
nfpm.yaml Build target also builds fbsql, fbsql is also packaged. (#2260) 2023-02-21 08:55:27 -08:00
NOTICE Updated code to latest version for open-sourcing. 2022-09-02 13:23:39 -07:00
performancecounters.go introduce performance counters and system table fanout, plus refactor metrics (#2363) 2023-01-19 21:35:02 +00:00
pilosa.go SUP-302 (#2243) 2023-02-22 11:30:14 -06:00
pilosa_internal_test.go Updated dependency paths to reflect new repo location 2022-09-06 09:39:22 -07:00
pilosa_test.go SUP-302 (#2243) 2023-02-22 11:30:14 -06:00
pprof.go Updated dependency paths to reflect new repo location 2022-09-06 09:39:22 -07:00
rbf.go adding more error handling for rbf (#2395) 2023-01-10 23:28:09 +00:00
README.md docs migration link changes (#2247) 2023-02-14 17:28:08 -06:00
row.go introduce performance counters and system table fanout, plus refactor metrics (#2363) 2023-01-19 21:35:02 +00:00
row_test.go fix import paths and import cycles 2023-01-12 00:31:14 +00:00
schema.go implement select from time quantum columns (fb-1654) (#2282) 2023-03-02 00:06:58 -06:00
serializer.go Updated code to latest version for open-sourcing. 2022-09-02 13:23:39 -07:00
server.go Fb 1975 (#2254) 2023-02-17 13:50:45 -06:00
server_internal_test.go drop anti-entropy feature, since it doesn't work 2022-11-15 11:31:13 -08:00
server_test.go refactor testing to share clusters more often 2022-09-30 11:10:47 -07:00
sql_test.go Sync from private repo to commit 12d608c80d 2022-12-12 09:01:20 -08:00
stattx.go drop anti-entropy feature, since it doesn't work 2022-11-15 11:31:13 -08:00
systemlayer.go implement fb_exec_requests system table (#2327) 2022-12-12 09:01:20 -08:00
time.go staticcheck fixes (#2278) 2022-11-15 11:33:10 -08:00
time_internal_test.go Updated code to latest version for open-sourcing. 2022-09-02 13:23:39 -07:00
tracker.go Updated code to latest version for open-sourcing. 2022-09-02 13:23:39 -07:00
tracker_test.go Updated code to latest version for open-sourcing. 2022-09-02 13:23:39 -07:00
transaction.go Updated dependency paths to reflect new repo location 2022-09-06 09:39:22 -07:00
transaction_test.go Sync from private repo to commit 12d608c80d 2022-12-12 09:01:20 -08:00
translate.go improve ramdisk config in Makefile, use it for everything in tests 2023-02-22 13:19:06 -06:00
translate_boltdb.go fb-1915 Support large id's in NDJSON (#2290) 2023-03-03 15:37:56 -06:00
translate_boltdb_internal_test.go remove in mem translate store 2023-01-10 23:23:18 +00:00
translate_boltdb_test.go resolve go vet errors related to redeclares 2023-01-12 20:32:49 +00:00
translator_test.go resolve go vet errors related to redeclares 2023-01-12 20:32:49 +00:00
tx.go drop anti-entropy feature, since it doesn't work 2022-11-15 11:31:13 -08:00
tx_internal_test.go significant refactor of test setup and teardown 2022-09-30 11:25:27 -07:00
tx_test.go Fixed a few more conflicts around imports with the latest sync 2022-11-17 10:00:53 -08:00
txfactory.go Add DAX - full list of squashed commits below 2022-12-12 09:01:20 -08:00
txfactory_internal_test.go Updated code to latest version for open-sourcing. 2022-09-02 13:23:39 -07:00
util.go continue removing Tx parameters to view-type functions 2022-09-30 11:25:27 -07:00
util_test.go Updated code to latest version for open-sourcing. 2022-09-02 13:23:39 -07:00
utils_internal_test.go refactor testing to share clusters more often 2022-09-30 11:10:47 -07:00
verchk.go Fb 1975 (#2254) 2023-02-17 13:50:45 -06:00
version.go Updated code to latest version for open-sourcing. 2022-09-02 13:23:39 -07:00
view.go fix go deps, add lattice 2023-01-20 02:11:00 +00:00
view_internal_test.go significant refactor of test setup and teardown 2022-09-30 11:25:27 -07:00
wire_response.go fb-1915 Support large id's in NDJSON (#2290) 2023-03-03 15:37:56 -06:00

FeatureBase

Pilosa is now FeatureBase

As of September 7, 2022, the Pilosa project is now FeatureBase. The core of the project remains the same: FeatureBase is the first real-time distributed database built entirely on bitmaps. (More information about updated capabilities and improvements below.)

FeatureBase delivers low-latency query results, regardless of throughput or query volumes, on fresh data with extreme efficiency. It works because bitmaps are faster, simpler, and far more I/O efficient than traditional column-oriented data formats. With FeatureBase, you can ingest data from batch data sources (e.g. S3, CSV, Snowflake, BigQuery, etc.) and/or streaming data sources (e.g. Kafka/Confluent, Kinesis, Pulsar).

For more information about FeatureBase, please visit www.featurebase.com.

Getting Started

Build FeatureBase Server from source

  1. Install go. Ensure that your shell's search path includes the go/bin directory.
  2. Clone the FeatureBase repository (or download as zip).
  3. In the featurebase directory, run make install to compile the FeatureBase server binary. By default, it will be installed in the go/bin directory.
  4. In the idk directory, run make install to compile the ingester binaries. By default, they will be installed in the go/bin directory.
  5. Run featurebase server --handler.allowed-origins=http://localhost:3000 to run FeatureBase server with default settings (learn more about configuring FeatureBase at the link below). The --handler.allowed-origins parameter allows the standalone web UI to talk to the server; this can be omitted if the web UI is not needed.
  6. Run curl localhost:10101/status to verify the server is running and accessible.

Ingest Data and Query

  1. Run
molecula-consumer-csv \
    --index repository \
    --header "language__ID_F,project_id__ID_F" \
    --id-field project_id \
    --batch-size 1000 \
    --files example.csv

This will ingest the example.csv file into a FeatureBase table called repository. If the table does not exist, it will be automatically created. Learn more about ingesting data into FeatureBase

  1. Query your data.
curl localhost:10101/index/repository/query \
     -X POST \
     -d 'Row(example=5)'

Learn about supported SQL, native Pilosa Query Language (PQL).

Data Model

Because FeatureBase is built on bitmaps, there is bit of a learning curve to grasp how your data is represented. Learn about Data Modeling.

More Information

Installation

Configuration

Community

You can email us at community@featurebase.com or learn more about contributing at https://www.featurebase.com/community.

Chat with us: https://discord.gg/FBn2vEp7Na

What's Changed Since the Pilosa Days?

A lot has changed since the days of Pilosa. This list highlights some new capabilites included in FeatureBase. We have also made signficant improvements to the performance, scalability, and stability of the FeatureBase product.

  • Query Languages: FeatureBase supports Pilosa Query Language (PQL), as well as SQL
  • Stream and Batch Ingest: Combine real-time data streams with batch historical data and act on it within milliseconds.
  • Mutable: Perform inserts, updates, and deletes at scale, in real time and on-the-fly. This is key for meeting data compliance requirements, and for reflecting the constantly-changing nature of high-volume data.
  • Multi-Valued Set Fields: Store multiple comma-delimited values within a single field while increasing query performance of counts, TopKs, etc.
  • Time Quantums: Setting a time quantum on a field creates extra views which allow ranged Row queries down to the time interval specified. For example, if the time quantum is set to YMD, ranged Row queries down to the granularity of a day are supported.
  • RBF storage backend: this is a new compressed bitmap format which improves performance in a number of ways: ACID support on a per shard basis, prevents issues with the number of open files, reduces memory allocation and lock contention for reads, provides more consistent garbage collection, and allows backups to run concurrently with writes. However, because of this change, Pilosa backup files cannot be restored into FeatureBase.

License

FeatureBase is licensed under the Apache License, Version 2.0