mirror of
https://github.com/featurebasedb/featurebase.git
synced 2026-09-07 09:05:55 +00:00
b7e9879526
This forward-ports a number of tests from the previous SQL implementation. The porting is approximate in a number of ways, and not all tests are implemented/tested yet. In particular, several tests are currently disabled because we don't support `limit n` constructs. The tests that were primarily tests of the parser have been brought forward as parser tests. One of them has been altered to add parentheses, because our parser interprets fld1 between 1 and 3 and fld2 = 2 as: fld1 between (1 and 3) and (fld2 = 2) which is invalid, while the old parser apparently interpreted it as: (fld1 between 1 and 3) and (fld2 = 2) We have not yet verified the SQL spec's requirements here, but sqlite agrees with our old parser, not our new parser, so this may be a regression. The old tests expected an INNER JOIN to suppress duplicate values. Our new code does not, which is consistent with other SQL implementations. This is a change, but the old behavior appears to have been wrong. (You can still suppress duplicate values by specifying DISTINCT.) In the previous implementations, a value like `count(*)` had `count(*)` as its column name. In the new implementation, it has an empty string as its column name. Related to this, the prior implementation allowed you to write select age, count(*) from grouper group by age having count > 1 but the new implementationt requires that to be spelled as having count(*) > 1 This is consistent with other SQL implementations, so I think the new behavior is correct. The behavior of SHOW COLUMNS and SHOW TABLES has changed, in that the specific results returned are significantly different. Perhaps more significantly, the old system spelled the former query as SHOW FIELDS, rather than SHOW COLUMNS. This may be considered a regression, in that `SHOW FIELDS` no longer works, and we should consider whether any hypothetical users might have been relying on the output of either of these. (I hope not, the new output is much better.) Some of the old tests (the ones in handler_test) were accommodated by adding a couple of specific test cases to existing tests, specifically: * handling timestamp values with `Z` rather than `+00:00` * a join with a WHERE clause referring to fields in both source tables We introduce a new "partial" comparison type, because there's no way for a test of `SHOW TABLES` to contain a correct table row, because `SHOW TABLES` includes timestamps from when tables were created. I'm not sure this is the right way to do this. We add corresponding changes to dax_test, because the DAX tree tests against the SQL tests. We change the returned types of field names and field types to plain strings, ironically because DAX needs this -- the test code in the DAX tree is getting them back as plain strings, rather than as dax.FieldName and dax.BaseType. The tests using `having` are commented out because they don't seem to be working, a ticket has been filed for this. Two of the tests that should return strings are instead returning untranslated integer IDs, but only for DAX, not for the regular SQL tests, and the `delete` test has been commented out for DAX-specific errors. If we merge this, the next step is to ticket those and address them separately. |
||
|---|---|---|
| .. | ||
| defs.go | ||
| defs_aggregate.go | ||
| defs_between.go | ||
| defs_binops.go | ||
| defs_bool.go | ||
| defs_bulkinsert.go | ||
| defs_cast.go | ||
| defs_create_table.go | ||
| defs_date_functions.go | ||
| defs_delete.go | ||
| defs_distinct.go | ||
| defs_filterpredicates.go | ||
| defs_groupby.go | ||
| defs_having.go | ||
| defs_in.go | ||
| defs_inserts.go | ||
| defs_join.go | ||
| defs_keyed.go | ||
| defs_keyed_insert.go | ||
| defs_like.go | ||
| defs_minmaxnegative.go | ||
| defs_null.go | ||
| defs_orderby.go | ||
| defs_select.go | ||
| defs_set_functions.go | ||
| defs_sql1.go | ||
| defs_string_functions.go | ||
| defs_subquery.go | ||
| defs_timequantum.go | ||
| defs_timestamp_literals.go | ||
| defs_top.go | ||
| defs_unkeyed.go | ||
| defs_unops.go | ||
| defs_views.go | ||
| types.go | ||