mirror of
https://github.com/featurebasedb/featurebase.git
synced 2026-09-05 16:15:56 +00:00
61783e5827
this is necessary as in some cases we want a low timeout (when we expect a quick response, e.g. with backup), but in others we may want a very long timeout (long running query). Now we have more granular control over timeouts so we can get things to fail more predictably in tests.
75 lines
3.2 KiB
Go
75 lines
3.2 KiB
Go
// Copyright 2021 Molecula Corp. All rights reserved.
|
|
package ctl
|
|
|
|
import (
|
|
"time"
|
|
|
|
"github.com/molecula/featurebase/v3/http"
|
|
"github.com/molecula/featurebase/v3/logger"
|
|
"github.com/molecula/featurebase/v3/server"
|
|
"github.com/pkg/errors"
|
|
"github.com/spf13/pflag"
|
|
)
|
|
|
|
// CommandWithTLSSupport is the interface for commands which has TLS settings
|
|
type CommandWithTLSSupport interface {
|
|
TLSHost() string
|
|
TLSConfiguration() server.TLSConfig
|
|
Logger() logger.Logger
|
|
}
|
|
|
|
// SetTLSConfig creates common TLS flags
|
|
func SetTLSConfig(flags *pflag.FlagSet, prefix string, certificatePath *string, certificateKeyPath *string, caCertPath *string, skipVerify *bool, enableClientVerification *bool) {
|
|
flags.StringVarP(certificatePath, prefix+"tls.certificate", "", "", "TLS certificate path (usually has the .crt or .pem extension)")
|
|
flags.StringVarP(certificateKeyPath, prefix+"tls.key", "", "", "TLS certificate key path (usually has the .key extension)")
|
|
flags.StringVarP(caCertPath, prefix+"tls.ca-certificate", "", "", "TLS CA certificate path (usually has the .pem extension)")
|
|
flags.BoolVarP(skipVerify, prefix+"tls.skip-verify", "", false, "Skip TLS certificate server verification (not secure)")
|
|
flags.BoolVarP(enableClientVerification, prefix+"tls.enable-client-verification", "", false, "Enable TLS certificate client verification for incoming connections")
|
|
}
|
|
|
|
// AnyClientOption can be either http.InternalClientOption or
|
|
// http.ClientOption. The internal options are specific to the
|
|
// featurebase client, whereas the client options are applied to the
|
|
// Go HTTP client that gets used under the hood.
|
|
type AnyClientOption interface{}
|
|
|
|
// commandClient returns a pilosa.InternalHTTPClient for the command
|
|
func commandClient(cmd CommandWithTLSSupport, opts ...AnyClientOption) (*http.InternalClient, error) {
|
|
internalopts, clientopts, err := separateOptions(opts...)
|
|
if err != nil {
|
|
return nil, errors.Wrap(err, "separating client options")
|
|
}
|
|
|
|
// we default dial timeout to 3s in commandClient, but prepend it
|
|
// to the option list so other options can override it.
|
|
clientopts = append([]http.ClientOption{http.ClientDialTimeoutOption(time.Second * 3)}, clientopts...)
|
|
tls := cmd.TLSConfiguration()
|
|
tlsConfig, err := server.GetTLSConfig(&tls, cmd.Logger())
|
|
if err != nil {
|
|
return nil, errors.Wrap(err, "getting tls config")
|
|
}
|
|
client, err := http.NewInternalClient(cmd.TLSHost(), http.GetHTTPClient(tlsConfig, clientopts...), internalopts...)
|
|
if err != nil {
|
|
return nil, errors.Wrap(err, "getting internal client")
|
|
}
|
|
return client, err
|
|
}
|
|
|
|
// separateOptions splits the list of AnyClientOption into the two
|
|
// possible types.
|
|
func separateOptions(opts ...AnyClientOption) ([]http.InternalClientOption, []http.ClientOption, error) {
|
|
internalopts := []http.InternalClientOption{}
|
|
clientopts := []http.ClientOption{}
|
|
for _, opt := range opts {
|
|
if iopt, ok := opt.(http.InternalClientOption); ok {
|
|
internalopts = append(internalopts, iopt)
|
|
continue
|
|
}
|
|
if copt, ok := opt.(http.ClientOption); ok {
|
|
clientopts = append(clientopts, copt)
|
|
continue
|
|
}
|
|
return nil, nil, errors.Errorf("opt: %+v of type %[1]T must be an InternalClientOption or a ClientOption", opt)
|
|
}
|
|
return internalopts, clientopts, nil
|
|
}
|