mirror of
https://github.com/featurebasedb/featurebase.git
synced 2026-08-28 10:54:59 +00:00
* Formatting adjustments made during code review. While reviewing the BULK INSERT logic (in order to decide how best to approach "ingest via sql" in the cloud), I made a few formatting and comment changes. I'm just adding them here as a separate commit so they don't muddy up my actual work. * Parser modifications to support mulitple tuples in INSERT INTO This commit doesn't include all of the changes required in the planner. Fow now, the planner is simply modified to continue supporting a single tuple (the first tuple in the list). * Update the planner to handle multiple INSERT INTO tuples This is part 1. It's still using the existing logic which builds an ImportRequest for every record (and every field!). The next step will involve using a client.Batch to handle the records. * Introduce client.Importer interface (used by client.Batch) Instead of the Batch having a pointer to a client, this puts an interface there instead (which the client implements). It also allows us to inject a different importer (i.e. other than a featurebase.client) into the Batch. * Decouple batch from client This commit pulls batch-specific code out of the client package and into a new batch package. It introduces the batch.Importer interface, the methods of which replace all the calls that batch was previously making directly to client methods. Finally, it contains two implementations of the batch.Importer interface: one is a wrapper around client, and the other is a wrapper around featurebase.API. * Use docker (instead of MustRunCluster) for internal batch tests Because the `batch` package tests are internal, using test.MustRunCluster() resulted in an import loop (because it eventually imports `server`, and we can't have that). So this commit replaces the use of `test.MustRunCluster()` with docker. The setup is basically the same as that used in the idk docker tests. Here we also remove all client-side references to `UseIngestAPI`, which is an experimental (json) ingest api. It's still suppored on the server, but here we remove the external usage of it. * cherry-pick fix * Use batch.Import() for sql3 INSERT INTO statements * Thread logger into sql3 * fix batch test * Fix some shadowing complaint by linter * Address some test issues related to stringsets * Exclude batch integration tests from CI * Address PR feedback - Added description to batch.README - Consolidated grep commands in .gitlab-ci.yml - Removed some debugging comments - Replaces some inadvertantly removed license headers * Add batch package to gitlab CI * Updated CI for batch package Updated CI include path Update gitlab ci Update CI Update CI Trying new include path for ci Updated gitlab ci include path Made idk race job optional for sonarcloud upload add testdata directory remove testenv from dockercompose file use GIT_STRATEGY clone in batch CI add testdata volume to dockercompose Co-authored-by: Fletcher Haynes <fletcher.haynes@generalassemb.ly>
207 lines
5.9 KiB
Go
207 lines
5.9 KiB
Go
// Copyright 2021 Molecula Corp. All rights reserved.
|
|
|
|
package planner
|
|
|
|
import (
|
|
"context"
|
|
"encoding/json"
|
|
|
|
pilosa "github.com/molecula/featurebase/v3"
|
|
"github.com/molecula/featurebase/v3/batch"
|
|
"github.com/molecula/featurebase/v3/logger"
|
|
"github.com/molecula/featurebase/v3/sql3"
|
|
"github.com/molecula/featurebase/v3/sql3/parser"
|
|
"github.com/molecula/featurebase/v3/sql3/planner/types"
|
|
)
|
|
|
|
// PlannerScope holds scope for the planner
|
|
// there is a stack of these in the ExecutionPlanner and some corresponding push/pop functions
|
|
// this allows us to do scoped operations without passing stuff down into
|
|
// every function
|
|
type PlannerScope struct {
|
|
scope types.PlanOperator
|
|
}
|
|
|
|
// ExecutionPlanner compiles SQL text into a query plan
|
|
type ExecutionPlanner struct {
|
|
executor pilosa.Executor
|
|
schemaAPI pilosa.SchemaAPI
|
|
computeAPI pilosa.ComputeAPI
|
|
importer batch.Importer
|
|
logger logger.Logger
|
|
sql string
|
|
scopeStack *scopeStack
|
|
}
|
|
|
|
func NewExecutionPlanner(executor pilosa.Executor, schemaAPI pilosa.SchemaAPI, computeAPI pilosa.ComputeAPI, importer batch.Importer, logger logger.Logger, sql string) *ExecutionPlanner {
|
|
return &ExecutionPlanner{
|
|
executor: executor,
|
|
schemaAPI: schemaAPI,
|
|
computeAPI: computeAPI,
|
|
importer: importer,
|
|
logger: logger,
|
|
sql: sql,
|
|
scopeStack: newScopeStack(),
|
|
}
|
|
}
|
|
|
|
// CompilePlan takes an AST (parser.Statement) and compiles into a query plan returning the root
|
|
// PlanOperator
|
|
// The act of compiling includes an analysis step that does semantic analysis of the AST, this includes
|
|
// type checking, and sometimes AST rewriting. The compile phase uses the type-checked and rewritten AST
|
|
// to produce a query plan.
|
|
func (p *ExecutionPlanner) CompilePlan(ctx context.Context, stmt parser.Statement) (types.PlanOperator, error) {
|
|
// call analyze first
|
|
err := p.analyzePlan(stmt)
|
|
if err != nil {
|
|
return nil, err
|
|
}
|
|
|
|
var rootOperator types.PlanOperator
|
|
switch stmt := stmt.(type) {
|
|
case *parser.SelectStatement:
|
|
rootOperator, err = p.compileSelectStatement(stmt, false)
|
|
case *parser.ShowTablesStatement:
|
|
rootOperator, err = p.compileShowTablesStatement(stmt)
|
|
case *parser.ShowColumnsStatement:
|
|
rootOperator, err = p.compileShowColumnsStatement(stmt)
|
|
case *parser.CreateTableStatement:
|
|
rootOperator, err = p.compileCreateTableStatement(stmt)
|
|
case *parser.AlterTableStatement:
|
|
rootOperator, err = p.compileAlterTableStatement(stmt)
|
|
case *parser.DropTableStatement:
|
|
rootOperator, err = p.compileDropTableStatement(stmt)
|
|
case *parser.InsertStatement:
|
|
rootOperator, err = p.compileInsertStatement(stmt)
|
|
case *parser.BulkInsertStatement:
|
|
rootOperator, err = p.compileBulkInsertStatement(stmt)
|
|
default:
|
|
return nil, sql3.NewErrInternalf("cannot plan statement: %T", stmt)
|
|
}
|
|
|
|
// Optimize the plan.
|
|
if err == nil {
|
|
rootOperator, err = p.optimizePlan(ctx, rootOperator)
|
|
}
|
|
|
|
// Log the plan. This happens even if an error occurred.
|
|
switch rootOperator.(type) {
|
|
case *PlanOpInsert:
|
|
// Don't log the insert plan since it can be very large.
|
|
case nil:
|
|
// pass
|
|
default:
|
|
plan := rootOperator.Plan()
|
|
a, _ := json.MarshalIndent(plan, "", " ")
|
|
p.logger.Debugf(string(a))
|
|
}
|
|
|
|
return rootOperator, err
|
|
}
|
|
|
|
func (p *ExecutionPlanner) analyzePlan(stmt parser.Statement) error {
|
|
switch stmt := stmt.(type) {
|
|
case *parser.SelectStatement:
|
|
return p.analyzeSelectStatement(stmt)
|
|
case *parser.ShowTablesStatement:
|
|
return nil
|
|
case *parser.ShowColumnsStatement:
|
|
return nil
|
|
case *parser.CreateTableStatement:
|
|
return p.analyzeCreateTableStatement(stmt)
|
|
case *parser.AlterTableStatement:
|
|
return p.analyzeAlterTableStatement(stmt)
|
|
case *parser.DropTableStatement:
|
|
return nil
|
|
case *parser.InsertStatement:
|
|
return p.analyzeInsertStatement(stmt)
|
|
case *parser.BulkInsertStatement:
|
|
return p.analyzeBulkInsertStatement(stmt)
|
|
default:
|
|
return sql3.NewErrInternalf("cannot analyze statement: %T", stmt)
|
|
}
|
|
}
|
|
|
|
type accessType byte
|
|
|
|
const (
|
|
accessTypeReadData accessType = iota
|
|
accessTypeWriteData
|
|
accessTypeCreateObject
|
|
accessTypeAlterObject
|
|
accessTypeDropObject
|
|
)
|
|
|
|
func (p *ExecutionPlanner) checkAccess(ctx context.Context, objectName string, _ accessType) error {
|
|
return nil
|
|
}
|
|
|
|
// convenience function that allows the planner to keep track of aggregates so we can
|
|
// use them during optimization
|
|
func (p *ExecutionPlanner) addAggregate(agg types.PlanExpression) error {
|
|
table := p.scopeStack.read()
|
|
if table == nil {
|
|
return sql3.NewErrInternalf("unexpected symbol table state")
|
|
}
|
|
|
|
switch s := table.scope.(type) {
|
|
case *PlanOpQuery:
|
|
s.aggregates = append(s.aggregates, agg)
|
|
}
|
|
return nil
|
|
}
|
|
|
|
// addReference is a convenience function that allows the planner to keep track
|
|
// of references so we can use them during optimization.
|
|
func (p *ExecutionPlanner) addReference(ref *qualifiedRefPlanExpression) error {
|
|
table := p.scopeStack.read()
|
|
if table == nil {
|
|
return sql3.NewErrInternalf("unexpected symbol table state")
|
|
}
|
|
|
|
switch s := table.scope.(type) {
|
|
case *PlanOpQuery:
|
|
s.referenceList = append(s.referenceList, ref)
|
|
}
|
|
return nil
|
|
}
|
|
|
|
// scopeStack is a stack of PlannerScope with the usual push/pop methods.
|
|
type scopeStack struct {
|
|
st []*PlannerScope
|
|
}
|
|
|
|
// newScopeStack returns a scope stack initialized with zero elements on the
|
|
// stack.
|
|
func newScopeStack() *scopeStack {
|
|
return &scopeStack{
|
|
st: make([]*PlannerScope, 0),
|
|
}
|
|
}
|
|
|
|
// push adds the provided PlanOperator (as the scope of a PlannerScope) to the
|
|
// scope stack.
|
|
func (ss *scopeStack) push(scope types.PlanOperator) {
|
|
ss.st = append(ss.st, &PlannerScope{
|
|
scope: scope,
|
|
})
|
|
}
|
|
|
|
// pop removes (and returns) the last scope pushed to the stack.
|
|
func (ss *scopeStack) pop() *PlannerScope {
|
|
if len(ss.st) == 0 {
|
|
return nil
|
|
}
|
|
ret := ss.st[len(ss.st)-1]
|
|
ss.st = ss.st[:len(ss.st)-1]
|
|
return ret
|
|
}
|
|
|
|
// read returns the last scope pushed to the stack, but unlike pop, it does not
|
|
// remove it.
|
|
func (ss *scopeStack) read() *PlannerScope {
|
|
if len(ss.st) == 0 {
|
|
return nil
|
|
}
|
|
return ss.st[len(ss.st)-1]
|
|
}
|