mirror of
https://github.com/featurebasedb/featurebase.git
synced 2026-08-28 02:44:59 +00:00
stdout/stderr around
A lot of functions in the cmd and ctl packages were passing these
around and barely using them. Replaced them with a logger for most
functions. Some functions get an io.Writer instead so that their
tests can find the output they're looking for.
More cleanup on fb-1766: reworked the tests that were using io.Pipe
or os.Pipe to check their results so they now use a bytes.Buffer.
Unexported some variables that didn't need to be exported.
Fixed NewConfigCommand to use the provided stderr, not os.Stderr.
Added tests for rbf_dump, rbf_page, and keygen, since those weren't
being tested at all.
Added chksum_test, final cleanup.
(cherry picked from commit f627199acb)
35 lines
826 B
Go
35 lines
826 B
Go
// Copyright 2022 Molecula Corp. (DBA FeatureBase).
|
|
// SPDX-License-Identifier: Apache-2.0
|
|
package cmd
|
|
|
|
import (
|
|
"context"
|
|
"io"
|
|
|
|
"github.com/spf13/cobra"
|
|
|
|
"github.com/featurebasedb/featurebase/v3/ctl"
|
|
"github.com/featurebasedb/featurebase/v3/server"
|
|
)
|
|
|
|
var conf *ctl.ConfigCommand
|
|
|
|
func newConfigCommand(stderr io.Writer) *cobra.Command {
|
|
conf = ctl.NewConfigCommand(stderr)
|
|
Server := server.NewCommand(stderr)
|
|
confCmd := &cobra.Command{
|
|
Use: "config",
|
|
Short: "Print the current configuration.",
|
|
Long: `config prints the current configuration to stdout`,
|
|
|
|
RunE: func(cmd *cobra.Command, args []string) error {
|
|
conf.Config = Server.Config
|
|
return considerUsageError(cmd, conf.Run(context.Background()))
|
|
},
|
|
}
|
|
|
|
// Attach flags to the command.
|
|
ctl.BuildServerFlags(confCmd, Server)
|
|
|
|
return confCmd
|
|
}
|