Samir Patel
f011587d4e
add tests
2021-12-21 10:08:49 -06:00
Samir Patel
1c907281bf
authz changes
2021-12-20 18:03:18 -06:00
Samir Patel
10a7aa55ea
same-site strict
2021-12-20 18:00:13 -06:00
Samir Patel
d9710cb7d7
remove auth struct from authorization
2021-12-20 16:45:17 -06:00
Samir Patel
3b374a62bf
Merge branch 'master' into 54mir/authentication
2021-12-20 16:42:11 -06:00
Hoang Pham
a24a1e8922
UI - added fixes for PR comments
2021-12-20 15:55:52 -06:00
Samir Patel
602145b390
add to tests
2021-12-20 15:41:18 -06:00
Matthew Jaffee
18d2ef3d53
Merge pull request #1818 from molecula/fb1107
...
[FB-1107] slightly better lock protection around bitDepth in view
2021-12-20 15:31:13 -06:00
Seebs
ddb5020aa6
slightly better lock protection around bitDepth in view
...
There's a number of deeper issues here (the fragment is conjuring
up a Tx, for instance) but this helps.
Also use field.view() to get the view rather than accessing viewMap
directly without a lock. Also change field.cacheBitDepth to ratchet
upwards -- if we have multiple shards and some shards have lower
depths than others, we should use the highest as the cached value,
not the most recent.
2021-12-20 15:09:27 -06:00
Ben Johnson
3c082b7d2c
Merge pull request #1819 from molecula/rbf-check-empty-branch
...
[FB-1105] Add rbf check for empty branch pages
2021-12-20 14:01:10 -07:00
Ben Johnson
60f0008dec
Merge branch 'master' into rbf-check-empty-branch
2021-12-20 13:40:34 -07:00
Samir Patel
6faa889bfb
move logout url to conf
2021-12-20 14:30:19 -06:00
Ben Johnson
6481b4eabe
Add rbf check for empty branch pages
2021-12-20 13:24:34 -07:00
Matthew Jaffee
3de18a9f77
Merge pull request #1816 from molecula/fb-1105
...
[FB-1105] Fix RBF multi-level branch delete
2021-12-20 14:13:24 -06:00
Ben Johnson
5f8a281918
Fix RBF multi-level branch delete
...
This commit fixes a bug in RBF where deleting all the elements in
a bitmap that has a depth greater than 2 will cause the root bitmap
to be a branch page with a cell count of zero. This breaks an
assertion in `readBranchCell()` which causes a panic post-commit.
A new assertion has been added to prevent a branch page from being
written with a zero count in the future.
2021-12-20 12:52:14 -07:00
Samir Patel
405692e376
Update authn/authenticate_test.go
...
Co-authored-by: souhailanoor <90720110+souhailanoor@users.noreply.github.com>
2021-12-20 13:16:34 -06:00
souhailanoor
7d0e0600d6
Merge pull request #1805 from molecula/fb1000
...
FB-1000: Ability to map user groups to cluster admin / index-level permissions
2021-12-20 13:07:13 -06:00
souhailanoor
55c67a9d1f
Merge branch 'master' into fb1000
2021-12-20 12:35:17 -06:00
seebs
88569789dd
Merge pull request #1817 from molecula/pages
...
rbf pages subcommand: don't panic on invalid page type
2021-12-20 12:30:57 -06:00
Hoang Pham
fa96d39cd0
Merge branch '54mir/authentication' of ssh://github.com/molecula/featurebase into 54mir/authentication
2021-12-20 12:30:27 -06:00
Hoang Pham
c91e7dc8de
UI - renamed authOn to isAuthOn
2021-12-20 12:28:38 -06:00
Samir Patel
89f360c1ce
Merge branch '54mir/authentication' of github.com:molecula/featurebase into 54mir/authentication
2021-12-20 12:28:26 -06:00
Samir Patel
e7f4eb1e36
response codes
2021-12-20 12:28:17 -06:00
Hoang Pham
7dc9df425d
UI - removed unnecessary code
2021-12-20 12:23:55 -06:00
Hoang Pham
9086587e06
Changed how the UI processes /auth to turn on/off authentication
2021-12-20 12:19:56 -06:00
Seebs
977a699a98
don't panic on invalid page type
...
debugging tools shouldn't panic when they encounter bugs. insert
"you had one job" meme.
2021-12-20 10:58:41 -06:00
Hoang Pham
d7ba3c8334
UI - changed createTheme back to createMuiTheme
2021-12-20 09:57:07 -06:00
Samir Patel
daeebf98eb
more test cleanup
2021-12-20 09:43:30 -06:00
Samir Patel
67d438aab5
clean up
2021-12-20 01:29:11 -06:00
Samir Patel
605d47702e
add handler tests
2021-12-20 00:15:48 -06:00
Samir Patel
4b4095f13e
Merge branch '54mir/authentication' of github.com:molecula/featurebase into 54mir/authentication
2021-12-19 23:35:07 -06:00
Samir Patel
0d52a952e0
resolve some comments
2021-12-19 23:33:44 -06:00
souhailanoor
e82088e086
Merge branch 'master' into fb1000
2021-12-19 11:38:08 -06:00
Souhaila Noor
c14bd08213
updated admin to be at the cluster level
2021-12-19 11:37:41 -06:00
Ben Johnson
06204bcf7b
Merge pull request #1809 from molecula/fb992
...
[FB-992] Implement RBF Async Checkpoint
2021-12-18 13:08:42 -07:00
Matthew Jaffee
7826c06eee
use atomics for currentWorker to avoid race
2021-12-18 09:04:04 -06:00
Seebs
8974014d57
too tired to be writing code
2021-12-17 22:48:40 -06:00
Seebs
1439c316d3
read-only lock for check of shutdown
2021-12-17 22:25:01 -06:00
Seebs
9a2a8f964c
fix silly typo in worker pool downscaling
2021-12-17 22:22:27 -06:00
Seebs
8f217ab099
scale down worker pool when it's large
...
if we have more than twice our starting worker pool, and have had no
tasks when checking the queue for multiple rounds, send a job telling
the system to retire a worker. eventually we'll get down to about 2x
the starting pool size if we stay idle.
2021-12-17 22:05:41 -06:00
Seebs
9945575bf1
create a new worker every so often if progress isn't happening
...
this is very approximate and may be a mess and may be unbounded, but
in practice i think it should be okay. if it's not we'll have an
adventure.
2021-12-17 21:57:38 -06:00
Hoang Pham
89a628e91a
Added Featurebase UI code for authentication
2021-12-17 18:20:20 -06:00
Seebs
41f6156bda
don't use write Tx even when we're using the expensive logic for write Tx
2021-12-17 17:57:33 -06:00
Souhaila Noor
a606bd030a
addressed reviewer's feedback
2021-12-17 16:46:07 -06:00
Souhaila Noor
f05f1d0de2
added more authz functionality
2021-12-17 15:51:37 -06:00
Matthew Jaffee
0799862266
move some locks, nbd
2021-12-17 15:09:25 -06:00
Matthew Jaffee
1fd872b126
less write locks in fragment.importRoaring/row
2021-12-17 15:09:25 -06:00
Ben Johnson
57ca5591a2
Unlock rbf.DB during WAL copy & fsync()
2021-12-17 15:09:25 -06:00
Seebs
47e098c3b1
simplify txWaiter
...
We don't need a condition variable for a thing with a single waiter
which waits only once, and a data structure which only one side ever
modifies. That's a closable channel.
2021-12-17 15:09:25 -06:00
Seebs
994cc03e88
fix locking and list management for afterCurrentTx
...
Two issues: First, there was a race condition because we were never
using the mutex for anything but the condvar broadcast, second, there
was no reason for the afterCurrentTx to need to maintain the list since
we already know where in the list we are when we are waking it up.
afterCurrentTx still wants to run with the db lock held, because
the degenerate case (no outstanding Tx) means that it will be running
with it held already. That's for another commit.
2021-12-17 15:09:25 -06:00
